remove old obsolete check for excess data in request (#18830)
Costa Tsaousis committed
Oct 21, 2024 at 11:04 UTC
99c82c846a82442985fcc7df601ce41ce2c3cffd
2 files changed
-19
src/web/server/web_client.c
-18
@@ -740,17 +740,6 @@ HTTP_VALIDATION http_request_validate(struct web_client *w) {
740
741
return HTTP_VALIDATION_NOT_SUPPORTED;
742
} else if (!is_it_valid) {
743
- //Invalid request, we have more data after the end of message
744
- char *check = strstr((char *)buffer_tostring(w->response.data), "\r\n\r\n");
745
- if(check) {
746
- check += 4;
747
- if (*check) {
748
- w->header_parse_tries = 0;
749
- w->header_parse_last_size = 0;
750
- web_client_disable_wait_receive(w);
751
- return HTTP_VALIDATION_EXCESS_REQUEST_DATA;
752
- }
753
- }
743
web_client_enable_wait_receive(w);
744
return HTTP_VALIDATION_INCOMPLETE;
745
}
@@ -1473,13 +1462,6 @@ void web_client_process_request_from_web_server(struct web_client *w) {
1462
buffer_strcat(w->response.data, "Malformed URL...\r\n");
1463
w->response.code = HTTP_RESP_BAD_REQUEST;
1464
break;
1476
- case HTTP_VALIDATION_EXCESS_REQUEST_DATA:
1477
- netdata_log_debug(D_WEB_CLIENT_ACCESS, "%llu: Excess data in request '%s'.", w->id, w->response.data->buffer);
1478
-
1479
- buffer_flush(w->response.data);
1480
- buffer_strcat(w->response.data, "Excess data in request.\r\n");
1481
- w->response.code = HTTP_RESP_BAD_REQUEST;
1482
- break;
1465
case HTTP_VALIDATION_TOO_MANY_READ_RETRIES:
1466
netdata_log_debug(D_WEB_CLIENT_ACCESS, "%llu: Too many retries to read request '%s'.", w->id, w->response.data->buffer);
1467
src/web/server/web_client.h
-1
@@ -18,7 +18,6 @@ typedef enum __attribute__((packed)) {
18
HTTP_VALIDATION_OK,
19
HTTP_VALIDATION_NOT_SUPPORTED,
20
HTTP_VALIDATION_TOO_MANY_READ_RETRIES,
21
- HTTP_VALIDATION_EXCESS_REQUEST_DATA,
21
HTTP_VALIDATION_MALFORMED_URL,
22
HTTP_VALIDATION_INCOMPLETE,
23
HTTP_VALIDATION_REDIRECT