@cryptotaxi247 / netdata-1 / commits / 9daacb548

Update contexts - eBPF.plugin (part II) (#17819)

thiagoftsm committed Jun 5, 2024 at 07:37 UTC 9daacb548fd0b140830bc30f0dc199625a537a7e

13 files changed +90 -59

src/collectors/ebpf.plugin/ebpf_fd.c

+9 -12

@@ -521,7 +521,7 @@ static void ebpf_obsolete_fd_global(ebpf_module_t *em)

521 EBPF_COMMON_UNITS_CALLS_PER_SEC,

522 NETDATA_FILE_GROUP,

523 NETDATA_EBPF_CHART_TYPE_LINE,

524 - NULL,

524 + NETDATA_FS_FILEDESCRIPTOR_CONTEXT,

525 NETDATA_CHART_PRIO_EBPF_FD_CHARTS,

526 em->update_every);

527

@@ -533,7 +533,7 @@ static void ebpf_obsolete_fd_global(ebpf_module_t *em)

533 EBPF_COMMON_UNITS_CALLS_PER_SEC,

534 NETDATA_FILE_GROUP,

535 NETDATA_EBPF_CHART_TYPE_LINE,

536 - NULL,

536 + NETDATA_FS_FILEDESCRIPTOR_ERROR_CONTEXT,

537 NETDATA_CHART_PRIO_EBPF_FD_CHARTS + 1,

538 em->update_every);

539 }

@@ -1032,7 +1032,7 @@ static void ebpf_create_systemd_fd_charts(ebpf_module_t *em)

1032 .units = EBPF_COMMON_UNITS_CALLS_PER_SEC,

1033 .family = NETDATA_APPS_FILE_GROUP,

1034 .charttype = NETDATA_EBPF_CHART_TYPE_STACKED,

1035 - .order = 20061,

1035 + .order = 20270,

1036 .algorithm = EBPF_CHART_ALGORITHM_INCREMENTAL,

1037 .context = NETDATA_SYSTEMD_FD_OPEN_CONTEXT,

1038 .module = NETDATA_EBPF_MODULE_NAME_FD,

@@ -1046,7 +1046,7 @@ static void ebpf_create_systemd_fd_charts(ebpf_module_t *em)

1046 .units = EBPF_COMMON_UNITS_CALLS_PER_SEC,

1047 .family = NETDATA_APPS_FILE_GROUP,

1048 .charttype = NETDATA_EBPF_CHART_TYPE_STACKED,

1049 - .order = 20062,

1049 + .order = 20271,

1050 .algorithm = EBPF_CHART_ALGORITHM_INCREMENTAL,

1051 .context = NETDATA_SYSTEMD_FD_OPEN_ERR_CONTEXT,

1052 .module = NETDATA_EBPF_MODULE_NAME_FD,

@@ -1060,7 +1060,7 @@ static void ebpf_create_systemd_fd_charts(ebpf_module_t *em)

1060 .units = EBPF_COMMON_UNITS_CALLS_PER_SEC,

1061 .family = NETDATA_APPS_FILE_GROUP,

1062 .charttype = NETDATA_EBPF_CHART_TYPE_STACKED,

1063 - .order = 20063,

1063 + .order = 20272,

1064 .algorithm = EBPF_CHART_ALGORITHM_INCREMENTAL,

1065 .context = NETDATA_SYSTEMD_FD_CLOSE_CONTEXT,

1066 .module = NETDATA_EBPF_MODULE_NAME_FD,

@@ -1074,7 +1074,7 @@ static void ebpf_create_systemd_fd_charts(ebpf_module_t *em)

1074 .units = EBPF_COMMON_UNITS_CALLS_PER_SEC,

1075 .family = NETDATA_APPS_FILE_GROUP,

1076 .charttype = NETDATA_EBPF_CHART_TYPE_STACKED,

1077 - .order = 20064,

1077 + .order = 20273,

1078 .algorithm = EBPF_CHART_ALGORITHM_INCREMENTAL,

1079 .context = NETDATA_SYSTEMD_FD_OPEN_ERR_CONTEXT,

1080 .module = NETDATA_EBPF_MODULE_NAME_FD,

@@ -1095,12 +1095,9 @@ static void ebpf_create_systemd_fd_charts(ebpf_module_t *em)

1095

1096 data_open.id = data_open_error.id = data_close.id = data_close_error.id = w->name;

1097 ebpf_create_charts_on_systemd(&data_open);

1098 - if (mode < MODE_ENTRY) {

1099 - ebpf_create_charts_on_systemd(&data_open_error);

1100 - }

1101 -

1098 ebpf_create_charts_on_systemd(&data_close);

1099 if (mode < MODE_ENTRY) {

1100 + ebpf_create_charts_on_systemd(&data_open_error);

1101 ebpf_create_charts_on_systemd(&data_close_error);

1102 }

1103

@@ -1345,7 +1342,7 @@ static void ebpf_create_fd_global_charts(ebpf_module_t *em)

1342 "Open and close calls",

1343 EBPF_COMMON_UNITS_CALLS_PER_SEC,

1344 NETDATA_FILE_GROUP,

1348 - NULL,

1345 + NETDATA_FS_FILEDESCRIPTOR_CONTEXT,

1346 NETDATA_EBPF_CHART_TYPE_LINE,

1347 NETDATA_CHART_PRIO_EBPF_FD_CHARTS,

1348 ebpf_create_global_dimension,

@@ -1359,7 +1356,7 @@ static void ebpf_create_fd_global_charts(ebpf_module_t *em)

1356 "Open fails",

1357 EBPF_COMMON_UNITS_CALLS_PER_SEC,

1358 NETDATA_FILE_GROUP,

1362 - NULL,

1359 + NETDATA_FS_FILEDESCRIPTOR_ERROR_CONTEXT,

1360 NETDATA_EBPF_CHART_TYPE_LINE,

1361 NETDATA_CHART_PRIO_EBPF_FD_CHARTS + 1,

1362 ebpf_create_global_dimension,

src/collectors/ebpf.plugin/ebpf_fd.h

@@ -24,6 +24,9 @@

24 #define NETDATA_FD_CONFIG_FILE "fd.conf"

26 // Contexts

27 +#define NETDATA_FS_FILEDESCRIPTOR_CONTEXT "filesystem.file_descriptor"

28 +#define NETDATA_FS_FILEDESCRIPTOR_ERROR_CONTEXT "filesystem.file_error"

29 +

30 #define NETDATA_CGROUP_FD_OPEN_CONTEXT "cgroup.fd_open"

31 #define NETDATA_CGROUP_FD_OPEN_ERR_CONTEXT "cgroup.fd_open_error"

32 #define NETDATA_CGROUP_FD_CLOSE_CONTEXT "cgroup.fd_close"

src/collectors/ebpf.plugin/ebpf_filesystem.c

+23

@@ -656,6 +656,23 @@ void ebpf_filesystem_cleanup_ebpf_data()

656 }

657 }

658

659 +/**

660 + * Cleanup FS Histograms

661 + *

662 + * @param ptr pointer to structure to be cleaned

663 + */

664 +static void ebpf_cleanup_fs_histograms(netdata_ebpf_histogram_t *ptr)

665 +{

666 + freez(ptr->name);

667 + ptr->name = NULL;

668 +

669 + freez(ptr->title);

670 + ptr->title = NULL;

671 +

672 + freez(ptr->ctx);

673 + ptr->ctx = NULL;

674 +}

675 +

676 /**

677 * Obsolete global

678 *

@@ -681,6 +698,7 @@ static void ebpf_obsolete_filesystem_global(ebpf_module_t *em)

698 "filesystem.read_latency",

699 efp->hread.order,

700 em->update_every);

701 + ebpf_cleanup_fs_histograms(&efp->hread);

702

703 ebpf_write_chart_obsolete(NETDATA_FILESYSTEM_FAMILY,

704 efp->hwrite.name,

@@ -692,6 +710,7 @@ static void ebpf_obsolete_filesystem_global(ebpf_module_t *em)

710 "filesystem.write_latency",

711 efp->hwrite.order,

712 em->update_every);

713 + ebpf_cleanup_fs_histograms(&efp->hwrite);

714

715 ebpf_write_chart_obsolete(NETDATA_FILESYSTEM_FAMILY,

716 efp->hopen.name,

@@ -703,6 +722,7 @@ static void ebpf_obsolete_filesystem_global(ebpf_module_t *em)

722 "filesystem.open_latency",

723 efp->hopen.order,

724 em->update_every);

725 + ebpf_cleanup_fs_histograms(&efp->hopen);

726

727 ebpf_write_chart_obsolete(NETDATA_FILESYSTEM_FAMILY,

728 efp->hadditional.name,

@@ -714,6 +734,9 @@ static void ebpf_obsolete_filesystem_global(ebpf_module_t *em)

734 efp->hadditional.ctx,

735 efp->hadditional.order,

736 em->update_every);

737 + ebpf_cleanup_fs_histograms(&efp->hadditional);

738 +

739 + efp->flags = NETDATA_FILESYSTEM_FLAG_NO_PARTITION;

740 }

741 }

742

src/collectors/ebpf.plugin/ebpf_hardirq.c

+2 -2

@@ -231,7 +231,7 @@ static void ebpf_obsolete_hardirq_global(ebpf_module_t *em)

231 EBPF_COMMON_UNITS_MILLISECONDS,

232 "interrupts",

233 NETDATA_EBPF_CHART_TYPE_STACKED,

234 - NULL,

234 + NETDATA_EBPF_SYSTEM_HARDIRQ_LATENCY_CTX,

235 NETDATA_CHART_PRIO_HARDIRQ_LATENCY,

236 em->update_every

237 );

@@ -502,7 +502,7 @@ static void hardirq_create_charts(int update_every)

502 "Hardware IRQ latency",

503 EBPF_COMMON_UNITS_MILLISECONDS,

504 "interrupts",

505 - NULL,

505 + NETDATA_EBPF_SYSTEM_HARDIRQ_LATENCY_CTX,

506 NETDATA_EBPF_CHART_TYPE_STACKED,

507 NETDATA_CHART_PRIO_HARDIRQ_LATENCY,

508 NULL, NULL, 0, update_every,

src/collectors/ebpf.plugin/ebpf_hardirq.h

@@ -75,6 +75,8 @@ typedef struct hardirq_static_val {

75 uint64_t latency;

76 } hardirq_static_val_t;

78 +#define NETDATA_EBPF_SYSTEM_HARDIRQ_LATENCY_CTX "system.hardirq_latency"

79 +

80 extern struct config hardirq_config;

81 void *ebpf_hardirq_thread(void *ptr);

src/collectors/ebpf.plugin/ebpf_mdflush.c

+2 -2

@@ -145,7 +145,7 @@ static void ebpf_obsolete_mdflush_global(ebpf_module_t *em)

145 "flushes",

146 "flush (eBPF)",

147 NETDATA_EBPF_CHART_TYPE_STACKED,

148 - NULL,

148 + "mdstat.mdstat_flush",

149 NETDATA_CHART_PRIO_MDSTAT_FLUSH,

150 em->update_every);

151 }

@@ -292,7 +292,7 @@ static void mdflush_create_charts(int update_every)

292 "MD flushes",

293 "flushes",

294 "flush (eBPF)",

295 - "md.flush",

295 + "mdstat.mdstat_flush",

296 NETDATA_EBPF_CHART_TYPE_STACKED,

297 NETDATA_CHART_PRIO_MDSTAT_FLUSH,

298 NULL, NULL, 0, update_every,

src/collectors/ebpf.plugin/ebpf_mount.c

+4 -4

@@ -238,7 +238,7 @@ static void ebpf_obsolete_mount_global(ebpf_module_t *em)

238 EBPF_COMMON_UNITS_CALLS_PER_SEC,

239 NETDATA_EBPF_MOUNT_FAMILY,

240 NETDATA_EBPF_CHART_TYPE_LINE,

241 - NULL,

241 + "mount_points.call",

242 NETDATA_CHART_PRIO_EBPF_MOUNT_CHARTS,

243 em->update_every);

244

@@ -249,7 +249,7 @@ static void ebpf_obsolete_mount_global(ebpf_module_t *em)

249 EBPF_COMMON_UNITS_CALLS_PER_SEC,

250 NETDATA_EBPF_MOUNT_FAMILY,

251 NETDATA_EBPF_CHART_TYPE_LINE,

252 - NULL,

252 + "mount_points.error",

253 NETDATA_CHART_PRIO_EBPF_MOUNT_CHARTS + 1,

254 em->update_every);

255 }

@@ -412,7 +412,7 @@ static void ebpf_create_mount_charts(int update_every)

412 ebpf_create_chart(NETDATA_EBPF_MOUNT_GLOBAL_FAMILY, NETDATA_EBPF_MOUNT_CALLS,

413 "Calls to mount and umount syscalls",

414 EBPF_COMMON_UNITS_CALLS_PER_SEC, NETDATA_EBPF_MOUNT_FAMILY,

415 - NULL,

415 + "mount_points.call",

416 NETDATA_EBPF_CHART_TYPE_LINE,

417 NETDATA_CHART_PRIO_EBPF_MOUNT_CHARTS,

418 ebpf_create_global_dimension,

@@ -422,7 +422,7 @@ static void ebpf_create_mount_charts(int update_every)

422 ebpf_create_chart(NETDATA_EBPF_MOUNT_GLOBAL_FAMILY, NETDATA_EBPF_MOUNT_ERRORS,

423 "Errors to mount and umount file systems",

424 EBPF_COMMON_UNITS_CALLS_PER_SEC, NETDATA_EBPF_MOUNT_FAMILY,

425 - NULL,

425 + "mount_points.error",

426 NETDATA_EBPF_CHART_TYPE_LINE,

427 NETDATA_CHART_PRIO_EBPF_MOUNT_CHARTS + 1,

428 ebpf_create_global_dimension,

src/collectors/ebpf.plugin/ebpf_process.c

+13 -13

@@ -260,7 +260,7 @@ static void ebpf_update_process_cgroup()

260 static void ebpf_process_status_chart(char *family, char *name, char *axis,

261 char *web, char *algorithm, int order, int update_every)

262 {

263 - printf("CHART %s.%s '' 'Process not closed' '%s' '%s' '' line %d %d '' 'ebpf.plugin' 'process'\n",

263 + printf("CHART %s.%s '' 'Process not closed' '%s' '%s' 'system.process_status' line %d %d '' 'ebpf.plugin' 'process'\n",

264 family,

265 name,

266 axis,

@@ -286,7 +286,7 @@ static void ebpf_create_global_charts(ebpf_module_t *em)

286 "Start process",

287 EBPF_COMMON_UNITS_CALLS_PER_SEC,

288 NETDATA_PROCESS_GROUP,

289 - NULL,

289 + "system.process_thread",

290 NETDATA_EBPF_CHART_TYPE_LINE,

291 21002,

292 ebpf_create_global_dimension,

@@ -298,7 +298,7 @@ static void ebpf_create_global_charts(ebpf_module_t *em)

298 "Exit process",

299 EBPF_COMMON_UNITS_CALLS_PER_SEC,

300 NETDATA_PROCESS_GROUP,

301 - NULL,

301 + "system.exit",

302 NETDATA_EBPF_CHART_TYPE_LINE,

303 21003,

304 ebpf_create_global_dimension,

@@ -318,7 +318,7 @@ static void ebpf_create_global_charts(ebpf_module_t *em)

318 "Fails to create process",

319 EBPF_COMMON_UNITS_CALLS_PER_SEC,

320 NETDATA_PROCESS_GROUP,

321 - NULL,

321 + "system.task_error",

322 NETDATA_EBPF_CHART_TYPE_LINE,

323 21005,

324 ebpf_create_global_dimension,

@@ -452,7 +452,7 @@ static void ebpf_obsolete_process_services(ebpf_module_t *em, char *id)

452 EBPF_COMMON_UNITS_CALLS_PER_SEC,

453 NETDATA_APPS_PROCESS_GROUP,

454 NETDATA_EBPF_CHART_TYPE_STACKED,

455 - NULL,

455 + NETDATA_SYSTEMD_PROCESS_CREATE_CONTEXT,

456 20065,

457 em->update_every);

458

@@ -463,7 +463,7 @@ static void ebpf_obsolete_process_services(ebpf_module_t *em, char *id)

463 EBPF_COMMON_UNITS_CALLS_PER_SEC,

464 NETDATA_APPS_PROCESS_GROUP,

465 NETDATA_EBPF_CHART_TYPE_STACKED,

466 - NULL,

466 + NETDATA_SYSTEMD_THREAD_CREATE_CONTEXT,

467 20066,

468 em->update_every);

469

@@ -474,7 +474,7 @@ static void ebpf_obsolete_process_services(ebpf_module_t *em, char *id)

474 EBPF_COMMON_UNITS_CALLS_PER_SEC,

475 NETDATA_APPS_PROCESS_GROUP,

476 NETDATA_EBPF_CHART_TYPE_STACKED,

477 - NULL,

477 + NETDATA_SYSTEMD_PROCESS_EXIT_CONTEXT,

478 20067,

479 em->update_every);

480

@@ -485,7 +485,7 @@ static void ebpf_obsolete_process_services(ebpf_module_t *em, char *id)

485 EBPF_COMMON_UNITS_CALLS_PER_SEC,

486 NETDATA_APPS_PROCESS_GROUP,

487 NETDATA_EBPF_CHART_TYPE_STACKED,

488 - NULL,

488 + NETDATA_SYSTEMD_PROCESS_CLOSE_CONTEXT,

489 20068,

490 em->update_every);

491

@@ -497,7 +497,7 @@ static void ebpf_obsolete_process_services(ebpf_module_t *em, char *id)

497 EBPF_COMMON_UNITS_CALLS_PER_SEC,

498 NETDATA_APPS_PROCESS_GROUP,

499 NETDATA_EBPF_CHART_TYPE_STACKED,

500 - NULL,

500 + NETDATA_SYSTEMD_PROCESS_ERROR_CONTEXT,

501 20069,

502 em->update_every);

503 }

@@ -618,7 +618,7 @@ static void ebpf_obsolete_process_global(ebpf_module_t *em)

618 EBPF_COMMON_UNITS_CALLS_PER_SEC,

619 NETDATA_PROCESS_GROUP,

620 NETDATA_EBPF_CHART_TYPE_LINE,

621 - NULL,

621 + "system.process_thread",

622 21002,

623 em->update_every);

624

@@ -629,7 +629,7 @@ static void ebpf_obsolete_process_global(ebpf_module_t *em)

629 EBPF_COMMON_UNITS_CALLS_PER_SEC,

630 NETDATA_PROCESS_GROUP,

631 NETDATA_EBPF_CHART_TYPE_LINE,

632 - NULL,

632 + "system.exit",

633 21003,

634 em->update_every);

635

@@ -640,7 +640,7 @@ static void ebpf_obsolete_process_global(ebpf_module_t *em)

640 EBPF_COMMON_UNITS_CALLS,

641 NETDATA_PROCESS_GROUP,

642 NETDATA_EBPF_CHART_TYPE_LINE,

643 - NULL,

643 + "system.process_status",

644 21004,

645 em->update_every);

646

@@ -652,7 +652,7 @@ static void ebpf_obsolete_process_global(ebpf_module_t *em)

652 EBPF_COMMON_UNITS_CALLS_PER_SEC,

653 NETDATA_PROCESS_GROUP,

654 NETDATA_EBPF_CHART_TYPE_LINE,

655 - NULL,

655 + "system.task_error",

656 21005,

657 em->update_every);

658 }

src/collectors/ebpf.plugin/ebpf_shm.c

+7 -7

@@ -294,7 +294,7 @@ static void ebpf_obsolete_shm_services(ebpf_module_t *em, char *id)

294 EBPF_COMMON_UNITS_CALLS_PER_SEC,

295 NETDATA_APPS_IPC_SHM_GROUP,

296 NETDATA_EBPF_CHART_TYPE_STACKED,

297 - NULL,

297 + NETDATA_SYSTEMD_SHM_GET_CONTEXT,

298 20191,

299 em->update_every);

300

@@ -305,7 +305,7 @@ static void ebpf_obsolete_shm_services(ebpf_module_t *em, char *id)

305 EBPF_COMMON_UNITS_CALLS_PER_SEC,

306 NETDATA_APPS_IPC_SHM_GROUP,

307 NETDATA_EBPF_CHART_TYPE_STACKED,

308 - NULL,

308 + NETDATA_SYSTEMD_SHM_AT_CONTEXT,

309 20192,

310 em->update_every);

311

@@ -316,7 +316,7 @@ static void ebpf_obsolete_shm_services(ebpf_module_t *em, char *id)

316 EBPF_COMMON_UNITS_CALLS_PER_SEC,

317 NETDATA_APPS_IPC_SHM_GROUP,

318 NETDATA_EBPF_CHART_TYPE_STACKED,

319 - NULL,

319 + NETDATA_SYSTEMD_SHM_DT_CONTEXT,

320 20193,

321 em->update_every);

322

@@ -327,8 +327,8 @@ static void ebpf_obsolete_shm_services(ebpf_module_t *em, char *id)

327 EBPF_COMMON_UNITS_CALLS_PER_SEC,

328 NETDATA_APPS_IPC_SHM_GROUP,

329 NETDATA_EBPF_CHART_TYPE_STACKED,

330 - NULL,

331 - 20193,

330 + NETDATA_SYSTEMD_SHM_CTL_CONTEXT,

331 + 20194,

332 em->update_every);

333 }

334

@@ -436,7 +436,7 @@ static void ebpf_obsolete_shm_global(ebpf_module_t *em)

436 EBPF_COMMON_UNITS_CALLS_PER_SEC,

437 NETDATA_SYSTEM_IPC_SHM_SUBMENU,

438 NETDATA_EBPF_CHART_TYPE_LINE,

439 - NULL,

439 + "system.shared_memory_calls",

440 NETDATA_CHART_PRIO_SYSTEM_IPC_SHARED_MEM_CALLS,

441 em->update_every);

442 }

@@ -1266,7 +1266,7 @@ static void ebpf_create_shm_charts(int update_every)

1266 "Calls to shared memory system calls",

1267 EBPF_COMMON_UNITS_CALLS_PER_SEC,

1268 NETDATA_SYSTEM_IPC_SHM_SUBMENU,

1269 - NULL,

1269 + "system.shared_memory_calls",

1270 NETDATA_EBPF_CHART_TYPE_LINE,

1271 NETDATA_CHART_PRIO_SYSTEM_IPC_SHARED_MEM_CALLS,

1272 ebpf_create_global_dimension,

src/collectors/ebpf.plugin/ebpf_softirq.c

+2 -2

@@ -76,7 +76,7 @@ static void ebpf_obsolete_softirq_global(ebpf_module_t *em)

76 EBPF_COMMON_UNITS_MILLISECONDS,

77 "softirqs",

78 NETDATA_EBPF_CHART_TYPE_STACKED,

79 - NULL,

79 + "system.softirq_latency",

80 NETDATA_CHART_PRIO_SYSTEM_SOFTIRQS+1,

81 em->update_every);

82 }

@@ -167,7 +167,7 @@ static void softirq_create_charts(int update_every)

167 "Software IRQ latency",

168 EBPF_COMMON_UNITS_MILLISECONDS,

169 "softirqs",

170 - NULL,

170 + "system.softirq_latency",

171 NETDATA_EBPF_CHART_TYPE_STACKED,

172 NETDATA_CHART_PRIO_SYSTEM_SOFTIRQS+1,

173 NULL, NULL, 0, update_every,

src/collectors/ebpf.plugin/ebpf_swap.c

+6 -6

@@ -281,8 +281,8 @@ static void ebpf_obsolete_swap_services(ebpf_module_t *em, char *id)

281 EBPF_COMMON_UNITS_CALLS_PER_SEC,

282 NETDATA_SYSTEM_SWAP_SUBMENU,

283 NETDATA_EBPF_CHART_TYPE_LINE,

284 - NETDATA_CGROUP_SWAP_READ_CONTEXT,

285 - NETDATA_CHART_PRIO_CGROUPS_CONTAINERS + 5100,

284 + NETDATA_SYSTEMD_SWAP_READ_CONTEXT,

285 + 20191,

286 em->update_every);

287

288 ebpf_write_chart_obsolete(NETDATA_SERVICE_FAMILY,

@@ -293,7 +293,7 @@ static void ebpf_obsolete_swap_services(ebpf_module_t *em, char *id)

293 NETDATA_SYSTEM_SWAP_SUBMENU,

294 NETDATA_EBPF_CHART_TYPE_LINE,

295 NETDATA_CGROUP_SWAP_WRITE_CONTEXT,

296 - NETDATA_CHART_PRIO_CGROUPS_CONTAINERS + 5101,

296 + 20192,

297 em->update_every);

298 }

299

@@ -377,7 +377,7 @@ static void ebpf_obsolete_swap_global(ebpf_module_t *em)

377 "Calls to access swap memory",

378 EBPF_COMMON_UNITS_CALLS_PER_SEC, NETDATA_SYSTEM_SWAP_SUBMENU,

379 NETDATA_EBPF_CHART_TYPE_LINE,

380 - NULL,

380 + "mem.swapcalls",

381 NETDATA_CHART_PRIO_MEM_SWAP_CALLS,

382 em->update_every);

383 }

@@ -815,7 +815,7 @@ static void ebpf_send_specific_swap_data(char *type, netdata_publish_swap_t *val

815 static void ebpf_create_systemd_swap_charts(int update_every)

816 {

817 static ebpf_systemd_args_t data_read = {

818 - .title = "Calls to swap_readpage.",

818 + .title = "Calls to function swap_readpage.",

819 .units = EBPF_COMMON_UNITS_CALLS_PER_SEC,

820 .family = NETDATA_SYSTEM_SWAP_SUBMENU,

821 .charttype = NETDATA_EBPF_CHART_TYPE_STACKED,

@@ -1042,7 +1042,7 @@ static void ebpf_create_swap_charts(int update_every)

1042 ebpf_create_chart(NETDATA_EBPF_MEMORY_GROUP, NETDATA_MEM_SWAP_CHART,

1043 "Calls to access swap memory",

1044 EBPF_COMMON_UNITS_CALLS_PER_SEC, NETDATA_SYSTEM_SWAP_SUBMENU,

1045 - NULL,

1045 + "mem.swapcalls",

1046 NETDATA_EBPF_CHART_TYPE_LINE,

1047 NETDATA_CHART_PRIO_MEM_SWAP_CALLS,

1048 ebpf_create_global_dimension,

src/collectors/ebpf.plugin/ebpf_sync.c

+16 -10

@@ -303,7 +303,7 @@ static void ebpf_obsolete_sync_global(ebpf_module_t *em)

303 EBPF_COMMON_UNITS_CALLS_PER_SEC,

304 NETDATA_EBPF_SYNC_SUBMENU,

305 NETDATA_EBPF_CHART_TYPE_LINE,

306 - NULL,

306 + "mem.file_sync",

307 21300,

308 em->update_every);

309

@@ -315,7 +315,7 @@ static void ebpf_obsolete_sync_global(ebpf_module_t *em)

315 EBPF_COMMON_UNITS_CALLS_PER_SEC,

316 NETDATA_EBPF_SYNC_SUBMENU,

317 NETDATA_EBPF_CHART_TYPE_LINE,

318 - NULL,

318 + "mem.memory_map",

319 21301,

320 em->update_every);

321

@@ -327,7 +327,7 @@ static void ebpf_obsolete_sync_global(ebpf_module_t *em)

327 EBPF_COMMON_UNITS_CALLS_PER_SEC,

328 NETDATA_EBPF_SYNC_SUBMENU,

329 NETDATA_EBPF_CHART_TYPE_LINE,

330 - NULL,

330 + "mem.sync",

331 21302,

332 em->update_every);

333

@@ -339,7 +339,7 @@ static void ebpf_obsolete_sync_global(ebpf_module_t *em)

339 EBPF_COMMON_UNITS_CALLS_PER_SEC,

340 NETDATA_EBPF_SYNC_SUBMENU,

341 NETDATA_EBPF_CHART_TYPE_LINE,

342 - NULL,

342 + "mem.file_segment",

343 21303,

344 em->update_every);

345 }

@@ -607,16 +607,18 @@ static void sync_collector(ebpf_module_t *em)

607 * @param idx the first index with data.

608 * @param end the last index with data.

609 * @param update_every value to overwrite the update frequency set by the server.

610 + * @param context the chart context

611 */

612 static void ebpf_create_sync_chart(char *id,

613 char *title,

614 int order,

615 int idx,

616 int end,

616 - int update_every)

617 + int update_every,

618 + char *context)

619 {

620 ebpf_write_chart_cmd(NETDATA_EBPF_MEMORY_GROUP, id, "", title, EBPF_COMMON_UNITS_CALLS_PER_SEC,

619 - NETDATA_EBPF_SYNC_SUBMENU, NETDATA_EBPF_CHART_TYPE_LINE, NULL, order,

621 + NETDATA_EBPF_SYNC_SUBMENU, NETDATA_EBPF_CHART_TYPE_LINE, context, order,

622 update_every,

623 NETDATA_EBPF_MODULE_NAME_SYNC);

624

@@ -643,22 +645,26 @@ static void ebpf_create_sync_charts(int update_every)

645 if (local_syscalls[NETDATA_SYNC_FSYNC_IDX].enabled && local_syscalls[NETDATA_SYNC_FDATASYNC_IDX].enabled)

646 ebpf_create_sync_chart(NETDATA_EBPF_FILE_SYNC_CHART,

647 "Monitor calls to fsync(2) and fdatasync(2).", 21300,

646 - NETDATA_SYNC_FSYNC_IDX, NETDATA_SYNC_FDATASYNC_IDX, update_every);

648 + NETDATA_SYNC_FSYNC_IDX, NETDATA_SYNC_FDATASYNC_IDX, update_every,

649 + "mem.file_sync");

650

651 if (local_syscalls[NETDATA_SYNC_MSYNC_IDX].enabled)

652 ebpf_create_sync_chart(NETDATA_EBPF_MSYNC_CHART,

653 "Monitor calls to msync(2).", 21301,

651 - NETDATA_SYNC_MSYNC_IDX, NETDATA_SYNC_MSYNC_IDX, update_every);

654 + NETDATA_SYNC_MSYNC_IDX, NETDATA_SYNC_MSYNC_IDX, update_every,

655 + "mem.memory_map");

656

657 if (local_syscalls[NETDATA_SYNC_SYNC_IDX].enabled && local_syscalls[NETDATA_SYNC_SYNCFS_IDX].enabled)

658 ebpf_create_sync_chart(NETDATA_EBPF_SYNC_CHART,

659 "Monitor calls to sync(2) and syncfs(2).", 21302,

656 - NETDATA_SYNC_SYNC_IDX, NETDATA_SYNC_SYNCFS_IDX, update_every);

660 + NETDATA_SYNC_SYNC_IDX, NETDATA_SYNC_SYNCFS_IDX, update_every,

661 + "mem.sync");

662

663 if (local_syscalls[NETDATA_SYNC_SYNC_FILE_RANGE_IDX].enabled)

664 ebpf_create_sync_chart(NETDATA_EBPF_FILE_SEGMENT_CHART,

665 "Monitor calls to sync_file_range(2).", 21303,

661 - NETDATA_SYNC_SYNC_FILE_RANGE_IDX, NETDATA_SYNC_SYNC_FILE_RANGE_IDX, update_every);

666 + NETDATA_SYNC_SYNC_FILE_RANGE_IDX, NETDATA_SYNC_SYNC_FILE_RANGE_IDX, update_every,

667 + "mem.file_segment");

668

669 fflush(stdout);

670 }

src/collectors/ebpf.plugin/metadata.yaml

+1 -1

@@ -1088,7 +1088,7 @@ modules:

1088 dimensions:

1089 - name: fsync

1090 - name: fdatasync

1091 - - name: mem.meory_map

1091 + - name: mem.memory_map

1092 description: Monitor calls to msync(2).

1093 unit: "calls/s"

1094 chart_type: line