@cryptotaxi247 / netdata-1 / commits / 9ea434bf3

Updated messages about checksum validation failures on install. (#10448)

* Updated messages about checksum validation failures on install. They now explain the most common cause of the failures and suggest the most direct way to fix the situation. * Fix checksums. * Clean up messages as suggested by @joelhans.

Austin S. Hemmelgarn committed Jan 5, 2021 at 10:08 UTC 9ea434bf3fb4191e8e88ffe73bc08e69241b13c8
5 files changed +6 -6
packaging/installer/kickstart-static64.sh
+1 -1
@@ -350,7 +350,7 @@ else
350 fi
351
352 if ! grep netdata-latest.gz.run "${TMPDIR}/sha256sum.txt" | safe_sha256sum -c - > /dev/null 2>&1; then
353 - fatal "Static binary checksum validation failed. Stopping netdata installation and leaving binary in ${TMPDIR}"
353 + fatal "Static binary checksum validation failed. Stopping Netdata Agent installation and leaving binary in ${TMPDIR}\nUsually this is a result of an older copy of the file being cached somewhere upstream and can be resolved by retrying in an hour."
354 fi
355
356 # ----------------------------------------------------------------------------
packaging/installer/kickstart.sh
+1 -1
@@ -463,7 +463,7 @@ else
463 fi
464
465 if ! grep netdata-latest.tar.gz "${ndtmpdir}/sha256sum.txt" | safe_sha256sum -c - > /dev/null 2>&1; then
466 - fatal "Tarball checksum validation failed. Stopping netdata installation and leaving tarball in ${ndtmpdir}"
466 + fatal "Tarball checksum validation failed. Stopping Netdata Agent installation and leaving tarball in ${ndtmpdir}.\nUsually this is a result of an older copy of the file being cached somewhere upstream and can be resolved by retrying in an hour."
467 fi
468 run tar -xf netdata-latest.tar.gz
469 rm -rf netdata-latest.tar.gz > /dev/null 2>&1
packaging/installer/methods/kickstart-64.md
+1 -1
@@ -78,7 +78,7 @@ To use `md5sum` to verify the intregity of the `kickstart-static64.sh` script yo
78 command above, run the following:
79
80 ```bash
81 -[ "efddf41d3c19c4988601aecf5b483e3a" = "$(curl -Ss https://my-netdata.io/kickstart-static64.sh | md5sum | cut -d ' ' -f 1)" ] && echo "OK, VALID" || echo "FAILED, INVALID"
81 +[ "047c86a7c8905955bee39b6980a28e30" = "$(curl -Ss https://my-netdata.io/kickstart-static64.sh | md5sum | cut -d ' ' -f 1)" ] && echo "OK, VALID" || echo "FAILED, INVALID"
82 ```
83
84 If the script is valid, this command will return `OK, VALID`.
packaging/installer/methods/kickstart.md
+1 -1
@@ -61,7 +61,7 @@ To use `md5sum` to verify the intregity of the `kickstart.sh` script you will do
61 run the following:
62
63 ```bash
64 -[ "71e0dbb4af6f2cc7e89d358a1a942341" = "$(curl -Ss https://my-netdata.io/kickstart.sh | md5sum | cut -d ' ' -f 1)" ] && echo "OK, VALID" || echo "FAILED, INVALID"
64 +[ "8df7a45b2abb336c84507b7c107bcba3" = "$(curl -Ss https://my-netdata.io/kickstart.sh | md5sum | cut -d ' ' -f 1)" ] && echo "OK, VALID" || echo "FAILED, INVALID"
65 ```
66
67 If the script is valid, this command will return `OK, VALID`.
packaging/installer/netdata-updater.sh
+2 -2
@@ -269,7 +269,7 @@ update() {
269 else
270 download "${NETDATA_TARBALL_URL}" "${ndtmpdir}/netdata-latest.tar.gz"
271 if ! grep netdata-latest.tar.gz sha256sum.txt | safe_sha256sum -c - >&3 2>&3; then
272 - fatal "Tarball checksum validation failed. Stopping netdata upgrade and leaving tarball in ${ndtmpdir}"
272 + fatal "Tarball checksum validation failed. Stopping netdata upgrade and leaving tarball in ${ndtmpdir}\nUsually this is a result of an older copy of the tarball or checksum file being cached somewhere upstream and can be resolved by retrying in an hour."
273 fi
274 NEW_CHECKSUM="$(safe_sha256sum netdata-latest.tar.gz 2> /dev/null | cut -d' ' -f1)"
275 tar -xf netdata-latest.tar.gz >&3 2>&3
@@ -392,7 +392,7 @@ if [ "${IS_NETDATA_STATIC_BINARY}" == "yes" ]; then
392 download "${NETDATA_TARBALL_CHECKSUM_URL}" "${ndtmpdir}/sha256sum.txt"
393 download "${NETDATA_TARBALL_URL}" "${ndtmpdir}/netdata-latest.gz.run"
394 if ! grep netdata-latest.gz.run "${ndtmpdir}/sha256sum.txt" | safe_sha256sum -c - > /dev/null 2>&1; then
395 - fatal "Static binary checksum validation failed. Stopping netdata installation and leaving binary in ${ndtmpdir}"
395 + fatal "Static binary checksum validation failed. Stopping netdata installation and leaving binary in ${ndtmpdir}\nUsually this is a result of an older copy of the file being cached somehere and can be resolved by simply retrying in an hour."
396 fi
397
398 # Do not pass any options other than the accept, for now