@cryptotaxi247 / netdata-1 / commits / aacc95866

Add SQL Express Metrics (#18992)

thiagoftsm committed Nov 14, 2024 at 19:25 UTC aacc9586655499a9e3ca1cea631f55a0a3eba0cd
1 file changed +10 -1
src/collectors/windows.plugin/perflib-mssql.c
+10 -1
@@ -7,6 +7,8 @@
7 #define NETDATA_MAX_INSTANCE_NAME 32
8 #define NETDATA_MAX_INSTANCE_OBJECT 128
9
10 +BOOL is_sqlexpress = FALSE;
11 +
12 enum netdata_mssql_metrics {
13 NETDATA_MSSQL_GENERAL_STATS,
14 NETDATA_MSSQL_SQL_ERRORS,
@@ -146,8 +148,11 @@ static void initialize_mssql_objects(struct mssql_instance *p, const char *insta
148 char prefix[NETDATA_MAX_INSTANCE_NAME];
149 if (!strcmp(instance, "MSSQLSERVER")) {
150 strncpyz(prefix, "SQLServer:", sizeof(prefix) -1);
151 + } else if (!strcmp(instance, "SQLEXPRESS")) {
152 + strncpyz(prefix, "MSSQL$SQLEXPRESS:", sizeof(prefix) -1);
153 } else {
150 - snprintfz(prefix, sizeof(prefix) -1, "MSSQL$:%s:", instance);
154 + char *express = (!is_sqlexpress) ? "" : "SQLEXPRESS" ;
155 + snprintfz(prefix, sizeof(prefix) -1, "MSSQL$%s:%s:", express, instance);
156 }
157
158 size_t length = strlen(prefix);
@@ -287,6 +292,10 @@ static int mssql_fill_dictionary() {
292 if (ret != ERROR_SUCCESS)
293 continue;
294
295 + if (!strcmp(avalue, "SQLEXPRESS")) {
296 + is_sqlexpress = TRUE;
297 + }
298 +
299 struct mssql_instance *p = dictionary_set(mssql_instances, avalue, NULL, sizeof(*p));
300 }
301