@cryptotaxi247 / netdata-1 / commits / ac76c5f21

Remove RRDSET_FLAG_DETAIL. (#18837)

vkalintiris committed Oct 21, 2024 at 15:17 UTC ac76c5f2173173c726cfacbafd95ffa19e740bdc
35 files changed +5 -253
src/collectors/common-contexts/disk-avgsz.h
-2
@@ -28,8 +28,6 @@ static inline void common_disk_avgsz(ND_DISK_AVGSZ *d, const char *id, const cha
28 , RRDSET_TYPE_AREA
29 );
30
31 - rrdset_flag_set(d->st_avgsz, RRDSET_FLAG_DETAIL);
32 -
31 d->rd_avgsz_reads = rrddim_add(d->st_avgsz, "reads", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
32 d->rd_avgsz_writes = rrddim_add(d->st_avgsz, "writes", NULL, -1, 1024, RRD_ALGORITHM_ABSOLUTE);
33
src/collectors/common-contexts/disk-await.h
-2
@@ -28,8 +28,6 @@ static inline void common_disk_await(ND_DISK_AWAIT *d, const char *id, const cha
28 , RRDSET_TYPE_LINE
29 );
30
31 - rrdset_flag_set(d->st_await, RRDSET_FLAG_DETAIL);
32 -
31 d->rd_await_reads = rrddim_add(d->st_await, "reads", NULL, 1, 1000, RRD_ALGORITHM_ABSOLUTE);
32 d->rd_await_writes = rrddim_add(d->st_await, "writes", NULL, -1, 1000, RRD_ALGORITHM_ABSOLUTE);
33
src/collectors/common-contexts/disk-busy.h
-2
@@ -27,8 +27,6 @@ static inline void common_disk_busy(ND_DISK_BUSY *d, const char *id, const char
27 , RRDSET_TYPE_AREA
28 );
29
30 - rrdset_flag_set(d->st_busy, RRDSET_FLAG_DETAIL);
31 -
30 d->rd_busy = rrddim_add(d->st_busy, "busy", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
31
32 if(cb)
src/collectors/common-contexts/disk-iotime.h
-2
@@ -28,8 +28,6 @@ static inline void common_disk_iotime(ND_DISK_IOTIME *d, const char *id, const c
28 , RRDSET_TYPE_AREA
29 );
30
31 - rrdset_flag_set(d->st_iotime, RRDSET_FLAG_DETAIL);
32 -
31 d->rd_reads_ms = rrddim_add(d->st_iotime, "reads", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
32 d->rd_writes_ms = rrddim_add(d->st_iotime, "writes", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
33
src/collectors/common-contexts/disk-svctm.h
-2
@@ -27,8 +27,6 @@ static inline void common_disk_svctm(ND_DISK_SVCTM *d, const char *id, const cha
27 , RRDSET_TYPE_LINE
28 );
29
30 - rrdset_flag_set(d->st_svctm, RRDSET_FLAG_DETAIL);
31 -
30 d->rd_svctm = rrddim_add(d->st_svctm, "svctm", NULL, 1, 1000, RRD_ALGORITHM_ABSOLUTE);
31
32 if(cb)
src/collectors/common-contexts/disk-util.h
-2
@@ -27,8 +27,6 @@ static inline void common_disk_util(ND_DISK_UTIL *d, const char *id, const char
27 , RRDSET_TYPE_AREA
28 );
29
30 - rrdset_flag_set(d->st_util, RRDSET_FLAG_DETAIL);
31 -
30 d->rd_util = rrddim_add(d->st_util, "utilization", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
31
32 if(cb)
src/collectors/common-contexts/mem-pgfaults.h
-2
@@ -25,8 +25,6 @@ static inline void common_mem_pgfaults(uint64_t minor, uint64_t major, int updat
25 , RRDSET_TYPE_LINE
26 );
27
28 - rrdset_flag_set(st_pgfaults, RRDSET_FLAG_DETAIL);
29 -
28 rd_minor = rrddim_add(st_pgfaults, "minor", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
29 rd_major = rrddim_add(st_pgfaults, "major", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
30 }
src/collectors/common-contexts/mem-swap.h
-2
@@ -30,8 +30,6 @@ static inline void common_mem_swap(uint64_t free_bytes, uint64_t used_bytes, int
30 , RRDSET_TYPE_STACKED
31 );
32
33 - rrdset_flag_set(st_system_swap, RRDSET_FLAG_DETAIL);
34 -
33 rd_free = rrddim_add(st_system_swap, "free", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
34 rd_used = rrddim_add(st_system_swap, "used", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
35 }
src/collectors/common-contexts/system-interrupts.h
-2
@@ -27,8 +27,6 @@ static inline void common_interrupts(uint64_t interrupts, int update_every, char
27 , update_every
28 , RRDSET_TYPE_LINE);
29
30 - rrdset_flag_set(st_intr, RRDSET_FLAG_DETAIL);
31 -
30 rd_interrupts = rrddim_add(st_intr, "interrupts", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
31 }
32
src/collectors/freebsd.plugin/freebsd_devstat.c
-14
@@ -393,8 +393,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
393 RRDSET_TYPE_LINE
394 );
395
396 - rrdset_flag_set(dm->st_ops, RRDSET_FLAG_DETAIL);
397 -
396 dm->rd_ops_in = rrddim_add(dm->st_ops, "reads", NULL, 1, 1,
397 RRD_ALGORITHM_INCREMENTAL);
398 dm->rd_ops_out = rrddim_add(dm->st_ops, "writes", NULL, -1, 1,
@@ -428,8 +426,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
426 RRDSET_TYPE_LINE
427 );
428
431 - rrdset_flag_set(dm->st_qops, RRDSET_FLAG_DETAIL);
432 -
429 dm->rd_qops = rrddim_add(dm->st_qops, "operations", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
430 }
431
@@ -453,8 +449,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
449 RRDSET_TYPE_AREA
450 );
451
456 - rrdset_flag_set(dm->st_util, RRDSET_FLAG_DETAIL);
457 -
452 dm->rd_util = rrddim_add(dm->st_util, "utilization", NULL, 1, 10,
453 RRD_ALGORITHM_INCREMENTAL);
454 }
@@ -479,8 +473,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
473 RRDSET_TYPE_LINE
474 );
475
482 - rrdset_flag_set(dm->st_iotime, RRDSET_FLAG_DETAIL);
483 -
476 dm->rd_iotime_in = rrddim_add(dm->st_iotime, "reads", NULL, 1, 1,
477 RRD_ALGORITHM_INCREMENTAL);
478 dm->rd_iotime_out = rrddim_add(dm->st_iotime, "writes", NULL, -1, 1,
@@ -518,8 +510,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
510 RRDSET_TYPE_LINE
511 );
512
521 - rrdset_flag_set(dm->st_await, RRDSET_FLAG_DETAIL);
522 -
513 dm->rd_await_in = rrddim_add(dm->st_await, "reads", NULL, 1, 1,
514 RRD_ALGORITHM_ABSOLUTE);
515 dm->rd_await_out = rrddim_add(dm->st_await, "writes", NULL, -1, 1,
@@ -577,8 +567,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
567 RRDSET_TYPE_AREA
568 );
569
580 - rrdset_flag_set(dm->st_avagsz, RRDSET_FLAG_DETAIL);
581 -
570 dm->rd_avagsz_in = rrddim_add(dm->st_avagsz, "reads", NULL, 1, KILO_FACTOR,
571 RRD_ALGORITHM_ABSOLUTE);
572 dm->rd_avagsz_out = rrddim_add(dm->st_avagsz, "writes", NULL, -1, KILO_FACTOR,
@@ -627,8 +615,6 @@ int do_kern_devstat(int update_every, usec_t dt) {
615 RRDSET_TYPE_LINE
616 );
617
630 - rrdset_flag_set(dm->st_svctm, RRDSET_FLAG_DETAIL);
631 -
618 dm->rd_svctm = rrddim_add(dm->st_svctm, "svctm", NULL, 1, 1,
619 RRD_ALGORITHM_ABSOLUTE);
620 }
src/collectors/freebsd.plugin/freebsd_getifaddrs.c
-10
@@ -297,8 +297,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
297 RRDSET_TYPE_LINE
298 );
299
300 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
301 -
300 rd_packets_in = rrddim_add(st, "received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
301 rd_packets_out = rrddim_add(st, "sent", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
302 rd_packets_m_in = rrddim_add(st, "multicast_received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -464,8 +462,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
462 RRDSET_TYPE_LINE
463 );
464
467 - rrdset_flag_set(ifm->st_packets, RRDSET_FLAG_DETAIL);
468 -
465 ifm->rd_packets_in = rrddim_add(ifm->st_packets, "received", NULL, 1, 1,
466 RRD_ALGORITHM_INCREMENTAL);
467 ifm->rd_packets_out = rrddim_add(ifm->st_packets, "sent", NULL, -1, 1,
@@ -499,8 +495,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
495 RRDSET_TYPE_LINE
496 );
497
502 - rrdset_flag_set(ifm->st_errors, RRDSET_FLAG_DETAIL);
503 -
498 ifm->rd_errors_in = rrddim_add(ifm->st_errors, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
499 ifm->rd_errors_out = rrddim_add(ifm->st_errors, "outbound", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
500 }
@@ -526,8 +520,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
520 RRDSET_TYPE_LINE
521 );
522
529 - rrdset_flag_set(ifm->st_drops, RRDSET_FLAG_DETAIL);
530 -
523 ifm->rd_drops_in = rrddim_add(ifm->st_drops, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
524 #if __FreeBSD__ >= 11
525 ifm->rd_drops_out = rrddim_add(ifm->st_drops, "outbound", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -557,8 +549,6 @@ int do_getifaddrs(int update_every, usec_t dt) {
549 RRDSET_TYPE_LINE
550 );
551
560 - rrdset_flag_set(ifm->st_events, RRDSET_FLAG_DETAIL);
561 -
552 ifm->rd_events_coll = rrddim_add(ifm->st_events, "collisions", NULL, -1, 1,
553 RRD_ALGORITHM_INCREMENTAL);
554 }
src/collectors/freebsd.plugin/freebsd_ipfw.c
-1
@@ -168,7 +168,6 @@ int do_ipfw(int update_every, usec_t dt) {
168 update_every,
169 RRDSET_TYPE_STACKED
170 );
171 - rrdset_flag_set(st_mem, RRDSET_FLAG_DETAIL);
171
172 rd_dyn_mem = rrddim_add(st_mem, "dynamic", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
173 rd_stat_mem = rrddim_add(st_mem, "static", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
src/collectors/freebsd.plugin/freebsd_sysctl.c
-27
@@ -271,7 +271,6 @@ int do_vm_vmtotal(int update_every, usec_t dt) {
271 update_every,
272 RRDSET_TYPE_AREA
273 );
274 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
274
275 rd = rrddim_add(st, "used", NULL, system_pagesize, MEGA_FACTOR, RRD_ALGORITHM_ABSOLUTE);
276 }
@@ -798,8 +797,6 @@ int do_vm_stats_sys_v_forks(int update_every, usec_t dt) {
797 RRDSET_TYPE_LINE
798 );
799
801 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
802 -
800 rd = rrddim_add(st, "started", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
801 }
802
@@ -871,8 +868,6 @@ int do_vm_swap_info(int update_every, usec_t dt) {
868 RRDSET_TYPE_STACKED
869 );
870
874 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
875 -
871 rd_free = rrddim_add(st, "free", NULL, system_pagesize, MEGA_FACTOR, RRD_ALGORITHM_ABSOLUTE);
872 rd_used = rrddim_add(st, "used", NULL, system_pagesize, MEGA_FACTOR, RRD_ALGORITHM_ABSOLUTE);
873 }
@@ -1081,8 +1076,6 @@ int do_vm_stats_sys_v_pgfaults(int update_every, usec_t dt) {
1076 RRDSET_TYPE_LINE
1077 );
1078
1084 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
1085 -
1079 rd_memory = rrddim_add(st, "memory", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1080 rd_io_requiring = rrddim_add(st, "io_requiring", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1081 rd_cow = rrddim_add(st, "cow", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1756,8 +1749,6 @@ int do_net_inet_tcp_stats(int update_every, usec_t dt) {
1749 RRDSET_TYPE_LINE
1750 );
1751
1759 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
1760 -
1752 rd_in_errs = rrddim_add(st, "InErrs", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1753 rd_in_csum_errs = rrddim_add(st, "InCsumErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1754 rd_retrans_segs = rrddim_add(st, "RetransSegs", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1795,8 +1786,6 @@ int do_net_inet_tcp_stats(int update_every, usec_t dt) {
1786 RRDSET_TYPE_LINE
1787 );
1788
1798 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
1799 -
1789 rd_estab_resets = rrddim_add(st, "EstabResets", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1790 rd_active_opens = rrddim_add(st, "ActiveOpens", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1791 rd_passive_opens = rrddim_add(st, "PassiveOpens", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1971,8 +1960,6 @@ int do_net_inet_tcp_stats(int update_every, usec_t dt) {
1960 RRDSET_TYPE_LINE
1961 );
1962
1974 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
1975 -
1963 rd_rcvce = rrddim_add(st, "InCEPkts", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1964 #if __FreeBSD_version < 1400074
1965 rd_ect0 = rrddim_add(st, "ECT0Pkts", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2082,8 +2069,6 @@ int do_net_inet_udp_stats(int update_every, usec_t dt) {
2069 RRDSET_TYPE_LINE
2070 );
2071
2085 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2086 -
2072 rd_in_errors = rrddim_add(st, "InErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2073 rd_no_ports = rrddim_add(st, "NoPorts", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2074 rd_recv_buf_errors = rrddim_add(st, "RcvbufErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2332,8 +2317,6 @@ int do_net_inet_ip_stats(int update_every, usec_t dt) {
2317 RRDSET_TYPE_LINE
2318 );
2319
2335 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2336 -
2320 rd_ok = rrddim_add(st, "FragOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
2321 rd_fails = rrddim_add(st, "FragFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
2322 rd_created = rrddim_add(st, "FragCreates", "created", 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2365,8 +2348,6 @@ int do_net_inet_ip_stats(int update_every, usec_t dt) {
2348 RRDSET_TYPE_LINE
2349 );
2350
2368 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2369 -
2351 rd_ok = rrddim_add(st, "ReasmOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
2352 rd_failed = rrddim_add(st, "ReasmFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
2353 rd_all = rrddim_add(st, "ReasmReqds", "all", 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2400,8 +2381,6 @@ int do_net_inet_ip_stats(int update_every, usec_t dt) {
2381 RRDSET_TYPE_LINE
2382 );
2383
2403 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2404 -
2384 rd_in_discards = rrddim_add(st, "InDiscards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2385 rd_out_discards = rrddim_add(st, "OutDiscards", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
2386 rd_in_hdr_errors = rrddim_add(st, "InHdrErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2519,8 +2498,6 @@ int do_net_inet6_ip6_stats(int update_every, usec_t dt) {
2498 RRDSET_TYPE_LINE
2499 );
2500
2522 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2523 -
2501 rd_ok = rrddim_add(st, "ok", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2502 rd_failed = rrddim_add(st, "failed", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
2503 rd_all = rrddim_add(st, "all", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2554,8 +2531,6 @@ int do_net_inet6_ip6_stats(int update_every, usec_t dt) {
2531 RRDSET_TYPE_LINE
2532 );
2533
2557 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2558 -
2534 rd_ok = rrddim_add(st, "ok", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2535 rd_failed = rrddim_add(st, "failed", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
2536 rd_timeout = rrddim_add(st, "timeout", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2593,8 +2568,6 @@ int do_net_inet6_ip6_stats(int update_every, usec_t dt) {
2568 RRDSET_TYPE_LINE
2569 );
2570
2596 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2597 -
2571 rd_in_discards = rrddim_add(st, "InDiscards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2572 rd_out_discards = rrddim_add(st, "OutDiscards", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
2573 rd_in_hdr_errors = rrddim_add(st, "InHdrErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/macos.plugin/macos_fw.c
-10
@@ -199,7 +199,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
199 , update_every
200 , RRDSET_TYPE_LINE
201 );
202 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
202
203 rrddim_add(st, "reads", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
204 rrddim_add(st, "writes", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -235,7 +234,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
234 , update_every
235 , RRDSET_TYPE_AREA
236 );
238 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
237
238 rrddim_add(st, "utilization", NULL, 1, 10000000, RRD_ALGORITHM_INCREMENTAL);
239 }
@@ -270,7 +268,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
268 , update_every
269 , RRDSET_TYPE_LINE
270 );
273 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
271
272 rrddim_add(st, "reads", NULL, 1, 1000000, RRD_ALGORITHM_INCREMENTAL);
273 rrddim_add(st, "writes", NULL, -1, 1000000, RRD_ALGORITHM_INCREMENTAL);
@@ -302,7 +299,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
299 , update_every
300 , RRDSET_TYPE_LINE
301 );
305 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
302
303 rrddim_add(st, "reads", NULL, 1, 1000000, RRD_ALGORITHM_ABSOLUTE);
304 rrddim_add(st, "writes", NULL, -1, 1000000, RRD_ALGORITHM_ABSOLUTE);
@@ -330,7 +326,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
326 , update_every
327 , RRDSET_TYPE_AREA
328 );
333 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
329
330 rrddim_add(st, "reads", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
331 rrddim_add(st, "writes", NULL, -1, 1024, RRD_ALGORITHM_ABSOLUTE);
@@ -358,7 +353,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
353 , update_every
354 , RRDSET_TYPE_LINE
355 );
361 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
356
357 rrddim_add(st, "svctm", NULL, 1, 1000000, RRD_ALGORITHM_ABSOLUTE);
358 }
@@ -549,7 +543,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
543 , update_every
544 , RRDSET_TYPE_LINE
545 );
552 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
546
547 rrddim_add(st, "received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
548 rrddim_add(st, "sent", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -579,7 +572,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
572 , update_every
573 , RRDSET_TYPE_LINE
574 );
582 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
575
576 rrddim_add(st, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
577 rrddim_add(st, "outbound", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -605,7 +597,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
597 , update_every
598 , RRDSET_TYPE_LINE
599 );
608 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
600
601 rrddim_add(st, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
602 }
@@ -629,7 +620,6 @@ int do_macos_iokit(int update_every, usec_t dt) {
620 , update_every
621 , RRDSET_TYPE_LINE
622 );
632 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
623
624 rrddim_add(st, "frames", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
625 rrddim_add(st, "collisions", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/macos.plugin/macos_mach_smi.c
-1
@@ -192,7 +192,6 @@ int do_macos_mach_smi(int update_every, usec_t dt) {
192 , update_every
193 , RRDSET_TYPE_LINE
194 );
195 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
195
196 rrddim_add(st, "memory", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
197 rrddim_add(st, "cow", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/macos.plugin/macos_sysctl.c
-11
@@ -278,7 +278,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
278 , update_every
279 , RRDSET_TYPE_STACKED
280 );
281 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
281
282 rrddim_add(st, "free", NULL, 1, 1048576, RRD_ALGORITHM_ABSOLUTE);
283 rrddim_add(st, "used", NULL, 1, 1048576, RRD_ALGORITHM_ABSOLUTE);
@@ -411,7 +410,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
410 , update_every
411 , RRDSET_TYPE_LINE
412 );
414 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
413
414 rrddim_add(st, "InErrs", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
415 rrddim_add(st, "InCsumErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -441,7 +439,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
439 , update_every
440 , RRDSET_TYPE_LINE
441 );
444 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
442
443 rrddim_add(st, "EstabResets", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
444 rrddim_add(st, "ActiveOpens", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -564,7 +561,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
561 , update_every
562 , RRDSET_TYPE_LINE
563 );
567 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
564
565 rrddim_add(st, "InCEPkts", "CEP", 1, 1, RRD_ALGORITHM_INCREMENTAL);
566 rrddim_add(st, "InNoECTPkts", "NoECTP", -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -631,7 +627,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
627 , update_every
628 , RRDSET_TYPE_LINE
629 );
634 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
630
631 rrddim_add(st, "RcvbufErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
632 rrddim_add(st, "InErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -819,7 +814,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
814 , update_every
815 , RRDSET_TYPE_LINE
816 );
822 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
817
818 rrddim_add(st, "FragOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
819 rrddim_add(st, "FragFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -849,7 +843,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
843 , update_every
844 , RRDSET_TYPE_LINE
845 );
852 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
846
847 rrddim_add(st, "ReasmOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
848 rrddim_add(st, "ReasmFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -879,7 +872,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
872 , update_every
873 , RRDSET_TYPE_LINE
874 );
882 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
875
876 rrddim_add(st, "InDiscards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
877 rrddim_add(st, "OutDiscards", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -963,7 +955,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
955 , update_every
956 , RRDSET_TYPE_LINE
957 );
966 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
958
959 rrddim_add(st, "ok", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
960 rrddim_add(st, "failed", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -994,7 +985,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
985 , update_every
986 , RRDSET_TYPE_LINE
987 );
997 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
988
989 rrddim_add(st, "ok", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
990 rrddim_add(st, "failed", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1027,7 +1017,6 @@ int do_macos_sysctl(int update_every, usec_t dt) {
1017 , update_every
1018 , RRDSET_TYPE_LINE
1019 );
1030 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
1020
1021 rrddim_add(st, "InDiscards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1022 rrddim_add(st, "OutDiscards", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/proc.plugin/proc_diskstats.c
-18
@@ -1624,8 +1624,6 @@ int do_proc_diskstats(int update_every, usec_t dt) {
1624 , RRDSET_TYPE_LINE
1625 );
1626
1627 - rrdset_flag_set(d->st_ext_ops, RRDSET_FLAG_DETAIL);
1628 -
1627 d->rd_ops_discards = rrddim_add(d->st_ext_ops, "discards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1628 if (do_fl_stats)
1629 d->rd_ops_flushes = rrddim_add(d->st_ext_ops, "flushes", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1671,8 +1669,6 @@ int do_proc_diskstats(int update_every, usec_t dt) {
1669 , RRDSET_TYPE_AREA
1670 );
1671
1674 - rrdset_flag_set(d->st_backlog, RRDSET_FLAG_DETAIL);
1675 -
1672 d->rd_backlog_backlog = rrddim_add(d->st_backlog, "backlog", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1673
1674 add_labels_to_disk(d, d->st_backlog);
@@ -1728,8 +1724,6 @@ int do_proc_diskstats(int update_every, usec_t dt) {
1724 , RRDSET_TYPE_LINE
1725 );
1726
1731 - rrdset_flag_set(d->st_mops, RRDSET_FLAG_DETAIL);
1732 -
1727 d->rd_mops_reads = rrddim_add(d->st_mops, "reads", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1728 d->rd_mops_writes = rrddim_add(d->st_mops, "writes", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
1729
@@ -1760,8 +1754,6 @@ int do_proc_diskstats(int update_every, usec_t dt) {
1754 , RRDSET_TYPE_LINE
1755 );
1756
1763 - rrdset_flag_set(d->st_ext_mops, RRDSET_FLAG_DETAIL);
1764 -
1757 d->rd_mops_discards = rrddim_add(d->st_ext_mops, "discards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1758
1759 add_labels_to_disk(d, d->st_ext_mops);
@@ -1805,8 +1797,6 @@ int do_proc_diskstats(int update_every, usec_t dt) {
1797 , RRDSET_TYPE_LINE
1798 );
1799
1808 - rrdset_flag_set(d->st_ext_iotime, RRDSET_FLAG_DETAIL);
1809 -
1800 d->rd_iotime_discards = rrddim_add(d->st_ext_iotime, "discards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1801 if (do_fl_stats)
1802 d->rd_iotime_flushes = rrddim_add(d->st_ext_iotime, "flushes", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1858,8 +1848,6 @@ int do_proc_diskstats(int update_every, usec_t dt) {
1848 , RRDSET_TYPE_LINE
1849 );
1850
1861 - rrdset_flag_set(d->st_ext_await, RRDSET_FLAG_DETAIL);
1862 -
1851 d->rd_await_discards = rrddim_add(d->st_ext_await, "discards", NULL, 1, 1000, RRD_ALGORITHM_ABSOLUTE);
1852 if (do_fl_stats)
1853 d->rd_await_flushes = rrddim_add(d->st_ext_await, "flushes", NULL, 1, 1000, RRD_ALGORITHM_ABSOLUTE);
@@ -1914,8 +1902,6 @@ int do_proc_diskstats(int update_every, usec_t dt) {
1902 , RRDSET_TYPE_AREA
1903 );
1904
1917 - rrdset_flag_set(d->st_ext_avgsz, RRDSET_FLAG_DETAIL);
1918 -
1905 d->rd_avgsz_discards = rrddim_add(d->st_ext_avgsz, "discards", NULL, SECTOR_SIZE, 1024, RRD_ALGORITHM_ABSOLUTE);
1906
1907 add_labels_to_disk(d, d->st_ext_avgsz);
@@ -2182,8 +2168,6 @@ int do_proc_diskstats(int update_every, usec_t dt) {
2168 , RRDSET_TYPE_LINE
2169 );
2170
2185 - rrdset_flag_set(d->st_bcache, RRDSET_FLAG_DETAIL);
2186 -
2171 d->rd_bcache_hits = rrddim_add(d->st_bcache, "hits", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2172 d->rd_bcache_misses = rrddim_add(d->st_bcache, "misses", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
2173 d->rd_bcache_miss_collisions = rrddim_add(d->st_bcache, "collisions", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2216,8 +2200,6 @@ int do_proc_diskstats(int update_every, usec_t dt) {
2200 , RRDSET_TYPE_LINE
2201 );
2202
2219 - rrdset_flag_set(d->st_bcache_bypass, RRDSET_FLAG_DETAIL);
2220 -
2203 d->rd_bcache_bypass_hits = rrddim_add(d->st_bcache_bypass, "hits", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2204 d->rd_bcache_bypass_misses = rrddim_add(d->st_bcache_bypass, "misses", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
2205
src/collectors/proc.plugin/proc_meminfo.c
-19
@@ -347,8 +347,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
347 , RRDSET_TYPE_LINE
348 );
349
350 - rrdset_flag_set(st_mem_hwcorrupt, RRDSET_FLAG_DETAIL);
351 -
350 rd_corrupted = rrddim_add(st_mem_hwcorrupt, "HardwareCorrupted", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
351 }
352
@@ -376,8 +374,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
374 , RRDSET_TYPE_AREA
375 );
376
379 - rrdset_flag_set(st_mem_committed, RRDSET_FLAG_DETAIL);
380 -
377 rd_committed = rrddim_add(st_mem_committed, "Committed_AS", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
378 }
379
@@ -404,7 +400,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
400 , update_every
401 , RRDSET_TYPE_LINE
402 );
407 - rrdset_flag_set(st_mem_writeback, RRDSET_FLAG_DETAIL);
403
404 rd_dirty = rrddim_add(st_mem_writeback, "Dirty", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
405 rd_writeback = rrddim_add(st_mem_writeback, "Writeback", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
@@ -444,8 +439,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
439 , RRDSET_TYPE_STACKED
440 );
441
447 - rrdset_flag_set(st_mem_kernel, RRDSET_FLAG_DETAIL);
448 -
442 rd_slab = rrddim_add(st_mem_kernel, "Slab", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
443 rd_kernelstack = rrddim_add(st_mem_kernel, "KernelStack", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
444 rd_pagetables = rrddim_add(st_mem_kernel, "PageTables", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
@@ -484,8 +477,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
477 , RRDSET_TYPE_STACKED
478 );
479
487 - rrdset_flag_set(st_mem_slab, RRDSET_FLAG_DETAIL);
488 -
480 rd_reclaimable = rrddim_add(st_mem_slab, "reclaimable", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
481 rd_unreclaimable = rrddim_add(st_mem_slab, "unreclaimable", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
482 }
@@ -518,8 +509,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
509 , RRDSET_TYPE_STACKED
510 );
511
521 - rrdset_flag_set(st_mem_hugepages, RRDSET_FLAG_DETAIL);
522 -
512 rd_free = rrddim_add(st_mem_hugepages, "free", NULL, Hugepagesize, 1024, RRD_ALGORITHM_ABSOLUTE);
513 rd_used = rrddim_add(st_mem_hugepages, "used", NULL, Hugepagesize, 1024, RRD_ALGORITHM_ABSOLUTE);
514 rd_surp = rrddim_add(st_mem_hugepages, "surplus", NULL, Hugepagesize, 1024, RRD_ALGORITHM_ABSOLUTE);
@@ -555,8 +544,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
544 , RRDSET_TYPE_STACKED
545 );
546
558 - rrdset_flag_set(st_mem_transparent_hugepages, RRDSET_FLAG_DETAIL);
559 -
547 rd_anonymous = rrddim_add(st_mem_transparent_hugepages, "anonymous", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
548 rd_shared = rrddim_add(st_mem_transparent_hugepages, "shmem", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
549 }
@@ -585,8 +572,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
572 , RRDSET_TYPE_LINE
573 );
574
588 - rrdset_flag_set(st_mem_thp_details, RRDSET_FLAG_DETAIL);
589 -
575 rd_shmem_pmd_mapped = rrddim_add(st_mem_thp_details, "shmem_pmd", "ShmemPmdMapped", 1, 1024, RRD_ALGORITHM_ABSOLUTE);
576 rd_file_huge_pages = rrddim_add(st_mem_thp_details, "file", "FileHugePages", 1, 1024, RRD_ALGORITHM_ABSOLUTE);
577 rd_file_pmd_mapped = rrddim_add(st_mem_thp_details, "file_pmd", "FilePmdMapped", 1, 1024, RRD_ALGORITHM_ABSOLUTE);
@@ -622,8 +607,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
607 , RRDSET_TYPE_LINE
608 );
609
625 - rrdset_flag_set(st_mem_reclaiming, RRDSET_FLAG_DETAIL);
626 -
610 rd_active = rrddim_add(st_mem_reclaiming, "active", "Active", 1, 1024, RRD_ALGORITHM_ABSOLUTE);
611 rd_inactive = rrddim_add(st_mem_reclaiming, "inactive", "Inactive", 1, 1024, RRD_ALGORITHM_ABSOLUTE);
612 rd_active_anon = rrddim_add(st_mem_reclaiming, "active_anon", "Active(anon)", 1, 1024, RRD_ALGORITHM_ABSOLUTE);
@@ -667,8 +650,6 @@ int do_proc_meminfo(int update_every, usec_t dt) {
650 , RRDSET_TYPE_STACKED
651 );
652
670 - rrdset_flag_set(st_mem_high_low, RRDSET_FLAG_DETAIL);
671 -
653 rd_high_used = rrddim_add(st_mem_high_low, "high_used", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
654 rd_low_used = rrddim_add(st_mem_high_low, "low_used", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
655 rd_high_free = rrddim_add(st_mem_high_low, "high_free", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE);
src/collectors/proc.plugin/proc_net_dev.c
-22
@@ -1281,8 +1281,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1281 , RRDSET_TYPE_LINE
1282 );
1283
1284 - rrdset_flag_set(d->st_speed, RRDSET_FLAG_DETAIL);
1285 -
1284 rrdset_update_rrdlabels(d->st_speed, d->chart_labels);
1285
1286 d->rd_speed = rrddim_add(d->st_speed, "speed", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
@@ -1321,8 +1319,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1319 , RRDSET_TYPE_LINE
1320 );
1321
1324 - rrdset_flag_set(d->st_duplex, RRDSET_FLAG_DETAIL);
1325 -
1322 rrdset_update_rrdlabels(d->st_duplex, d->chart_labels);
1323
1324 d->rd_duplex_full = rrddim_add(d->st_duplex, "full", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
@@ -1353,8 +1349,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1349 , RRDSET_TYPE_LINE
1350 );
1351
1356 - rrdset_flag_set(d->st_operstate, RRDSET_FLAG_DETAIL);
1357 -
1352 rrdset_update_rrdlabels(d->st_operstate, d->chart_labels);
1353
1354 d->rd_operstate_up = rrddim_add(d->st_operstate, "up", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
@@ -1393,8 +1387,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1387 , RRDSET_TYPE_LINE
1388 );
1389
1396 - rrdset_flag_set(d->st_carrier, RRDSET_FLAG_DETAIL);
1397 -
1390 rrdset_update_rrdlabels(d->st_carrier, d->chart_labels);
1391
1392 d->rd_carrier_up = rrddim_add(d->st_carrier, "up", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
@@ -1423,8 +1415,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1415 , RRDSET_TYPE_LINE
1416 );
1417
1426 - rrdset_flag_set(d->st_mtu, RRDSET_FLAG_DETAIL);
1427 -
1418 rrdset_update_rrdlabels(d->st_mtu, d->chart_labels);
1419
1420 d->rd_mtu = rrddim_add(d->st_mtu, "mtu", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
@@ -1452,8 +1442,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1442 , RRDSET_TYPE_LINE
1443 );
1444
1455 - rrdset_flag_set(d->st_packets, RRDSET_FLAG_DETAIL);
1456 -
1445 rrdset_update_rrdlabels(d->st_packets, d->chart_labels);
1446
1447 d->rd_rpackets = rrddim_add(d->st_packets, "received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1493,8 +1481,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1481 , RRDSET_TYPE_LINE
1482 );
1483
1496 - rrdset_flag_set(d->st_errors, RRDSET_FLAG_DETAIL);
1497 -
1484 rrdset_update_rrdlabels(d->st_errors, d->chart_labels);
1485
1486 d->rd_rerrors = rrddim_add(d->st_errors, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1532,8 +1518,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1518 , RRDSET_TYPE_LINE
1519 );
1520
1535 - rrdset_flag_set(d->st_drops, RRDSET_FLAG_DETAIL);
1536 -
1521 rrdset_update_rrdlabels(d->st_drops, d->chart_labels);
1522
1523 d->rd_rdrops = rrddim_add(d->st_drops, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1571,8 +1555,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1555 , RRDSET_TYPE_LINE
1556 );
1557
1574 - rrdset_flag_set(d->st_fifo, RRDSET_FLAG_DETAIL);
1575 -
1558 rrdset_update_rrdlabels(d->st_fifo, d->chart_labels);
1559
1560 d->rd_rfifo = rrddim_add(d->st_fifo, "receive", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1610,8 +1592,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1592 , RRDSET_TYPE_LINE
1593 );
1594
1613 - rrdset_flag_set(d->st_compressed, RRDSET_FLAG_DETAIL);
1614 -
1595 rrdset_update_rrdlabels(d->st_compressed, d->chart_labels);
1596
1597 d->rd_rcompressed = rrddim_add(d->st_compressed, "received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1649,8 +1629,6 @@ int do_proc_net_dev(int update_every, usec_t dt) {
1629 , RRDSET_TYPE_LINE
1630 );
1631
1652 - rrdset_flag_set(d->st_events, RRDSET_FLAG_DETAIL);
1653 -
1632 rrdset_update_rrdlabels(d->st_events, d->chart_labels);
1633
1634 d->rd_rframe = rrddim_add(d->st_events, "frames", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/proc.plugin/proc_net_netstat.c
-25
@@ -465,7 +465,6 @@ static void do_proc_net_snmp6(int update_every) {
465 , update_every
466 , RRDSET_TYPE_LINE
467 );
468 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
468
469 rd_ok = rrddim_add(st, "FragOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
470 rd_failed = rrddim_add(st, "FragFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -501,7 +500,6 @@ static void do_proc_net_snmp6(int update_every) {
500 , NETDATA_CHART_PRIO_IPV6_FRAGSIN
501 , update_every
502 , RRDSET_TYPE_LINE);
504 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
503
504 rd_ok = rrddim_add(st, "ReasmOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
505 rd_failed = rrddim_add(st, "ReasmFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -544,7 +542,6 @@ static void do_proc_net_snmp6(int update_every) {
542 , update_every
543 , RRDSET_TYPE_LINE
544 );
547 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
545
546 rd_InDiscards = rrddim_add(st, "InDiscards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
547 rd_OutDiscards = rrddim_add(st, "OutDiscards", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -624,7 +621,6 @@ static void do_proc_net_snmp6(int update_every) {
621 , update_every
622 , RRDSET_TYPE_LINE
623 );
627 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
624
625 rd_RcvbufErrors = rrddim_add(st, "RcvbufErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
626 rd_SndbufErrors = rrddim_add(st, "SndbufErrors", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -697,7 +693,6 @@ static void do_proc_net_snmp6(int update_every) {
693 , update_every
694 , RRDSET_TYPE_LINE
695 );
700 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
696
697 rd_RcvbufErrors = rrddim_add(st, "RcvbufErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
698 rd_SndbufErrors = rrddim_add(st, "SndbufErrors", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -735,7 +730,6 @@ static void do_proc_net_snmp6(int update_every) {
730 , update_every
731 , RRDSET_TYPE_AREA
732 );
738 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
733
734 rd_Ip6InMcastOctets = rrddim_add(st, "received", NULL, 8, BITS_IN_A_KILOBIT, RRD_ALGORITHM_INCREMENTAL);
735 rd_Ip6OutMcastOctets = rrddim_add(st, "sent", NULL, -8, BITS_IN_A_KILOBIT, RRD_ALGORITHM_INCREMENTAL);
@@ -767,7 +761,6 @@ static void do_proc_net_snmp6(int update_every) {
761 , update_every
762 , RRDSET_TYPE_AREA
763 );
770 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
764
765 rd_Ip6InBcastOctets = rrddim_add(st, "received", NULL, 8, BITS_IN_A_KILOBIT, RRD_ALGORITHM_INCREMENTAL);
766 rd_Ip6OutBcastOctets = rrddim_add(st, "sent", NULL, -8, BITS_IN_A_KILOBIT, RRD_ALGORITHM_INCREMENTAL);
@@ -799,7 +792,6 @@ static void do_proc_net_snmp6(int update_every) {
792 , update_every
793 , RRDSET_TYPE_LINE
794 );
802 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
795
796 rd_Ip6InMcastPkts = rrddim_add(st, "received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
797 rd_Ip6OutMcastPkts = rrddim_add(st, "sent", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -1781,8 +1773,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
1773 , RRDSET_TYPE_AREA
1774 );
1775
1784 - rrdset_flag_set(st_ip_mcast, RRDSET_FLAG_DETAIL);
1785 -
1776 rd_in = rrddim_add(st_ip_mcast, "received", NULL, 8, BITS_IN_A_KILOBIT, RRD_ALGORITHM_INCREMENTAL);
1777 rd_out = rrddim_add(st_ip_mcast, "sent", NULL, -8, BITS_IN_A_KILOBIT, RRD_ALGORITHM_INCREMENTAL);
1778 }
@@ -1817,8 +1807,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
1807 , RRDSET_TYPE_AREA
1808 );
1809
1820 - rrdset_flag_set(st_ip_bcast, RRDSET_FLAG_DETAIL);
1821 -
1810 rd_in = rrddim_add(st_ip_bcast, "received", NULL, 8, BITS_IN_A_KILOBIT, RRD_ALGORITHM_INCREMENTAL);
1811 rd_out = rrddim_add(st_ip_bcast, "sent", NULL, -8, BITS_IN_A_KILOBIT, RRD_ALGORITHM_INCREMENTAL);
1812 }
@@ -1853,8 +1841,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
1841 , RRDSET_TYPE_LINE
1842 );
1843
1856 - rrdset_flag_set(st_ip_mcastpkts, RRDSET_FLAG_DETAIL);
1857 -
1844 rd_in = rrddim_add(st_ip_mcastpkts, "received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1845 rd_out = rrddim_add(st_ip_mcastpkts, "sent", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
1846 }
@@ -1886,8 +1872,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
1872 , RRDSET_TYPE_LINE
1873 );
1874
1889 - rrdset_flag_set(st_ip_bcastpkts, RRDSET_FLAG_DETAIL);
1890 -
1875 rd_in = rrddim_add(st_ip_bcastpkts, "received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1876 rd_out = rrddim_add(st_ip_bcastpkts, "sent", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
1877 }
@@ -1919,8 +1903,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
1903 , RRDSET_TYPE_LINE
1904 );
1905
1922 - rrdset_flag_set(st_ecnpkts, RRDSET_FLAG_DETAIL);
1923 -
1906 rd_cep = rrddim_add(st_ecnpkts, "InCEPkts", "CEP", 1, 1, RRD_ALGORITHM_INCREMENTAL);
1907 rd_noectp = rrddim_add(st_ecnpkts, "InNoECTPkts", "NoECTP", -1, 1, RRD_ALGORITHM_INCREMENTAL);
1908 rd_ectp0 = rrddim_add(st_ecnpkts, "InECT0Pkts", "ECTP0", 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2241,7 +2223,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
2223 , update_every
2224 , RRDSET_TYPE_LINE
2225 );
2244 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2226
2227 rd_FragOKs = rrddim_add(st, "FragOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
2228 rd_FragFails = rrddim_add(st, "FragFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2277,7 +2258,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
2258 , update_every
2259 , RRDSET_TYPE_LINE
2260 );
2280 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2261
2262 rd_ReasmOKs = rrddim_add(st, "ReasmOKs", "ok", 1, 1, RRD_ALGORITHM_INCREMENTAL);
2263 rd_ReasmFails = rrddim_add(st, "ReasmFails", "failed", -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2319,7 +2299,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
2299 , update_every
2300 , RRDSET_TYPE_LINE
2301 );
2322 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2302
2303 rd_InDiscards = rrddim_add(st, "InDiscards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2304 rd_OutDiscards = rrddim_add(st, "OutDiscards", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2596,7 +2575,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
2575 , update_every
2576 , RRDSET_TYPE_LINE
2577 );
2599 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2578
2579 rd_InErrs = rrddim_add(st, "InErrs", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2580 rd_InCsumErrors = rrddim_add(st, "InCsumErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2631,7 +2609,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
2609 , update_every
2610 , RRDSET_TYPE_LINE
2611 );
2634 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2612
2613 rd_ActiveOpens = rrddim_add(st, "ActiveOpens", "active", 1, 1, RRD_ALGORITHM_INCREMENTAL);
2614 rd_PassiveOpens = rrddim_add(st, "PassiveOpens", "passive", 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2666,7 +2643,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
2643 , update_every
2644 , RRDSET_TYPE_LINE
2645 );
2669 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2646
2647 rd_EstabResets = rrddim_add(st, "EstabResets", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2648 rd_OutRsts = rrddim_add(st, "OutRsts", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -2744,7 +2720,6 @@ int do_proc_net_netstat(int update_every, usec_t dt) {
2720 , update_every
2721 , RRDSET_TYPE_LINE
2722 );
2747 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
2723
2724 rd_RcvbufErrors = rrddim_add(st, "RcvbufErrors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2725 rd_SndbufErrors = rrddim_add(st, "SndbufErrors", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/proc.plugin/proc_net_rpc_nfs.c
-3
@@ -296,8 +296,6 @@ int do_proc_net_rpc_nfs(int update_every, usec_t dt) {
296 , RRDSET_TYPE_STACKED
297 );
298
299 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
300 -
299 rd_udp = rrddim_add(st, "udp", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
300 rd_tcp = rrddim_add(st, "tcp", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
301 }
@@ -332,7 +330,6 @@ int do_proc_net_rpc_nfs(int update_every, usec_t dt) {
330 , update_every
331 , RRDSET_TYPE_LINE
332 );
335 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
333
334 rd_calls = rrddim_add(st, "calls", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
335 rd_retransmits = rrddim_add(st, "retransmits", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/proc.plugin/proc_net_rpc_nfsd.c
-3
@@ -501,7 +501,6 @@ int do_proc_net_rpc_nfsd(int update_every, usec_t dt) {
501 , update_every
502 , RRDSET_TYPE_LINE
503 );
504 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
504
505 rd_stale = rrddim_add(st, "stale", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
506 }
@@ -587,7 +586,6 @@ int do_proc_net_rpc_nfsd(int update_every, usec_t dt) {
586 , update_every
587 , RRDSET_TYPE_STACKED
588 );
590 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
589
590 rd_udp = rrddim_add(st, "udp", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
591 rd_tcp = rrddim_add(st, "tcp", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -623,7 +621,6 @@ int do_proc_net_rpc_nfsd(int update_every, usec_t dt) {
621 , update_every
622 , RRDSET_TYPE_LINE
623 );
626 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
624
625 rd_calls = rrddim_add(st, "calls", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
626 rd_bad_format = rrddim_add(st, "bad_format", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/proc.plugin/proc_net_sctp_snmp.c
-4
@@ -214,7 +214,6 @@ int do_proc_net_sctp_snmp(int update_every, usec_t dt) {
214 , update_every
215 , RRDSET_TYPE_LINE
216 );
217 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
217
218 rd_received = rrddim_add(st, "SctpInSCTPPacks", "received", 1, 1, RRD_ALGORITHM_INCREMENTAL);
219 rd_sent = rrddim_add(st, "SctpOutSCTPPacks", "sent", -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -248,7 +247,6 @@ int do_proc_net_sctp_snmp(int update_every, usec_t dt) {
247 , update_every
248 , RRDSET_TYPE_LINE
249 );
251 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
250
251 rd_invalid = rrddim_add(st, "SctpOutOfBlues", "invalid", 1, 1, RRD_ALGORITHM_INCREMENTAL);
252 rd_csum = rrddim_add(st, "SctpChecksumErrors", "checksum", 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -282,7 +280,6 @@ int do_proc_net_sctp_snmp(int update_every, usec_t dt) {
280 , NETDATA_CHART_PRIO_SCTP + 40
281 , update_every
282 , RRDSET_TYPE_LINE);
285 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
283
284 rd_reassembled = rrddim_add(st, "SctpReasmUsrMsgs", "reassembled", 1, 1, RRD_ALGORITHM_INCREMENTAL);
285 rd_fragmented = rrddim_add(st, "SctpFragUsrMsgs", "fragmented", -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -321,7 +318,6 @@ int do_proc_net_sctp_snmp(int update_every, usec_t dt) {
318 , update_every
319 , RRDSET_TYPE_LINE
320 );
324 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
321
322 rd_InCtrl = rrddim_add(st, "SctpInCtrlChunks", "InCtrl", 1, 1, RRD_ALGORITHM_INCREMENTAL);
323 rd_InOrder = rrddim_add(st, "SctpInOrderChunks", "InOrder", 1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/proc.plugin/proc_net_stat_conntrack.c
-4
@@ -217,7 +217,6 @@ int do_proc_net_stat_conntrack(int update_every, usec_t dt) {
217 , update_every
218 , RRDSET_TYPE_LINE
219 );
220 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
220
221 rd_inserted = rrddim_add(st, "inserted", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
222 rd_deleted = rrddim_add(st, "deleted", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -253,7 +252,6 @@ int do_proc_net_stat_conntrack(int update_every, usec_t dt) {
252 , update_every
253 , RRDSET_TYPE_LINE
254 );
256 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
255
256 rd_created = rrddim_add(st, "created", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
257 rd_deleted = rrddim_add(st, "deleted", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -289,7 +287,6 @@ int do_proc_net_stat_conntrack(int update_every, usec_t dt) {
287 , update_every
288 , RRDSET_TYPE_LINE
289 );
292 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
290
291 rd_searched = rrddim_add(st, "searched", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
292 rd_restarted = rrddim_add(st, "restarted", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -326,7 +323,6 @@ int do_proc_net_stat_conntrack(int update_every, usec_t dt) {
323 , update_every
324 , RRDSET_TYPE_LINE
325 );
329 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
326
327 rd_icmp_error = rrddim_add(st, "icmp_error", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
328 rd_insert_failed = rrddim_add(st, "insert_failed", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/proc.plugin/proc_net_wireless.c
-9
@@ -264,8 +264,6 @@ int do_proc_net_wireless(int update_every, usec_t dt)
264 update_every,
265 RRDSET_TYPE_LINE);
266
267 - rrdset_flag_set(wireless_dev->st_status, RRDSET_FLAG_DETAIL);
268 -
267 wireless_dev->rd_status = rrddim_add(wireless_dev->st_status, "status", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
268
269 add_labels_to_wireless(wireless_dev, wireless_dev->st_status);
@@ -295,7 +293,6 @@ int do_proc_net_wireless(int update_every, usec_t dt)
293 NETDATA_CHART_PRIO_WIRELESS_IFACE + 1,
294 update_every,
295 RRDSET_TYPE_LINE);
298 - rrdset_flag_set(wireless_dev->st_link, RRDSET_FLAG_DETAIL);
296
297 wireless_dev->rd_link = rrddim_add(wireless_dev->st_link, "link_quality", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
298
@@ -316,7 +313,6 @@ int do_proc_net_wireless(int update_every, usec_t dt)
313 NETDATA_CHART_PRIO_WIRELESS_IFACE + 2,
314 update_every,
315 RRDSET_TYPE_LINE);
319 - rrdset_flag_set(wireless_dev->st_level, RRDSET_FLAG_DETAIL);
316
317 wireless_dev->rd_level = rrddim_add(wireless_dev->st_level, "signal_level", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
318
@@ -337,7 +333,6 @@ int do_proc_net_wireless(int update_every, usec_t dt)
333 NETDATA_CHART_PRIO_WIRELESS_IFACE + 3,
334 update_every,
335 RRDSET_TYPE_LINE);
340 - rrdset_flag_set(wireless_dev->st_noise, RRDSET_FLAG_DETAIL);
336
337 wireless_dev->rd_noise = rrddim_add(wireless_dev->st_noise, "noise_level", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
338
@@ -376,8 +371,6 @@ int do_proc_net_wireless(int update_every, usec_t dt)
371 update_every,
372 RRDSET_TYPE_LINE);
373
379 - rrdset_flag_set(wireless_dev->st_discarded_packets, RRDSET_FLAG_DETAIL);
380 -
374 wireless_dev->rd_nwid = rrddim_add(wireless_dev->st_discarded_packets, "nwid", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
375 wireless_dev->rd_crypt = rrddim_add(wireless_dev->st_discarded_packets, "crypt", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
376 wireless_dev->rd_frag = rrddim_add(wireless_dev->st_discarded_packets, "frag", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -414,8 +407,6 @@ int do_proc_net_wireless(int update_every, usec_t dt)
407 update_every,
408 RRDSET_TYPE_LINE);
409
417 - rrdset_flag_set(wireless_dev->st_missed_beacon, RRDSET_FLAG_DETAIL);
418 -
410 wireless_dev->rd_missed_beacon = rrddim_add(wireless_dev->st_missed_beacon, "missed_beacons", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
411
412 add_labels_to_wireless(wireless_dev, wireless_dev->st_missed_beacon);
src/collectors/proc.plugin/proc_stat.c
-1
@@ -794,7 +794,6 @@ int do_proc_stat(int update_every, usec_t dt) {
794 , update_every
795 , RRDSET_TYPE_LINE
796 );
797 - rrdset_flag_set(st_forks, RRDSET_FLAG_DETAIL);
797
798 rd_started = rrddim_add(st_forks, "started", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
799 }
src/collectors/proc.plugin/proc_vmstat.c
-4
@@ -355,8 +355,6 @@ int do_proc_vmstat(int update_every, usec_t dt) {
355 , RRDSET_TYPE_LINE
356 );
357
358 - rrdset_flag_set(st_oom_kill, RRDSET_FLAG_DETAIL);
359 -
358 rd_oom_kill = rrddim_add(st_oom_kill, "kills", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
359 }
360
@@ -397,8 +395,6 @@ int do_proc_vmstat(int update_every, usec_t dt) {
395 , RRDSET_TYPE_LINE
396 );
397
400 - rrdset_flag_set(st_numa, RRDSET_FLAG_DETAIL);
401 -
398 // These depend on CONFIG_NUMA in the kernel.
399 rd_local = rrddim_add(st_numa, "local", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
400 rd_foreign = rrddim_add(st_numa, "foreign", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
src/collectors/proc.plugin/sys_class_infiniband.c
+3 -10
@@ -538,8 +538,7 @@ int do_sys_class_infiniband(int update_every, usec_t dt)
538 port->priority + 1,
539 update_every,
540 RRDSET_TYPE_AREA);
541 - // Create Dimensions
542 - rrdset_flag_set(port->st_bytes, RRDSET_FLAG_DETAIL);
541 +
542 // On this chart, we want to have a KB/s so the dashboard will autoscale it
543 // The reported values are also per-lane, so we must multiply it by the width
544 // x4 lanes multiplier as per Documentation/ABI/stable/sysfs-class-infiniband
@@ -576,8 +575,7 @@ int do_sys_class_infiniband(int update_every, usec_t dt)
575 port->priority + 2,
576 update_every,
577 RRDSET_TYPE_AREA);
579 - // Create Dimensions
580 - rrdset_flag_set(port->st_packets, RRDSET_FLAG_DETAIL);
578 +
579 FOREACH_COUNTER_PACKETS(GEN_RRD_DIM_ADD, port)
580 }
581
@@ -605,8 +603,7 @@ int do_sys_class_infiniband(int update_every, usec_t dt)
603 port->priority + 3,
604 update_every,
605 RRDSET_TYPE_LINE);
608 - // Create Dimensions
609 - rrdset_flag_set(port->st_errors, RRDSET_FLAG_DETAIL);
606 +
607 FOREACH_COUNTER_ERRORS(GEN_RRD_DIM_ADD, port)
608 }
609
@@ -641,8 +638,6 @@ int do_sys_class_infiniband(int update_every, usec_t dt)
638 update_every,
639 RRDSET_TYPE_LINE);
640
644 - rrdset_flag_set(port->st_hwerrors, RRDSET_FLAG_DETAIL);
645 -
641 // VENDORS: Set your selection
642
643 // VENDOR: Mellanox
@@ -677,8 +672,6 @@ int do_sys_class_infiniband(int update_every, usec_t dt)
672 update_every,
673 RRDSET_TYPE_LINE);
674
680 - rrdset_flag_set(port->st_hwpackets, RRDSET_FLAG_DETAIL);
681 -
675 // VENDORS: Set your selection
676
677 // VENDOR: Mellanox
src/collectors/proc.plugin/sys_devices_system_node.c
-4
@@ -122,8 +122,6 @@ static void do_muma_numastat(struct node *m, int update_every) {
122
123 rrdlabels_add(m->numastat.st->rrdlabels, "numa_node", m->name, RRDLABEL_SRC_AUTO);
124
125 - rrdset_flag_set(m->numastat.st, RRDSET_FLAG_DETAIL);
126 -
125 rrddim_add(m->numastat.st, "numa_hit", "hit", 1, 1, RRD_ALGORITHM_INCREMENTAL);
126 rrddim_add(m->numastat.st, "numa_miss", "miss", 1, 1, RRD_ALGORITHM_INCREMENTAL);
127 rrddim_add(m->numastat.st, "local_node", "local", 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -204,8 +202,6 @@ static void do_numa_meminfo(struct node *m, int update_every) {
202
203 rrdlabels_add(m->meminfo.st->rrdlabels, "numa_node", m->name, RRDLABEL_SRC_AUTO);
204
207 - rrdset_flag_set(m->meminfo.st, RRDSET_FLAG_DETAIL);
208 -
205 rrddim_add(m->meminfo.st, "MemFree", "free", 1, 1, RRD_ALGORITHM_ABSOLUTE);
206 rrddim_add(m->meminfo.st, "MemUsed", "used", 1, 1, RRD_ALGORITHM_ABSOLUTE);
207 }
src/collectors/windows.plugin/perflib-network.c
-22
@@ -679,8 +679,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
679 update_every,
680 RRDSET_TYPE_AREA);
681
682 - rrdset_flag_set(d->traffic.st, RRDSET_FLAG_DETAIL);
683 -
682 add_interface_labels(d->traffic.st, windows_shared_buffer, physical);
683
684 d->traffic.rd_received = rrddim_add(d->traffic.st, "received", NULL, 8, BITS_IN_A_KILOBIT, RRD_ALGORITHM_INCREMENTAL);
@@ -716,8 +714,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
714 update_every,
715 RRDSET_TYPE_LINE);
716
719 - rrdset_flag_set(d->packets.st, RRDSET_FLAG_DETAIL);
720 -
717 add_interface_labels(d->packets.st, windows_shared_buffer, physical);
718
719 d->packets.rd_received = rrddim_add(d->packets.st, "received", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -746,8 +742,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
742 , RRDSET_TYPE_LINE
743 );
744
749 - rrdset_flag_set(d->speed.st, RRDSET_FLAG_DETAIL);
750 -
745 add_interface_labels(d->speed.st, windows_shared_buffer, physical);
746
747 d->speed.rd = rrddim_add(d->speed.st, "speed", NULL, 1, BITS_IN_A_KILOBIT, RRD_ALGORITHM_ABSOLUTE);
@@ -778,8 +772,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
772 update_every,
773 RRDSET_TYPE_LINE);
774
781 - rrdset_flag_set(d->errors.st, RRDSET_FLAG_DETAIL);
782 -
775 add_interface_labels(d->errors.st, windows_shared_buffer, physical);
776
777 d->errors.rd_received = rrddim_add(d->errors.st, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -809,8 +801,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
801 update_every,
802 RRDSET_TYPE_LINE);
803
812 - rrdset_flag_set(d->discards.st, RRDSET_FLAG_DETAIL);
813 -
804 add_interface_labels(d->discards.st, windows_shared_buffer, physical);
805
806 d->discards.rd_received = rrddim_add(d->discards.st, "inbound", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -838,8 +828,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
828 update_every,
829 RRDSET_TYPE_LINE);
830
841 - rrdset_flag_set(d->queue.st, RRDSET_FLAG_DETAIL);
842 -
831 add_interface_labels(d->queue.st, windows_shared_buffer, physical);
832
833 d->queue.rd = rrddim_add(d->queue.st, "length", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
@@ -865,8 +853,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
853 update_every,
854 RRDSET_TYPE_LINE);
855
868 - rrdset_flag_set(d->rsc.st_connections, RRDSET_FLAG_DETAIL);
869 -
856 add_interface_labels(d->rsc.st_connections, windows_shared_buffer, physical);
857
858 d->rsc.rd_connections = rrddim_add(d->rsc.st_connections, "connections", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
@@ -892,8 +878,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
878 update_every,
879 RRDSET_TYPE_LINE);
880
895 - rrdset_flag_set(d->rsc.st_packets, RRDSET_FLAG_DETAIL);
896 -
881 add_interface_labels(d->rsc.st_packets, windows_shared_buffer, physical);
882
883 d->rsc.rd_packets = rrddim_add(d->rsc.st_packets, "packets", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -919,8 +903,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
903 update_every,
904 RRDSET_TYPE_LINE);
905
922 - rrdset_flag_set(d->rsc.st_exceptions, RRDSET_FLAG_DETAIL);
923 -
906 add_interface_labels(d->rsc.st_exceptions, windows_shared_buffer, physical);
907
908 d->rsc.rd_exceptions = rrddim_add(d->rsc.st_exceptions, "exceptions", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
@@ -946,8 +928,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
928 update_every,
929 RRDSET_TYPE_LINE);
930
949 - rrdset_flag_set(d->rsc.st_average_packet_size, RRDSET_FLAG_DETAIL);
950 -
931 add_interface_labels(d->rsc.st_average_packet_size, windows_shared_buffer, physical);
932
933 d->rsc.rd_average_packet_size = rrddim_add(d->rsc.st_average_packet_size, "average", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
@@ -973,8 +953,6 @@ static bool do_network_interface(PERF_DATA_BLOCK *pDataBlock, int update_every,
953 update_every,
954 RRDSET_TYPE_LINE);
955
976 - rrdset_flag_set(d->chimney.st, RRDSET_FLAG_DETAIL);
977 -
956 add_interface_labels(d->chimney.st, windows_shared_buffer, physical);
957
958 d->chimney.rd = rrddim_add(d->chimney.st, "connections", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
src/collectors/windows.plugin/perflib-storage.c
-2
@@ -588,8 +588,6 @@ static bool do_physical_disk(PERF_DATA_BLOCK *pDataBlock, int update_every, usec
588 RRDSET_TYPE_LINE
589 );
590
591 - rrdset_flag_set(d->st_split, RRDSET_FLAG_DETAIL);
592 -
591 d->rd_split = rrddim_add(d->st_split, "discards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
592
593 physical_disk_labels(d->st_split, d);
src/database/rrd.h
-2
@@ -669,8 +669,6 @@ STORAGE_ENGINE* storage_engine_find(const char* name);
669 // and may lead to missing information.
670
671 typedef enum __attribute__ ((__packed__)) rrdset_flags {
672 - RRDSET_FLAG_DETAIL = (1 << 1), // if set, the data set should be considered as a detail of another
673 - // (the master data set should be the one that has the same family and is not detail)
672 RRDSET_FLAG_DEBUG = (1 << 2), // enables or disables debugging for a chart
673 RRDSET_FLAG_OBSOLETE = (1 << 3), // this is marked by the collector/module as obsolete
674 RRDSET_FLAG_EXPORTING_SEND = (1 << 4), // if set, this chart should be sent to Prometheus web API and external databases
src/plugins.d/README.md
+1 -1
@@ -330,7 +330,7 @@ the template is:
330
331 - `options`
332
333 - a space separated list of options, enclosed in quotes. 4 options are currently supported: `obsolete` to mark a chart as obsolete (Netdata will hide it and delete it after some time), `detail` to mark a chart as insignificant (this may be used by dashboards to make the charts smaller, or somehow visualize properly a less important chart), `store_first` to make Netdata store the first collected value, assuming there was an invisible previous value set to zero (this is used by statsd charts - if the first data collected value of incremental dimensions is not zero based, unrealistic spikes will appear with this option set) and `hidden` to perform all operations on a chart, but do not offer it on dashboards (the chart will be send to external databases). `CHART` options have been added in Netdata v1.7 and the `hidden` option was added in 1.10.
333 + a space separated list of options, enclosed in quotes. The following options are currently supported: `obsolete` to mark a chart as obsolete (Netdata will hide it and delete it after some time), `store_first` to make Netdata store the first collected value, assuming there was an invisible previous value set to zero (this is used by statsd charts - if the first data collected value of incremental dimensions is not zero based, unrealistic spikes will appear with this option set) and `hidden` to perform all operations on a chart, but do not offer it on dashboards (the chart will be send to external databases). `CHART` options have been added in Netdata v1.7 and the `hidden` option was added in 1.10.
334
335 - `plugin` and `module`
336
src/plugins.d/pluginsd_parser.c
-6
@@ -341,11 +341,6 @@ static inline PARSER_RC pluginsd_chart(char **words, size_t num_words, PARSER *p
341 else
342 rrdset_isnot_obsolete___safe_from_collector_thread(st);
343
344 - if (strstr(options, "detail"))
345 - rrdset_flag_set(st, RRDSET_FLAG_DETAIL);
346 - else
347 - rrdset_flag_clear(st, RRDSET_FLAG_DETAIL);
348 -
344 if (strstr(options, "hidden"))
345 rrdset_flag_set(st, RRDSET_FLAG_HIDDEN);
346 else
@@ -358,7 +353,6 @@ static inline PARSER_RC pluginsd_chart(char **words, size_t num_words, PARSER *p
353 }
354 else {
355 rrdset_isnot_obsolete___safe_from_collector_thread(st);
361 - rrdset_flag_clear(st, RRDSET_FLAG_DETAIL);
356 rrdset_flag_clear(st, RRDSET_FLAG_STORE_FIRST);
357 }
358
src/streaming/rrdpush.c
+1 -2
@@ -259,7 +259,7 @@ static inline bool rrdpush_send_chart_definition(BUFFER *wb, RRDSET *st) {
259 // send the chart
260 buffer_sprintf(
261 wb
262 - , " \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" %d %d \"%s %s %s %s\" \"%s\" \"%s\"\n"
262 + , " \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" %d %d \"%s %s %s\" \"%s\" \"%s\"\n"
263 , rrdset_id(st)
264 , name
265 , rrdset_title(st)
@@ -270,7 +270,6 @@ static inline bool rrdpush_send_chart_definition(BUFFER *wb, RRDSET *st) {
270 , st->priority
271 , st->update_every
272 , rrdset_flag_check(st, RRDSET_FLAG_OBSOLETE)?"obsolete":""
273 - , rrdset_flag_check(st, RRDSET_FLAG_DETAIL)?"detail":""
273 , rrdset_flag_check(st, RRDSET_FLAG_STORE_FIRST)?"store_first":""
274 , rrdset_flag_check(st, RRDSET_FLAG_HIDDEN)?"hidden":""
275 , rrdset_plugin_name(st)