@cryptotaxi247 / netdata-1 / commits / b8ab4747f

Fix retry code in build CI. (#12691)

It was always retrying steps instead of only doing so on failures.

Austin S. Hemmelgarn committed Apr 15, 2022 at 14:14 UTC b8ab4747fa44f9dfffa79481de2635b722536050
1 file changed +4 -4
.github/workflows/build.yml
+4 -4
@@ -226,10 +226,10 @@ jobs:
226 outputs: type=oci,dest=/tmp/image.tar
227 tags: test:${{ matrix.artifact_key }}
228 - name: Retry delay
229 - if: ${{ steps.build1.outcome }} == 'failure'
229 + if: ${{ steps.build1.outcome == 'failure' }}
230 run: sleep "${RETRY_DELAY}"
231 - name: Build test environment (attempt 2)
232 - if: ${{ steps.build1.outcome }} == 'failure'
232 + if: ${{ steps.build1.outcome == 'failure' }}
233 id: build2
234 uses: docker/build-push-action@v2
235 continue-on-error: true # We retry 3 times at 5 minute intervals if there is a failure here.
@@ -244,10 +244,10 @@ jobs:
244 outputs: type=oci,dest=/tmp/image.tar
245 tags: test:${{ matrix.artifact_key }}
246 - name: Retry delay
247 - if: ${{ steps.build1.outcome }} == 'failure' && ${{ steps.build2.outcome }} == 'failure'
247 + if: ${{ steps.build1.outcome == 'failure' && steps.build2.outcome == 'failure' }}
248 run: sleep "${RETRY_DELAY}"
249 - name: Build test environment (attempt 3)
250 - if: ${{ steps.build1.outcome }} == 'failure' && ${{ steps.build2.outcome }} == 'failure'
250 + if: ${{ steps.build1.outcome == 'failure' && steps.build2.outcome == 'failure' }}
251 id: build3
252 uses: docker/build-push-action@v2
253 with: