@cryptotaxi247 / netdata-1 / commits / b92f5a327

Use old mqtt implementation as default (#13258)

mqtt5 as default off

Emmanuel Vasilakis committed Jun 29, 2022 at 16:34 UTC b92f5a3271bb0fb7d16b2c406e473eec7bd68102
3 files changed +4 -4
aclk/README.md
+2 -2
@@ -50,12 +50,12 @@ You can configure following keys in the `netdata.conf` section `[cloud]`:
50 [cloud]
51 statistics = yes
52 query thread count = 2
53 - mqtt5 = yes
53 + mqtt5 = no
54 ```
55
56 - `statistics` enables/disables ACLK related statistics and their charts. You can disable this to save some space in the database and slightly reduce memory usage of Netdata Agent.
57 - `query thread count` specifies the number of threads to process cloud queries. Increasing this setting is useful for nodes with many children (streaming), which can expect to handle more queries (and/or more complicated queries).
58 -- `mqtt5` allows disabling the new MQTT5 implementation which is used now by default in case of issues. This option will be removed in future stable release.
58 +- `mqtt5` enables the new MQTT5 protocol implementation in the Agent. Currently a technical preview.
59
60 ## Disable the ACLK
61
aclk/aclk.c
+1 -1
@@ -628,7 +628,7 @@ void *aclk_main(void *ptr)
628 if (wait_till_agent_claim_ready())
629 goto exit;
630
631 - use_mqtt_5 = config_get_boolean(CONFIG_SECTION_CLOUD, "mqtt5", CONFIG_BOOLEAN_YES);
631 + use_mqtt_5 = config_get_boolean(CONFIG_SECTION_CLOUD, "mqtt5", CONFIG_BOOLEAN_NO);
632
633 if (!(mqttwss_client = mqtt_wss_new("mqtt_wss", aclk_mqtt_wss_log_cb, msg_callback, puback_callback, use_mqtt_5))) {
634 error("Couldn't initialize MQTT_WSS network library");
aclk/aclk_api.c
+1 -1
@@ -61,7 +61,7 @@ void add_aclk_host_labels(void) {
61 }
62
63
64 - int mqtt5 = config_get_boolean(CONFIG_SECTION_CLOUD, "mqtt5", CONFIG_BOOLEAN_YES);
64 + int mqtt5 = config_get_boolean(CONFIG_SECTION_CLOUD, "mqtt5", CONFIG_BOOLEAN_NO);
65
66 rrdlabels_add(labels, "_mqtt_version", mqtt5 ? "5" : "3", RRDLABEL_SRC_AUTO);
67 rrdlabels_add(labels, "_aclk_impl", "Next Generation", RRDLABEL_SRC_AUTO);