Fix CI issues in build workflow. (#18266)
* Temporarily enable trace mode to debug CI. * Fix tmpdir path handling. * Further kickstart fixes.
Austin S. Hemmelgarn committed
Aug 6, 2024 at 13:57 UTC
b936b41c669ed12c0419c27fd9bd4e255cb90513
2 files changed
+19
-15
.github/workflows/build.yml
+2
-2
@@ -397,7 +397,7 @@ jobs:
397
if: needs.file-check.outputs.run == 'true'
398
env:
399
NETDATA_TARBALL_BASEURL: http://localhost:8080/
400
- run: packaging/installer/kickstart.sh --build-only --dont-start-it --disable-telemetry --dont-wait
400
+ run: sh -x packaging/installer/kickstart.sh --build-only --dont-start-it --disable-telemetry --dont-wait
401
- name: Failure Notification
402
uses: rtCamp/action-slack-notify@v2
403
env:
@@ -466,7 +466,7 @@ jobs:
466
if: needs.file-check.outputs.run == 'true'
467
env:
468
NETDATA_TARBALL_BASEURL: http://localhost:8080/
469
- run: packaging/installer/kickstart.sh --static-only --dont-start-it --disable-telemetry
469
+ run: sh -x packaging/installer/kickstart.sh --static-only --dont-start-it --disable-telemetry
470
- name: Failure Notification
471
uses: rtCamp/action-slack-notify@v2
472
env:
packaging/installer/kickstart.sh
+17
-13
@@ -2,7 +2,7 @@
2
#
3
# SPDX-License-Identifier: GPL-3.0-or-later
4
#
5
-# Next unused error code: F051A
5
+# Next unused error code: F051B
6
7
# ======================================================================
8
# Constants
@@ -378,12 +378,14 @@ trap 'trap_handler 15 0' TERM
378
# Utility functions
379
380
canonical_path() {
381
+ OLDPWD="$(pwd)"
382
cd "$(dirname "${1}")" || exit 1
383
case "$(basename "${1}")" in
384
..) dirname "$(pwd -P)" ;;
385
.) pwd -P ;;
386
*) echo "$(pwd -P)/$(basename "${1}")" ;;
387
esac
388
+ cd "${OLDPWD}" || exit 1
389
}
390
391
setup_terminal() {
@@ -1794,11 +1796,11 @@ try_static_install() {
1796
return 2
1797
fi
1798
1797
- if ! download "${NETDATA_STATIC_ARCHIVE_URL}" "${tmpdir}/${netdata_agent}"; then
1799
+ if ! download "${NETDATA_STATIC_ARCHIVE_URL}" "./${netdata_agent}"; then
1800
fatal "Unable to download static build archive for ${SYSARCH}. ${BADNET_MSG}." F0208
1801
fi
1802
1801
- if ! download "${NETDATA_STATIC_ARCHIVE_CHECKSUM_URL}" "${tmpdir}/sha256sum.txt"; then
1803
+ if ! download "${NETDATA_STATIC_ARCHIVE_CHECKSUM_URL}" "./sha256sum.txt"; then
1804
fatal "Unable to fetch checksums to verify static build archive. ${BADNET_MSG}." F0206
1805
fi
1806
@@ -1806,7 +1808,7 @@ try_static_install() {
1808
progress "Would validate SHA256 checksum of downloaded static build archive."
1809
else
1810
if [ -z "${INSTALL_VERSION}" ]; then
1809
- if ! grep "${netdata_agent}" "${tmpdir}/sha256sum.txt" | safe_sha256sum -c - > /dev/null 2>&1; then
1811
+ if ! grep "${netdata_agent}" ./sha256sum.txt | safe_sha256sum -c - > /dev/null 2>&1; then
1812
fatal "Static binary checksum validation failed. ${BADCACHE_MSG}." F0207
1813
fi
1814
fi
@@ -1824,7 +1826,7 @@ try_static_install() {
1826
1827
progress "Installing netdata"
1828
# shellcheck disable=SC2086
1827
- if ! run_as_root ${env_cmd} /bin/sh "${tmpdir}/${netdata_agent}" ${opts} -- ${NETDATA_INSTALLER_OPTIONS}; then
1829
+ if ! run_as_root ${env_cmd} /bin/sh "./${netdata_agent}" ${opts} -- ${NETDATA_INSTALLER_OPTIONS}; then
1830
warning "Failed to install static build of Netdata on ${SYSARCH}."
1831
run rm -rf /opt/netdata
1832
return 2
@@ -1936,6 +1938,7 @@ build_and_install() {
1938
run_script ./netdata-installer.sh ${opts}
1939
1940
case $? in
1941
+ 0) ;;
1942
1)
1943
if [ -n "${EXIT_REASON}" ]; then
1944
fatal "netdata-installer.sh failed to run: ${EXIT_REASON}" "${EXIT_CODE}"
@@ -1944,6 +1947,7 @@ build_and_install() {
1947
fi
1948
;;
1949
2) fatal "Insufficient RAM to install netdata." F0008 ;;
1950
+ *) fatal "netdata-installer.sh failed to run: Encountered an unhandled error in the installer code." F051A ;;
1951
esac
1952
}
1953
@@ -1963,14 +1967,14 @@ try_build_install() {
1967
set_source_archive_urls "${SELECTED_RELEASE_CHANNEL}"
1968
1969
if [ -n "${INSTALL_VERSION}" ]; then
1966
- if ! download "${NETDATA_SOURCE_ARCHIVE_URL}" "${tmpdir}/netdata-v${INSTALL_VERSION}.tar.gz"; then
1970
+ if ! download "${NETDATA_SOURCE_ARCHIVE_URL}" "./netdata-v${INSTALL_VERSION}.tar.gz"; then
1971
fatal "Failed to download source tarball for local build. ${BADNET_MSG}." F000B
1972
fi
1969
- elif ! download "${NETDATA_SOURCE_ARCHIVE_URL}" "${tmpdir}/netdata-latest.tar.gz"; then
1973
+ elif ! download "${NETDATA_SOURCE_ARCHIVE_URL}" "./netdata-latest.tar.gz"; then
1974
fatal "Failed to download source tarball for local build. ${BADNET_MSG}." F000B
1975
fi
1976
1973
- if ! download "${NETDATA_SOURCE_ARCHIVE_CHECKSUM_URL}" "${tmpdir}/sha256sum.txt"; then
1977
+ if ! download "${NETDATA_SOURCE_ARCHIVE_CHECKSUM_URL}" "./sha256sum.txt"; then
1978
fatal "Failed to download checksums for source tarball verification. ${BADNET_MSG}." F000C
1979
fi
1980
@@ -1979,18 +1983,18 @@ try_build_install() {
1983
else
1984
if [ -z "${INSTALL_VERSION}" ]; then
1985
# shellcheck disable=SC2086
1982
- if ! grep netdata-latest.tar.gz "${tmpdir}/sha256sum.txt" | safe_sha256sum -c - > /dev/null 2>&1; then
1986
+ if ! grep netdata-latest.tar.gz "./sha256sum.txt" | safe_sha256sum -c - > /dev/null 2>&1; then
1987
fatal "Tarball checksum validation failed. ${BADCACHE_MSG}." F0005
1988
fi
1989
fi
1990
fi
1991
1992
if [ -n "${INSTALL_VERSION}" ]; then
1989
- run tar -xf "${tmpdir}/netdata-v${INSTALL_VERSION}.tar.gz" -C "${tmpdir}"
1990
- rm -rf "${tmpdir}/netdata-v${INSTALL_VERSION}.tar.gz" > /dev/null 2>&1
1993
+ run tar -xf "./netdata-v${INSTALL_VERSION}.tar.gz" -C "${tmpdir}"
1994
+ rm -rf "./netdata-v${INSTALL_VERSION}.tar.gz" > /dev/null 2>&1
1995
else
1992
- run tar -xf "${tmpdir}/netdata-latest.tar.gz" -C "${tmpdir}"
1993
- rm -rf "${tmpdir}/netdata-latest.tar.gz" > /dev/null 2>&1
1996
+ run tar -xf "./netdata-latest.tar.gz" -C "${tmpdir}"
1997
+ rm -rf "./netdata-latest.tar.gz" > /dev/null 2>&1
1998
fi
1999
2000
if [ "${DRY_RUN}" -ne 1 ]; then