@cryptotaxi247 / netdata-1 / commits / c6e39cffd

Personalize installer and uninstaller Windows (Control Panel) (#18147)

thiagoftsm committed Jul 16, 2024 at 19:57 UTC c6e39cffd682b169eac274b3f66e2084b4dcf663
3 files changed +42 -3
packaging/utils/NetdataWhite.ico
Binary files /dev/null and b/packaging/utils/NetdataWhite.ico differ
packaging/utils/installer.nsi
+35
@@ -1,10 +1,16 @@
1 !include "MUI2.nsh"
2 +!include "FileFunc.nsh"
3
4 Name "Netdata"
5 Outfile "netdata-installer.exe"
6 InstallDir "$PROGRAMFILES\netdata"
7 RequestExecutionLevel admin
8
9 +!define MUI_ICON "NetdataWhite.ico"
10 +!define MUI_UNICON "NetdataWhite.ico"
11 +
12 +!define ND_UININSTALL_REG "Software\Microsoft\Windows\CurrentVersion\Uninstall\Netdata"
13 +
14 !define MUI_ABORTWARNING
15 !define MUI_UNABORTWARNING
16
@@ -41,6 +47,33 @@ Section "Install Netdata"
47 DetailPrint "Warning: Failed to start Netdata service."
48
49 WriteUninstaller "$INSTDIR\Uninstall.exe"
50 +
51 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
52 + "DisplayName" "Netdata - Real-time system monitoring."
53 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
54 + "DisplayIcon" "$INSTDIR\Uninstall.exe,0"
55 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
56 + "UninstallString" "$INSTDIR\Uninstall.exe"
57 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
58 + "RegOwner" "Netdata Inc."
59 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
60 + "RegCompany" "Netdata Inc."
61 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
62 + "Publisher" "Netdata Inc."
63 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
64 + "HelpLink" "https://learn.netdata.cloud/"
65 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
66 + "URLInfoAbout" "https://www.netdata.cloud/"
67 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
68 + "DisplayVersion" "${CURRVERSION}"
69 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
70 + "VersionMajor" "${MAJORVERSION}"
71 + WriteRegStr HKLM "${ND_UININSTALL_REG}" \
72 + "VersionMinor" "${MINORVERSION}"
73 +
74 + ${GetSize} "$INSTDIR" "/S=0K" $0 $1 $2
75 + IntFmt $0 "0x%08X" $0
76 + WriteRegDWORD HKLM "${ND_UININSTALL_REG}" "EstimatedSize" "$0"
77 SectionEnd
78
79 Section "Uninstall"
@@ -55,4 +88,6 @@ Section "Uninstall"
88 DetailPrint "Warning: Failed to delete Netdata service."
89
90 RMDir /r "$INSTDIR"
91 +
92 + DeleteRegKey HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Netdata"
93 SectionEnd
packaging/utils/package-windows.sh
+7 -3
@@ -1,9 +1,8 @@
1 -#!/bin/sh
1 +#!/bin/bash
2
3 export PATH="/usr/local/bin:${PATH}"
4
5 WT_ROOT="$(pwd)"
6 -NULL=""
6
7 if [ -z "${MSYSTEM}" ]; then
8 build="${WT_ROOT}/build-${OSTYPE}"
@@ -24,4 +23,9 @@ if [ ! -f "/msys2-installer.exe" ]; then
23 "https://github.com/msys2/msys2-installer/releases/download/2024-05-07/msys2-x86_64-20240507.exe"
24 fi
25
27 -makensis "${WT_ROOT}/packaging/utils/installer.nsi"
26 +NDVERSION=$"$(grep 'CMAKE_PROJECT_VERSION:STATIC' "${build}/CMakeCache.txt"| cut -d= -f2)"
27 +NDMAJORVERSION=$"$(grep 'CMAKE_PROJECT_VERSION_MAJOR:STATIC' "${build}/CMakeCache.txt"| cut -d= -f2)"
28 +NDMINORVERSION=$"$(grep 'CMAKE_PROJECT_VERSION_MINOR:STATIC' "${build}/CMakeCache.txt"| cut -d= -f2)"
29 +
30 +makensis -DCURRVERSION="${NDVERSION}" -DMAJORVERSION="${NDMAJORVERSION}" -DMINORVERSION="${NDMINORVERSION}" "${WT_ROOT}/packaging/utils/installer.nsi"
31 +