Small cleanup (#16996)
* Remove unused header * Mark functions as static.
vkalintiris committed
Feb 12, 2024 at 15:20 UTC
ce3724f1ddc4abde85c1a741f1bef972bd421ee9
4 files changed
+4
-8
src/collectors/cgroups.plugin/cgroup-network.c
-1
@@ -7,7 +7,6 @@
7
#ifndef _GNU_SOURCE
8
#define _GNU_SOURCE /* See feature_test_macros(7) */
9
#endif
10
-#include <sched.h>
10
#endif
11
12
char env_netdata_host_prefix[FILENAME_MAX + 50] = "";
src/daemon/daemon.c
+4
-4
@@ -60,7 +60,7 @@ static void fix_directory_file_permissions(const char *dirname, uid_t uid, gid_t
60
closedir(dir);
61
}
62
63
-void change_dir_ownership(const char *dir, uid_t uid, gid_t gid, bool recursive)
63
+static void change_dir_ownership(const char *dir, uid_t uid, gid_t gid, bool recursive)
64
{
65
if (chown(dir, uid, gid) == -1)
66
netdata_log_error("Cannot chown directory '%s' to %u:%u", dir, (unsigned int)uid, (unsigned int)gid);
@@ -68,7 +68,7 @@ void change_dir_ownership(const char *dir, uid_t uid, gid_t gid, bool recursive)
68
fix_directory_file_permissions(dir, uid, gid, recursive);
69
}
70
71
-void clean_directory(char *dirname)
71
+static void clean_directory(char *dirname)
72
{
73
DIR *dir = opendir(dirname);
74
if(!dir) return;
@@ -84,7 +84,7 @@ void clean_directory(char *dirname)
84
closedir(dir);
85
}
86
87
-void prepare_required_directories(uid_t uid, gid_t gid) {
87
+static void prepare_required_directories(uid_t uid, gid_t gid) {
88
change_dir_ownership(netdata_configured_cache_dir, uid, gid, true);
89
change_dir_ownership(netdata_configured_varlib_dir, uid, gid, false);
90
change_dir_ownership(netdata_configured_lock_dir, uid, gid, false);
@@ -98,7 +98,7 @@ void prepare_required_directories(uid_t uid, gid_t gid) {
98
clean_directory(netdata_configured_lock_dir);
99
}
100
101
-int become_user(const char *username, int pid_fd) {
101
+static int become_user(const char *username, int pid_fd) {
102
int am_i_root = (getuid() == 0)?1:0;
103
104
struct passwd *pw = getpwnam(username);
src/daemon/daemon.h
-2
@@ -3,8 +3,6 @@
3
#ifndef NETDATA_DAEMON_H
4
#define NETDATA_DAEMON_H 1
5
6
-int become_user(const char *username, int pid_fd);
7
-
6
int become_daemon(int dont_fork, const char *user);
7
8
void netdata_cleanup_and_exit(int ret, const char *action, const char *action_result, const char *action_data);
src/database/rrdset.c
-1
@@ -2,7 +2,6 @@
2
3
#define NETDATA_RRD_INTERNALS
4
#include "rrd.h"
5
-#include <sched.h>
5
#include "storage_engine.h"
6
7