better logging messages in ExecutableService
paulfantom committed
Jul 16, 2016 at 01:08 UTC
cf29f387460a9ccf025e94d15427fa6363fe431b
1 file changed
+2
-1
python.d/python_modules/base.py
+2
-1
@@ -670,7 +670,7 @@ class ExecutableService(SimpleService):
670
try:
671
p = Popen(self.command, stdout=PIPE, stderr=PIPE)
672
except Exception as e:
673
- self.error(str(e))
673
+ self.error("Executing command", self.command, "resulted in error:", str(e))
674
return None
675
data = []
676
for line in p.stdout.readlines():
@@ -715,5 +715,6 @@ class ExecutableService(SimpleService):
715
# break
716
717
if self._get_data() is None or len(self._get_data()) == 0:
718
+ self.error("Command", self.command, "returned no data")
719
return False
720
return True