fix docker host editable config (#14104)
Fixes https://github.com/netdata/netdata/issues/14103
Ilya Mashchenko committed
Dec 8, 2022 at 11:15 UTC
d0dad4459ee5bece15a3b2bb88149956d495fbb3
2 files changed
+8
-6
packaging/docker/README.md
+2
-2
@@ -196,12 +196,12 @@ docker rm -f netdata_tmp
196
```
197
198
**`docker run`**: Use the `docker run` command, along with the following options, to start a new container. Note the
199
-changed `-v $(pwd)/netdataconfig/netdata:/etc/netdata:ro \` line from the recommended example above.
199
+changed `-v $(pwd)/netdataconfig/netdata:/etc/netdata \` line from the recommended example above.
200
201
```bash
202
docker run -d --name=netdata \
203
-p 19999:19999 \
204
- -v $(pwd)/netdataconfig/netdata:/etc/netdata:ro \
204
+ -v $(pwd)/netdataconfig/netdata:/etc/netdata \
205
-v netdatalib:/var/lib/netdata \
206
-v netdatacache:/var/cache/netdata \
207
-v /etc/passwd:/host/etc/passwd:ro \
packaging/docker/run.sh
+6
-4
@@ -49,10 +49,12 @@ if mountpoint -q /etc/netdata && [ -z "$(ls -A /etc/netdata)" ]; then
49
cp -a /etc/netdata.stock/. /etc/netdata
50
fi
51
52
-if mountpoint -q /etc/netdata; then
53
- hostname > /etc/netdata/.container-hostname
54
-else
55
- rm -f /etc/netdata/.container-hostname
52
+if [ -w "/etc/netdata" ]; then
53
+ if mountpoint -q /etc/netdata; then
54
+ hostname >/etc/netdata/.container-hostname
55
+ else
56
+ rm -f /etc/netdata/.container-hostname
57
+ fi
58
fi
59
60
if [ -n "${NETDATA_CLAIM_URL}" ] && [ -n "${NETDATA_CLAIM_TOKEN}" ] && [ ! -f /var/lib/netdata/cloud.d/claimed_id ]; then