go.d nvidia_smi: use XML format by default (#17481)
Ilya Mashchenko committed
Apr 22, 2024 at 16:32 UTC
d1494e0f5f6dd1a4a58b0fd681fc539e44279033
4 files changed
+8
-8
src/go/collectors/go.d.plugin/config/go.d/nvidia_smi.conf
+1
-1
@@ -3,4 +3,4 @@
3
4
jobs:
5
- name: nvidia_smi
6
- use_csv_format: yes
6
+ use_csv_format: no
src/go/collectors/go.d.plugin/modules/nvidia_smi/config_schema.json
+1
-1
@@ -28,7 +28,7 @@
28
"title": "Use CSV format",
29
"description": "Determines the format used for requesting GPU information. If set, CSV format is used, otherwise XML.",
30
"type": "boolean",
31
- "default": true
31
+ "default": false
32
}
33
},
34
"required": [
src/go/collectors/go.d.plugin/modules/nvidia_smi/metadata.yaml
+5
-5
@@ -75,10 +75,10 @@ modules:
75
required: false
76
- name: use_csv_format
77
description: Used format when requesting GPU information. XML is used if set to 'no'.
78
- default_value: true
78
+ default_value: false
79
required: false
80
details: |
81
- This module supports data collection in CSV and XML formats. The default is CSV.
81
+ This module supports data collection in CSV and XML formats. The default is XML.
82
83
- XML provides more metrics, but requesting GPU information consumes more CPU, especially if there are multiple GPUs in the system.
84
- CSV provides fewer metrics, but is much lighter than XML in terms of CPU usage.
@@ -87,12 +87,12 @@ modules:
87
title: Config
88
enabled: true
89
list:
90
- - name: XML format
91
- description: Use XML format when requesting GPU information.
90
+ - name: CSV format
91
+ description: Use CSV format when requesting GPU information.
92
config: |
93
jobs:
94
- name: nvidia_smi
95
- use_csv_format: no
95
+ use_csv_format: yes
96
- name: Custom binary path
97
description: The executable is not in the directories specified in the PATH environment variable.
98
config: |
src/go/collectors/go.d.plugin/modules/nvidia_smi/nvidia_smi.go
+1
-1
@@ -29,7 +29,7 @@ func New() *NvidiaSMI {
29
return &NvidiaSMI{
30
Config: Config{
31
Timeout: web.Duration(time.Second * 10),
32
- UseCSVFormat: true,
32
+ UseCSVFormat: false,
33
},
34
binName: "nvidia-smi",
35
charts: &module.Charts{},