@cryptotaxi247 / netdata-1 / commits / d3c5ffab0

Remove unused synproxy chart (#11582)

Vladimir Kobal committed Sep 28, 2021 at 15:52 UTC d3c5ffab0d70145db06de4f46de8172c7461e82a
1 file changed +4 -37
collectors/proc.plugin/proc_net_stat_synproxy.c
+4 -37
@@ -10,11 +10,10 @@
10 int do_proc_net_stat_synproxy(int update_every, usec_t dt) {
11 (void)dt;
12
13 - static int do_entries = -1, do_cookies = -1, do_syns = -1, do_reopened = -1;
13 + static int do_cookies = -1, do_syns = -1, do_reopened = -1;
14 static procfile *ff = NULL;
15
16 - if(unlikely(do_entries == -1)) {
17 - do_entries = config_get_boolean_ondemand("plugin:proc:/proc/net/stat/synproxy", "SYNPROXY entries", CONFIG_BOOLEAN_AUTO);
16 + if(unlikely(do_cookies == -1)) {
17 do_cookies = config_get_boolean_ondemand("plugin:proc:/proc/net/stat/synproxy", "SYNPROXY cookies", CONFIG_BOOLEAN_AUTO);
18 do_syns = config_get_boolean_ondemand("plugin:proc:/proc/net/stat/synproxy", "SYNPROXY SYN received", CONFIG_BOOLEAN_AUTO);
19 do_reopened = config_get_boolean_ondemand("plugin:proc:/proc/net/stat/synproxy", "SYNPROXY connections reopened", CONFIG_BOOLEAN_AUTO);
@@ -39,7 +38,7 @@ int do_proc_net_stat_synproxy(int update_every, usec_t dt) {
38 return 1;
39 }
40
42 - unsigned long long entries = 0, syn_received = 0, cookie_invalid = 0, cookie_valid = 0, cookie_retrans = 0, conn_reopened = 0;
41 + unsigned long long syn_received = 0, cookie_invalid = 0, cookie_valid = 0, cookie_retrans = 0, conn_reopened = 0;
42
43 // synproxy gives its values per CPU
44 for(l = 1; l < lines ;l++) {
@@ -47,7 +46,6 @@ int do_proc_net_stat_synproxy(int update_every, usec_t dt) {
46 if(unlikely(words < 6))
47 continue;
48
50 - entries += strtoull(procfile_lineword(ff, l, 0), NULL, 16);
49 syn_received += strtoull(procfile_lineword(ff, l, 1), NULL, 16);
50 cookie_invalid += strtoull(procfile_lineword(ff, l, 2), NULL, 16);
51 cookie_valid += strtoull(procfile_lineword(ff, l, 3), NULL, 16);
@@ -55,38 +53,7 @@ int do_proc_net_stat_synproxy(int update_every, usec_t dt) {
53 conn_reopened += strtoull(procfile_lineword(ff, l, 5), NULL, 16);
54 }
55
58 - unsigned long long events = entries + syn_received + cookie_invalid + cookie_valid + cookie_retrans + conn_reopened;
59 -
60 - // --------------------------------------------------------------------
61 -
62 - if(do_entries == CONFIG_BOOLEAN_YES || (do_entries == CONFIG_BOOLEAN_AUTO &&
63 - (events || netdata_zero_metrics_enabled == CONFIG_BOOLEAN_YES))) {
64 - do_entries = CONFIG_BOOLEAN_YES;
65 -
66 - static RRDSET *st = NULL;
67 - if(unlikely(!st)) {
68 - st = rrdset_create_localhost(
69 - RRD_TYPE_NET_STAT_NETFILTER
70 - , RRD_TYPE_NET_STAT_SYNPROXY "_entries"
71 - , NULL
72 - , RRD_TYPE_NET_STAT_SYNPROXY
73 - , NULL
74 - , "SYNPROXY Entries Used"
75 - , "entries"
76 - , PLUGIN_PROC_NAME
77 - , PLUGIN_PROC_MODULE_SYNPROXY_NAME
78 - , NETDATA_CHART_PRIO_SYNPROXY_ENTRIES
79 - , update_every
80 - , RRDSET_TYPE_LINE
81 - );
82 -
83 - rrddim_add(st, "entries", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
84 - }
85 - else rrdset_next(st);
86 -
87 - rrddim_set(st, "entries", entries);
88 - rrdset_done(st);
89 - }
56 + unsigned long long events = syn_received + cookie_invalid + cookie_valid + cookie_retrans + conn_reopened;
57
58 // --------------------------------------------------------------------
59