@cryptotaxi247 / netdata-1 / commits / d4a15fdd7

install netdata logrotate file, fixes #413

Costa Tsaousis (ktsaou) committed May 15, 2016 at 13:28 UTC d4a15fdd79d877d8f622904040603d7c244730fd
1 file changed +21 -6
netdata-installer.sh
+21 -6
@@ -303,7 +303,7 @@ run() {
303 if [ ${LIBS_ARE_HERE} -eq 1 ]
304 then
305 shift
306 - echo >&2 "ok, assuming zlib is really installed."
306 + echo >&2 "ok, assuming libs are really installed."
307 export ZLIB_CFLAGS=" "
308 export ZLIB_LIBS="-lz"
309 export UUID_CFLAGS=" "
@@ -337,11 +337,16 @@ echo >&2 "Compiling netdata ..."
337 run make || exit 1
338
339 # backup user configurations
340 +installer_backup_suffix="${PID}.${RANDOM}"
341 for x in apps_groups.conf charts.d.conf
342 do
343 if [ -f "${NETDATA_PREFIX}/etc/netdata/${x}" ]
344 then
344 - cp -p "${NETDATA_PREFIX}/etc/netdata/${x}" "${NETDATA_PREFIX}/etc/netdata/${x}.installer_backup"
345 + cp -p "${NETDATA_PREFIX}/etc/netdata/${x}" "${NETDATA_PREFIX}/etc/netdata/${x}.installer_backup.${installer_backup_suffix}"
346 +
347 + elif [ -f "${NETDATA_PREFIX}/etc/netdata/${x}.installer_backup.${installer_backup_suffix}" ]
348 + then
349 + rm -f "${NETDATA_PREFIX}/etc/netdata/${x}.installer_backup.${installer_backup_suffix}"
350 fi
351 done
352
@@ -351,9 +356,9 @@ run make install || exit 1
356 # restore user configurations
357 for x in apps_groups.conf charts.d.conf
358 do
354 - if [ -f "${NETDATA_PREFIX}/etc/netdata/${x}.installer_backup" ]
359 + if [ -f "${NETDATA_PREFIX}/etc/netdata/${x}.installer_backup.${installer_backup_suffix}" ]
360 then
356 - cp -p "${NETDATA_PREFIX}/etc/netdata/${x}.installer_backup" "${NETDATA_PREFIX}/etc/netdata/${x}"
361 + cp -p "${NETDATA_PREFIX}/etc/netdata/${x}.installer_backup.${installer_backup_suffix}" "${NETDATA_PREFIX}/etc/netdata/${x}"
362 fi
363 done
364
@@ -391,6 +396,12 @@ if [ ${UID} -eq 0 ]
396 # let the uninstall script know
397 NETDATA_ADDED_TO_DOCKER=1
398 fi
399 +
400 + if [ -d /etc/logrotate.d -a ! -f /etc/logrotate.d/netdata ]
401 + then
402 + echo >&2 "Adding netdata logrotate configuration ..."
403 + run cp system/netdata.logrotate /etc/logrotate.d/netdata
404 + fi
405 fi
406
407
@@ -706,8 +717,6 @@ if [ "${UID}" -ne 0 ]
717 sudo chown root "${NETDATA_PREFIX}/usr/libexec/netdata/plugins.d/apps.plugin"
718 sudo chmod 4755 "${NETDATA_PREFIX}/usr/libexec/netdata/plugins.d/apps.plugin"
719
709 - These commands allow apps.plugin to run as root.
710 -
720 apps.plugin is performing a hard-coded function of data collection for all
721 running processes. It cannot be instructed from the netdata daemon to perform
722 any task, so it is pretty safe to do this.
@@ -766,6 +775,12 @@ cat >netdata-uninstaller.sh <<-UNINSTALL
775 deletedir "${NETDATA_PREFIX}/var/log/netdata"
776 fi
777
778 + if [ -f /etc/logrotate.d/netdata ]
779 + then
780 + echo "Deleting /etc/logrotate.d/netdata ..."
781 + rm -i /etc/logrotate.d/netdata
782 + fi
783 +
784 getent passwd netdata > /dev/null
785 if [ $? -eq 0 ]
786 then