Compilation Warning (BSD and Windows) (#22024)
thiagoftsm committed
Mar 24, 2026 at 12:18 UTC
d841e02b98874903840a21b3dd0158816cc5e2cb
4 files changed
+21
-18
src/aclk/https_client.c
+6
-5
@@ -184,6 +184,7 @@ void http_parse_ctx_create(http_parse_ctx *ctx, enum http_parse_state parse_stat
184
#define POLL_TO_MS 100
185
186
#define HTTP_LINE_TERM "\x0D\x0A"
187
+#define HTTP_LINE_TERM_LEN (sizeof(HTTP_LINE_TERM) - 1)
188
#define RESP_PROTO "HTTP/1.1 "
189
#define RESP_PROTO10 "HTTP/1.0 "
190
#define HTTP_KEYVAL_SEPARATOR ": "
@@ -333,7 +334,7 @@ static int process_chunked_content(rbuf_t buf, http_parse_ctx *parse_ctx)
334
}
335
parse_ctx->chunk_got = 0;
336
chunked_response_buffer_grow_by(parse_ctx, parse_ctx->chunk_size);
336
- rbuf_bump_tail(buf, strlen(HTTP_LINE_TERM));
337
+ rbuf_bump_tail(buf, HTTP_LINE_TERM_LEN);
338
parse_ctx->chunked_content_state = CHUNKED_CONTENT_CHUNK_DATA;
339
// fallthrough
340
case CHUNKED_CONTENT_CHUNK_DATA:
@@ -350,11 +351,11 @@ static int process_chunked_content(rbuf_t buf, http_parse_ctx *parse_ctx)
351
// fallthrough
352
case CHUNKED_CONTENT_FINAL_CRLF:
353
case CHUNKED_CONTENT_CHUNK_END_CRLF:
353
- if (rbuf_bytes_available(buf) < strlen(HTTP_LINE_TERM))
354
+ if (rbuf_bytes_available(buf) < HTTP_LINE_TERM_LEN)
355
return HTTP_PARSE_NEED_MORE_DATA;
355
- char buf_crlf[strlen(HTTP_LINE_TERM)];
356
- rbuf_pop(buf, buf_crlf, strlen(HTTP_LINE_TERM));
357
- if (memcmp(buf_crlf, HTTP_LINE_TERM, strlen(HTTP_LINE_TERM))) {
356
+ char buf_crlf[HTTP_LINE_TERM_LEN];
357
+ rbuf_pop(buf, buf_crlf, HTTP_LINE_TERM_LEN);
358
+ if (memcmp(buf_crlf, HTTP_LINE_TERM, HTTP_LINE_TERM_LEN)) {
359
netdata_log_error("ACLK: CRLF expected");
360
return HTTP_PARSE_ERROR;
361
}
src/daemon/unit_test.c
+9
-9
@@ -790,15 +790,15 @@ struct feed_values test5b_feed[] = {
790
};
791
792
NETDATA_DOUBLE test5b_results[] = {
793
- 0xFFFFFFFFFFFFFFFFULL / 15 * 7,
794
- 0xFFFFFFFFFFFFFFFFULL / 15 * 7,
795
- 0xFFFFFFFFFFFFFFFFULL / 15,
796
- 0xFFFFFFFFFFFFFFFFULL / 15 * 7,
797
- 0xFFFFFFFFFFFFFFFFULL / 15 * 7,
798
- 0xFFFFFFFFFFFFFFFFULL / 15,
799
- 0xFFFFFFFFFFFFFFFFULL / 15 * 7,
800
- 0xFFFFFFFFFFFFFFFFULL / 15 * 7,
801
- 0xFFFFFFFFFFFFFFFFULL / 15,
793
+ (NETDATA_DOUBLE)0xFFFFFFFFFFFFFFFFULL / (NETDATA_DOUBLE)15 * (NETDATA_DOUBLE)7,
794
+ (NETDATA_DOUBLE)0xFFFFFFFFFFFFFFFFULL / (NETDATA_DOUBLE)15 * (NETDATA_DOUBLE)7,
795
+ (NETDATA_DOUBLE)0xFFFFFFFFFFFFFFFFULL / (NETDATA_DOUBLE)15,
796
+ (NETDATA_DOUBLE)0xFFFFFFFFFFFFFFFFULL / (NETDATA_DOUBLE)15 * (NETDATA_DOUBLE)7,
797
+ (NETDATA_DOUBLE)0xFFFFFFFFFFFFFFFFULL / (NETDATA_DOUBLE)15 * (NETDATA_DOUBLE)7,
798
+ (NETDATA_DOUBLE)0xFFFFFFFFFFFFFFFFULL / (NETDATA_DOUBLE)15,
799
+ (NETDATA_DOUBLE)0xFFFFFFFFFFFFFFFFULL / (NETDATA_DOUBLE)15 * (NETDATA_DOUBLE)7,
800
+ (NETDATA_DOUBLE)0xFFFFFFFFFFFFFFFFULL / (NETDATA_DOUBLE)15 * (NETDATA_DOUBLE)7,
801
+ (NETDATA_DOUBLE)0xFFFFFFFFFFFFFFFFULL / (NETDATA_DOUBLE)15,
802
};
803
804
struct test test5b = {
src/database/engine/rrdengine.c
+4
-4
@@ -139,12 +139,12 @@ static void sanity_check(void)
139
BUILD_BUG_ON(WORKER_UTILIZATION_MAX_JOB_TYPES < (RRDENG_OPCODE_MAX + 2));
140
141
/* Magic numbers must fit in the super-blocks */
142
- BUILD_BUG_ON(strlen(RRDENG_DF_MAGIC) > RRDENG_MAGIC_SZ);
143
- BUILD_BUG_ON(strlen(RRDENG_JF_MAGIC) > RRDENG_MAGIC_SZ);
142
+ BUILD_BUG_ON(sizeof(RRDENG_DF_MAGIC) - 1 > RRDENG_MAGIC_SZ);
143
+ BUILD_BUG_ON(sizeof(RRDENG_JF_MAGIC) - 1 > RRDENG_MAGIC_SZ);
144
145
/* Version strings must fit in the super-blocks */
146
- BUILD_BUG_ON(strlen(RRDENG_DF_VER) > RRDENG_VER_SZ);
147
- BUILD_BUG_ON(strlen(RRDENG_JF_VER) > RRDENG_VER_SZ);
146
+ BUILD_BUG_ON(sizeof(RRDENG_DF_VER) - 1 > RRDENG_VER_SZ);
147
+ BUILD_BUG_ON(sizeof(RRDENG_JF_VER) - 1 > RRDENG_VER_SZ);
148
149
/* Data file super-block cannot be larger than RRDENG_BLOCK_SIZE */
150
BUILD_BUG_ON(RRDENG_DF_SB_PADDING_SZ < 0);
src/database/rrdset.h
+2
@@ -172,6 +172,8 @@ struct rrdset {
172
struct {
173
#ifdef REPLICATION_TRACKING
174
REPLAY_WHO who;
175
+#else
176
+ uint8_t unused;
177
#endif
178
} rcv;
179
} stream;