do not update the legend if the legend is not present; fixes #2895
Costa Tsaousis (ktsaou) committed
Oct 19, 2017 at 10:12 UTC
d95557f7fb9f8feb48a42e0cf3beda8b496c221e
1 file changed
+11
-21
web/dashboard.js
+11
-21
@@ -3114,22 +3114,22 @@ var NETDATA = window.NETDATA || {};
3114
if(series.user !== null) series.user.innerText = s;
3115
};
3116
3117
- this.__legendSetDateString = function(date) {
3118
- if(date !== this.tmp.__last_shown_legend_date) {
3117
+ this.legendSetDateString = function(date) {
3118
+ if(this.element_legend_childs.title_date !== null && date !== this.tmp.__last_shown_legend_date) {
3119
this.element_legend_childs.title_date.innerText = date;
3120
this.tmp.__last_shown_legend_date = date;
3121
}
3122
};
3123
3124
- this.__legendSetTimeString = function(time) {
3125
- if(time !== this.tmp.__last_shown_legend_time) {
3124
+ this.legendSetTimeString = function(time) {
3125
+ if(this.element_legend_childs.title_time !== null && time !== this.tmp.__last_shown_legend_time) {
3126
this.element_legend_childs.title_time.innerText = time;
3127
this.tmp.__last_shown_legend_time = time;
3128
}
3129
};
3130
3131
this.legendSetUnitsString = function(units) {
3132
- if(units !== this.tmp.__last_shown_legend_units) {
3132
+ if(this.element_legend_childs.title_units !== null && units !== this.tmp.__last_shown_legend_units) {
3133
this.element_legend_childs.title_units.innerText = units;
3134
this.tmp.__last_shown_legend_units = units;
3135
}
@@ -3154,25 +3154,15 @@ var NETDATA = window.NETDATA || {};
3154
this.legendSetDateLast.time = NETDATA.dateTime.localeTimeString(d);
3155
}
3156
3157
- if(this.element_legend_childs.title_date !== null)
3158
- this.__legendSetDateString(this.legendSetDateLast.date);
3159
-
3160
- if(this.element_legend_childs.title_time !== null)
3161
- this.__legendSetTimeString(this.legendSetDateLast.time);
3162
-
3163
- if(this.element_legend_childs.title_units !== null)
3164
- this.legendSetUnitsString(this.units_current)
3157
+ this.legendSetDateString(this.legendSetDateLast.date);
3158
+ this.legendSetTimeString(this.legendSetDateLast.time);
3159
+ this.legendSetUnitsString(this.units_current)
3160
};
3161
3162
this.legendShowUndefined = function() {
3168
- if(this.element_legend_childs.title_date !== null)
3169
- this.__legendSetDateString(this.legendPluginModuleString(false));
3170
-
3171
- if(this.element_legend_childs.title_time !== null)
3172
- this.__legendSetTimeString(this.chart.context.toString());
3173
-
3174
- if(this.element_legend_childs.title_units !== null)
3175
- this.legendSetUnitsString(' ');
3163
+ this.legendSetDateString(this.legendPluginModuleString(false));
3164
+ this.legendSetTimeString(this.chart.context.toString());
3165
+ this.legendSetUnitsString(' ');
3166
3167
if(this.data && this.element_legend_childs.series !== null) {
3168
var labels = this.data.dimension_names;