fix(go.d/nvidia_smi): disable loop mode by default on Win (#19039)
Ilya Mashchenko committed
Nov 19, 2024 at 16:31 UTC
e474f06d2a00032b87c8b08f7986375a3ed3a927
1 file changed
+5
-2
src/go/plugin/go.d/modules/nvidia_smi/nvidia_smi.go
+5
-2
@@ -5,6 +5,7 @@ package nvidia_smi
5
import (
6
_ "embed"
7
"errors"
8
+ "runtime"
9
"time"
10
11
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
@@ -28,8 +29,10 @@ func init() {
29
func New() *NvidiaSmi {
30
return &NvidiaSmi{
31
Config: Config{
31
- Timeout: confopt.Duration(time.Second * 10),
32
- LoopMode: true,
32
+ Timeout: confopt.Duration(time.Second * 10),
33
+ // Disable loop mode on Windows due to go.d.plugin's non-graceful exit
34
+ // which can leave `nvidia_smi` processes running indefinitely.
35
+ LoopMode: !(runtime.GOOS == "windows"),
36
},
37
binName: "nvidia-smi",
38
charts: &module.Charts{},