@cryptotaxi247 / netdata-1 / commits / e8a12b3b1

Change the workflow on how we set the right permissions for perf-plugin (#16558)

* Change the workflow on how we set the right permissions Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud> * Add a failsafe in case fail to set the cap_perfmon Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud> * add EOF new line Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud> * Fix workflow Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud> * minor spelling Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud> * we made it odyssey Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud> * Apply suggestion from code review Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud> * Tidy-up postinst script. --------- Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud> Co-authored-by: Austin S. Hemmelgarn <austin@netdata.cloud>

Tasos Katsoulas committed Dec 11, 2023 at 16:03 UTC e8a12b3b1c8063b50dbff121741a5f6757d57052

1 file changed +4 -10

contrib/debian/netdata-plugin-perf.postinst

+4 -10

@@ -7,16 +7,10 @@ case "$1" in

7 chown root:netdata /usr/libexec/netdata/plugins.d/perf.plugin

8 chmod 0750 /usr/libexec/netdata/plugins.d/perf.plugin

10 - if capsh --supports=cap_perfmon 2>/dev/null; then

11 - setcap cap_perfmon+ep /usr/libexec/netdata/plugins.d/perf.plugin

12 - ret="$?"

13 - else

14 - setcap cap_sys_admin+ep /usr/libexec/netdata/plugins.d/perf.plugin

15 - ret="$?"

16 - fi

17 -

18 - if [ "${ret}" -ne 0 ]; then

19 - chmod -f 4750 /usr/libexec/netdata/plugins.d/perf.plugin

10 + if ! setcap cap_perfmon+ep /usr/libexec/netdata/plugins.d/perf.plugin 2>/dev/null; then

11 + if ! setcap cap_sys_admin+ep /usr/libexec/netdata/plugins.d/perf.plugin 2>/dev/null; then

12 + chmod -f 4750 /usr/libexec/netdata/plugins.d/perf.plugin

13 + fi

14 fi

15 ;;

16 esac