@cryptotaxi247 / netdata-1 / commits / f183dc8ae

Clean up YAML files in the repository. (#11570)

* Assorted yamllint config updates. * Extended line length limit to 150. This is still a reasonable limit but cuts down on warnings a bit. * Added explicit ignore directives for external repo paths. This makes using yamllint locally nicer. * Enabled the rule to require null values to be explicit. This rule helps prevent accidental bogus mapping problems resulting from implicit null values combined with incorrect indentation. This only results in new errors in a couple of GHA workflows, which will be fixed in the next commit. * Fix all yamllint warnings in yaml file sin the repo. Most are indentation or spurious empty lines. * Fix invalid null value.

Austin S. Hemmelgarn committed Sep 27, 2021 at 10:16 UTC f183dc8aead7d2e64eb97e169b89d6cc90d78aa5

18 files changed +36 -37

.codeclimate.yml

+5 -6

@@ -43,11 +43,11 @@ plugins:

43 enabled: false

44 config:

45 languages:

46 - - javascript:

47 - mass_threshold: 100

48 - - python:

49 - python_version: 3

50 - mass_threshold: 100

46 + - javascript:

47 + mass_threshold: 100

48 + - python:

49 + python_version: 3

50 + mass_threshold: 100

51 checks:

52 Similar code:

53 enabled: false

@@ -96,4 +96,3 @@ exclude_patterns:

96 - "collectors/node.d.plugin/node_modules/extend.js"

97 - "collectors/node.d.plugin/node_modules/pixl-xml.js"

98 - "collectors/node.d.plugin/node_modules/net-snmp.js"

99 -

.github/workflows/build-and-install.yml

+1 -1

@@ -4,7 +4,7 @@ on:

4 push:

5 branches:

6 - master

7 - pull_request:

7 + pull_request: null

8 env:

9 DO_NOT_TRACK: 1

10 jobs:

.github/workflows/checks.yml

+1 -1

@@ -4,7 +4,7 @@ on:

4 push:

5 branches:

6 - master

7 - pull_request:

7 + pull_request: null

8 env:

9 DO_NOT_TRACK: 1

10 jobs:

.github/workflows/coverity.yml

+1 -1

@@ -40,7 +40,7 @@ jobs:

40 uses: rtCamp/action-slack-notify@v2

41 env:

42 SLACK_COLOR: 'danger'

43 - SLACK_FOOTER:

43 + SLACK_FOOTER: ''

44 SLACK_ICON_EMOJI: ':github-actions:'

45 SLACK_TITLE: 'Coverity run failed:'

46 SLACK_USERNAME: 'GitHub Actions'

.github/workflows/docker.yml

+2 -2

@@ -4,7 +4,7 @@ on:

4 push:

5 branches:

6 - master

7 - pull_request:

7 + pull_request: null

8 workflow_dispatch:

9 inputs:

10 version:

@@ -99,7 +99,7 @@ jobs:

99 uses: rtCamp/action-slack-notify@v2

100 env:

101 SLACK_COLOR: 'danger'

102 - SLACK_FOOTER:

102 + SLACK_FOOTER: ''

103 SLACK_ICON_EMOJI: ':github-actions:'

104 SLACK_TITLE: 'Docker Build failed:'

105 SLACK_USERNAME: 'GitHub Actions'

.github/workflows/packaging.yml

-1

@@ -133,7 +133,6 @@ jobs:

133 uses: rtCamp/action-slack-notify@v2

134 env:

135 SLACK_COLOR: 'danger'

136 - SLACK_FOOTER:

136 SLACK_ICON_EMOJI: ':github-actions:'

137 SLACK_TITLE: 'Package Build failed:'

138 SLACK_USERNAME: 'GitHub Actions'

.github/workflows/repoconfig-packages.yml

+2 -2

@@ -2,7 +2,7 @@

2 # Handles building of binary packages for the agent.

3 name: Repository Packages

4 on:

5 - workflow_dispatch:

5 + workflow_dispatch: null

6 env:

7 DO_NOT_TRACK: 1

8 jobs:

@@ -60,7 +60,7 @@ jobs:

60 uses: rtCamp/action-slack-notify@v2

61 env:

62 SLACK_COLOR: 'danger'

63 - SLACK_FOOTER:

63 + SLACK_FOOTER: ''

64 SLACK_ICON_EMOJI: ':github-actions:'

65 SLACK_TITLE: 'Repository Package Build failed:'

66 SLACK_USERNAME: 'GitHub Actions'

.github/workflows/review.yml

+1 -1

@@ -2,7 +2,7 @@

2 # Runs various ReviewDog based checks against PR with suggested changes to improve quality

3 name: Review

4 on:

5 - pull_request:

5 + pull_request: null

6 env:

7 run_eslint: 0

8 run_hadolint: 0

.yamllint.yml

+10 -4

@@ -6,10 +6,11 @@ yaml-files:

6 - 'collectors/python.d.plugin/*.conf'

7 - 'collectors/python.d.plugin/*/*.conf'

9 +ignore: |

10 + mqtt_websockets/

11 + packaging/makeself/tmp/

12 +

13 rules:

10 - line-length:

11 - max: 120

12 - level: warning

14 braces: enable

15 brackets: enable

16 colons: enable

@@ -19,9 +20,14 @@ rules:

20 document-end: disable

21 document-start: disable

22 empty-lines: enable

22 - empty-values: disable

23 + empty-values: enable

24 hyphens: enable

25 indentation: enable

26 + line-length:

27 + max: 150

28 + level: warning

29 + allow-non-breakable-words: true

30 + allow-non-breakable-inline-mappings: true

31 key-duplicates: enable

32 key-ordering: disable

33 new-line-at-end-of-file: enable

build_external/scenarios/aclk-testing/agent-compose.yml

+3 -4

@@ -5,8 +5,8 @@ services:

5 context: ../../..

6 dockerfile: build_external/make-install.Dockerfile

7 args:

8 - - DISTRO=arch

9 - - VERSION=current

8 + - DISTRO=arch

9 + - VERSION=current

10 image: arch_current_dev:latest

11 command: >

12 sh -c "echo -n 00000000-0000-0000-0000-000000000000 >/var/lib/netdata/cloud.d/claimed_id &&

@@ -15,5 +15,4 @@ services:

15 echo ' agent cloud link port = 9002' >>/etc/netdata/netdata.conf &&

16 /usr/sbin/netdata -D"

17 ports:

18 - - 20000:19999

19 -

18 + - 20000:19999

build_external/scenarios/aclk-testing/agent-valgrind-compose.yml

+3 -4

@@ -5,8 +5,8 @@ services:

5 context: ../../..

6 dockerfile: build_external/make-install.Dockerfile

7 args:

8 - - DISTRO=arch

9 - - VERSION=extras

8 + - DISTRO=arch

9 + - VERSION=extras

10 image: arch_extras_dev:latest

11 command: >

12 sh -c "echo -n 00000000-0000-0000-0000-000000000000 >/var/lib/netdata/cloud.d/claimed_id &&

@@ -15,5 +15,4 @@ services:

15 echo ' agent cloud link port = 9002' >>/etc/netdata/netdata.conf &&

16 /usr/sbin/valgrind --leak-check=full /usr/sbin/netdata -D -W debug_flags=0x200000000"

17 ports:

18 - - 20000:19999

19 -

18 + - 20000:19999

build_external/scenarios/aclk-testing/paho-compose.yml

+1 -1

@@ -3,4 +3,4 @@ services:

3 paho_inspect:

4 build:

5 context: .

6 - dockerfile: paho.Dockerfile

\ No newline at end of file

6 + dockerfile: paho.Dockerfile

build_external/scenarios/aclk-testing/vernemq-compose.yml

-1

@@ -4,4 +4,3 @@ services:

4 build:

5 dockerfile: configureVerneMQ.Dockerfile

6 context: .

7 -

build_external/scenarios/gaps_hi/child-compose.yml

+1 -2

@@ -10,5 +10,4 @@ services:

10 #- ./child_guid:/var/lib/netdata/registry/netdata.public.unique.id:ro

11 - ./min.conf:/etc/netdata/netdata.conf:ro

12 cap_add:

13 - - SYS_PTRACE

14 -

13 + - SYS_PTRACE

build_external/scenarios/gaps_hi/middle-compose.yml

+1 -1

@@ -10,4 +10,4 @@ services:

10 - ./middle_guid:/var/lib/netdata/registry/netdata.public.unique.id:ro

11 - ./min.conf:/etc/netdata/netdata.conf:ro

12 cap_add:

13 - - SYS_PTRACE

13 + - SYS_PTRACE

build_external/scenarios/gaps_lo/child-compose.yml

-1

@@ -12,4 +12,3 @@ services:

12 - ./mostly_off.conf:/etc/netdata/netdata.conf:ro

13 cap_add:

14 - SYS_PTRACE

15 -

build_external/scenarios/only-agent/docker-compose.yml

+2 -2

@@ -4,5 +4,5 @@ services:

4 image: ${Distro}_${Version}_dev

5 command: /usr/sbin/netdata -D

6 ports:

7 - - 80

8 - - 443

7 + - 80

8 + - 443

web/api/netdata-swagger.yaml

+2 -2

@@ -456,7 +456,7 @@ paths:

456 required: false

457 allowEmptyValue: true

458 schema:

459 - oneOf:

459 + oneOf:

460 - type: string

461 enum:

462 - green

@@ -478,7 +478,7 @@ paths:

478 required: false

479 allowEmptyValue: true

480 schema:

481 - oneOf:

481 + oneOf:

482 - type: string

483 enum:

484 - green