@cryptotaxi247 / netdata-1 / commits / f239dc1fb

Remove assert (#16611)

Stelios Fragkakis committed Dec 14, 2023 at 20:55 UTC f239dc1fb76cb19f535796dcb96218107b16a250
2 files changed +5 -5
daemon/unit_test.c
+4 -4
@@ -2371,12 +2371,12 @@ void generate_dbengine_dataset(unsigned history_seconds)
2371 thread_info[i]->time_max = 0;
2372 thread_info[i]->done = 0;
2373 completion_init(&thread_info[i]->charts_initialized);
2374 - assert(0 == uv_thread_create(&thread_info[i]->thread, generate_dbengine_chart, thread_info[i]));
2374 + fatal_assert(0 == uv_thread_create(&thread_info[i]->thread, generate_dbengine_chart, thread_info[i]));
2375 completion_wait_for(&thread_info[i]->charts_initialized);
2376 completion_destroy(&thread_info[i]->charts_initialized);
2377 }
2378 for (i = 0 ; i < DSET_CHARTS ; ++i) {
2379 - assert(0 == uv_thread_join(&thread_info[i]->thread));
2379 + fatal_assert(0 == uv_thread_join(&thread_info[i]->thread));
2380 }
2381
2382 for (i = 0 ; i < DSET_CHARTS ; ++i) {
@@ -2578,7 +2578,7 @@ void dbengine_stress_test(unsigned TEST_DURATION_SEC, unsigned DSET_CHARTS, unsi
2578 chart_threads[i]->done = 0;
2579 chart_threads[i]->errors = chart_threads[i]->stored_metrics_nr = 0;
2580 completion_init(&chart_threads[i]->charts_initialized);
2581 - assert(0 == uv_thread_create(&chart_threads[i]->thread, generate_dbengine_chart, chart_threads[i]));
2581 + fatal_assert(0 == uv_thread_create(&chart_threads[i]->thread, generate_dbengine_chart, chart_threads[i]));
2582 }
2583 /* barrier so that subsequent queries can access valid chart data */
2584 for (i = 0 ; i < DSET_CHARTS ; ++i) {
@@ -2600,7 +2600,7 @@ void dbengine_stress_test(unsigned TEST_DURATION_SEC, unsigned DSET_CHARTS, unsi
2600 query_threads[i]->chart_threads[j] = chart_threads[j];
2601 }
2602 query_threads[i]->delete_old_data = DISK_SPACE_MB ? 1 : 0;
2603 - assert(0 == uv_thread_create(&query_threads[i]->thread, query_dbengine_chart, query_threads[i]));
2603 + fatal_assert(0 == uv_thread_create(&query_threads[i]->thread, query_dbengine_chart, query_threads[i]));
2604 }
2605 sleep(TEST_DURATION_SEC);
2606 /* stop workload */
database/sqlite/sqlite_metadata.c
+1 -1
@@ -1316,7 +1316,7 @@ static void start_all_host_load_context(uv_work_t *req __maybe_unused)
1316
1317 __atomic_store_n(&hclt[thread_index].busy, true, __ATOMIC_RELAXED);
1318 hclt[thread_index].host = host;
1319 - assert(0 == uv_thread_create(&hclt[thread_index].thread, restore_host_context, &hclt[thread_index]));
1319 + fatal_assert(0 == uv_thread_create(&hclt[thread_index].thread, restore_host_context, &hclt[thread_index]));
1320 }
1321 dfe_done(host);
1322