@cryptotaxi247 / netdata-1 / commits / f81d4d429

functions columns (#16184)

* make all columns wrap * do not show that many default columns on processes

Costa Tsaousis committed Oct 13, 2023 at 21:11 UTC f81d4d42902233dcf606d213a9c01ced6dce3284

2 files changed +13 -13

collectors/apps.plugin/apps_plugin.c

+11 -11

@@ -4799,13 +4799,13 @@ static void function_processes(const char *transaction, char *function __maybe_u

4799 RRDF_FIELD_VISUAL_BAR, RRDF_FIELD_TRANSFORM_NUMBER,

4800 2, "KiB/s", LReads_max, RRDF_FIELD_SORT_DESCENDING, NULL, RRDF_FIELD_SUMMARY_SUM,

4801 RRDF_FIELD_FILTER_RANGE,

4802 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4802 + RRDF_FIELD_OPTS_NONE, NULL);

4803 buffer_rrdf_table_add_field(wb, field_id++, "LWrites", "Logical I/O Writes", RRDF_FIELD_TYPE_BAR_WITH_INTEGER,

4804 RRDF_FIELD_VISUAL_BAR,

4805 RRDF_FIELD_TRANSFORM_NUMBER,

4806 2, "KiB/s", LWrites_max, RRDF_FIELD_SORT_DESCENDING, NULL, RRDF_FIELD_SUMMARY_SUM,

4807 RRDF_FIELD_FILTER_RANGE,

4808 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4808 + RRDF_FIELD_OPTS_NONE, NULL);

4809 #endif

4810

4811 // I/O calls

@@ -4813,12 +4813,12 @@ static void function_processes(const char *transaction, char *function __maybe_u

4813 RRDF_FIELD_VISUAL_BAR, RRDF_FIELD_TRANSFORM_NUMBER, 2,

4814 "calls/s", RCalls_max, RRDF_FIELD_SORT_DESCENDING, NULL, RRDF_FIELD_SUMMARY_SUM,

4815 RRDF_FIELD_FILTER_RANGE,

4816 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4816 + RRDF_FIELD_OPTS_NONE, NULL);

4817 buffer_rrdf_table_add_field(wb, field_id++, "WCalls", "I/O Write Calls", RRDF_FIELD_TYPE_BAR_WITH_INTEGER,

4818 RRDF_FIELD_VISUAL_BAR, RRDF_FIELD_TRANSFORM_NUMBER, 2,

4819 "calls/s", WCalls_max, RRDF_FIELD_SORT_DESCENDING, NULL, RRDF_FIELD_SUMMARY_SUM,

4820 RRDF_FIELD_FILTER_RANGE,

4821 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4821 + RRDF_FIELD_OPTS_NONE, NULL);

4822

4823 // minor page faults

4824 buffer_rrdf_table_add_field(wb, field_id++, "MinFlt", "Minor Page Faults/s", RRDF_FIELD_TYPE_BAR_WITH_INTEGER,

@@ -4856,7 +4856,7 @@ static void function_processes(const char *transaction, char *function __maybe_u

4856 RRDF_FIELD_TYPE_BAR_WITH_INTEGER, RRDF_FIELD_VISUAL_BAR,

4857 RRDF_FIELD_TRANSFORM_NUMBER, 2, "pgflts/s", TMajFlt_max, RRDF_FIELD_SORT_DESCENDING,

4858 NULL, RRDF_FIELD_SUMMARY_SUM, RRDF_FIELD_FILTER_RANGE,

4859 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4859 + RRDF_FIELD_OPTS_NONE, NULL);

4860

4861 // open file descriptors

4862 buffer_rrdf_table_add_field(wb, field_id++, "FDsLimitPercent", "Percentage of Open Descriptors vs Limits",

@@ -4868,24 +4868,24 @@ static void function_processes(const char *transaction, char *function __maybe_u

4868 RRDF_FIELD_TYPE_BAR_WITH_INTEGER, RRDF_FIELD_VISUAL_BAR,

4869 RRDF_FIELD_TRANSFORM_NUMBER, 0, "fds", FDs_max, RRDF_FIELD_SORT_DESCENDING, NULL,

4870 RRDF_FIELD_SUMMARY_SUM, RRDF_FIELD_FILTER_RANGE,

4871 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4871 + RRDF_FIELD_OPTS_NONE, NULL);

4872 buffer_rrdf_table_add_field(wb, field_id++, "Files", "Open Files", RRDF_FIELD_TYPE_BAR_WITH_INTEGER,

4873 RRDF_FIELD_VISUAL_BAR, RRDF_FIELD_TRANSFORM_NUMBER, 0,

4874 "fds",

4875 Files_max, RRDF_FIELD_SORT_DESCENDING, NULL, RRDF_FIELD_SUMMARY_SUM,

4876 RRDF_FIELD_FILTER_RANGE,

4877 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4877 + RRDF_FIELD_OPTS_NONE, NULL);

4878 buffer_rrdf_table_add_field(wb, field_id++, "Pipes", "Open Pipes", RRDF_FIELD_TYPE_BAR_WITH_INTEGER,

4879 RRDF_FIELD_VISUAL_BAR, RRDF_FIELD_TRANSFORM_NUMBER, 0,

4880 "fds",

4881 Pipes_max, RRDF_FIELD_SORT_DESCENDING, NULL, RRDF_FIELD_SUMMARY_SUM,

4882 RRDF_FIELD_FILTER_RANGE,

4883 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4883 + RRDF_FIELD_OPTS_NONE, NULL);

4884 buffer_rrdf_table_add_field(wb, field_id++, "Sockets", "Open Sockets", RRDF_FIELD_TYPE_BAR_WITH_INTEGER,

4885 RRDF_FIELD_VISUAL_BAR, RRDF_FIELD_TRANSFORM_NUMBER, 0,

4886 "fds", Sockets_max, RRDF_FIELD_SORT_DESCENDING, NULL, RRDF_FIELD_SUMMARY_SUM,

4887 RRDF_FIELD_FILTER_RANGE,

4888 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4888 + RRDF_FIELD_OPTS_NONE, NULL);

4889 buffer_rrdf_table_add_field(wb, field_id++, "iNotiFDs", "Open iNotify Descriptors",

4890 RRDF_FIELD_TYPE_BAR_WITH_INTEGER, RRDF_FIELD_VISUAL_BAR,

4891 RRDF_FIELD_TRANSFORM_NUMBER, 0, "fds", iNotiFDs_max, RRDF_FIELD_SORT_DESCENDING,

@@ -4922,12 +4922,12 @@ static void function_processes(const char *transaction, char *function __maybe_u

4922 RRDF_FIELD_VISUAL_BAR, RRDF_FIELD_TRANSFORM_NUMBER, 0,

4923 "processes", Processes_max, RRDF_FIELD_SORT_DESCENDING, NULL,

4924 RRDF_FIELD_SUMMARY_SUM, RRDF_FIELD_FILTER_RANGE,

4925 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4925 + RRDF_FIELD_OPTS_NONE, NULL);

4926 buffer_rrdf_table_add_field(wb, field_id++, "Threads", "Threads", RRDF_FIELD_TYPE_BAR_WITH_INTEGER,

4927 RRDF_FIELD_VISUAL_BAR, RRDF_FIELD_TRANSFORM_NUMBER, 0,

4928 "threads", Threads_max, RRDF_FIELD_SORT_DESCENDING, NULL, RRDF_FIELD_SUMMARY_SUM,

4929 RRDF_FIELD_FILTER_RANGE,

4930 - RRDF_FIELD_OPTS_VISIBLE, NULL);

4930 + RRDF_FIELD_OPTS_NONE, NULL);

4931 buffer_rrdf_table_add_field(wb, field_id++, "Uptime", "Uptime in seconds", RRDF_FIELD_TYPE_DURATION,

4932 RRDF_FIELD_VISUAL_BAR, RRDF_FIELD_TRANSFORM_DURATION_S, 2,

4933 "seconds", Uptime_max, RRDF_FIELD_SORT_DESCENDING, NULL, RRDF_FIELD_SUMMARY_MAX,

libnetdata/facets/facets.c

+2 -2

@@ -2246,7 +2246,7 @@ void facets_report(FACETS *facets, BUFFER *wb, DICTIONARY *used_hashes_registry)

2246 NULL,

2247 RRDF_FIELD_SUMMARY_COUNT,

2248 RRDF_FIELD_FILTER_RANGE,

2249 - RRDF_FIELD_OPTS_VISIBLE | RRDF_FIELD_OPTS_UNIQUE_KEY,

2249 + RRDF_FIELD_OPTS_WRAP | RRDF_FIELD_OPTS_VISIBLE | RRDF_FIELD_OPTS_UNIQUE_KEY,

2250 NULL);

2251

2252 buffer_rrdf_table_add_field(

@@ -2264,7 +2264,7 @@ void facets_report(FACETS *facets, BUFFER *wb, DICTIONARY *used_hashes_registry)

2264

2265 FACET_KEY *k;

2266 foreach_key_in_facets(facets, k) {

2267 - RRDF_FIELD_OPTIONS options = RRDF_FIELD_OPTS_NONE;

2267 + RRDF_FIELD_OPTIONS options = RRDF_FIELD_OPTS_WRAP;

2268 bool visible = k->options & (FACET_KEY_OPTION_VISIBLE | FACET_KEY_OPTION_STICKY);

2269

2270 if ((facets->options & FACETS_OPTION_ALL_FACETS_VISIBLE && k->values.enabled))