Stop submitting analytics (#20654)
* Stop submitting analytics in favor of agent events * Fix typo
Stelios Fragkakis committed
Jul 11, 2025 at 16:41 UTC
c546a70f075e55e3185ead7ea17962f0aee0e6a0
5 files changed
+1
-115
src/daemon/analytics.c
-97
@@ -660,9 +660,6 @@ void *analytics_main(void *ptr)
660
goto cleanup;
661
662
analytics_gather_mutable_meta_data();
663
-
664
- analytics_statistic_t statistic = { "META_START", "-", "-" };
665
- analytics_statistic_send(&statistic);
663
analytics_log_data();
664
665
sec = 0;
@@ -677,9 +674,6 @@ void *analytics_main(void *ptr)
674
continue;
675
676
analytics_gather_mutable_meta_data();
680
-
681
- analytics_statistic_t stt = { "META", "-", "-" };
682
- analytics_statistic_send(&stt);
677
analytics_log_data();
678
679
sec = 0;
@@ -858,12 +852,6 @@ void get_system_timezone(void)
852
}
853
}
854
861
-static bool analytics_script_exists(void) {
862
- char filename[FILENAME_MAX + 1];
863
- snprintfz(filename, sizeof(filename), "%s/anonymous-statistics.sh", netdata_configured_primary_plugins_dir);
864
- return access(filename, R_OK) == 0;
865
-}
866
-
855
bool analytics_check_enabled(void) {
856
if(!netdata_anonymous_statistics_enabled)
857
return false;
@@ -883,91 +871,6 @@ bool analytics_check_enabled(void) {
871
return netdata_anonymous_statistics_enabled;
872
}
873
886
-void analytics_statistic_send(const analytics_statistic_t *statistic) {
887
- if (!statistic || !statistic->action || !*statistic->action|| !analytics_check_enabled() || !analytics_script_exists())
888
- return;
889
-
890
- const char *action_result = statistic->result;
891
- const char *action_data = statistic->data;
892
-
893
- CLEAN_BUFFER *cmd = buffer_create(0, NULL);
894
- buffer_sprintf(
895
- cmd,
896
- "%s/anonymous-statistics.sh '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' '%s' ",
897
- netdata_configured_primary_plugins_dir,
898
- statistic->action,
899
- action_result ? action_result : "",
900
- action_data ? action_data : "",
901
- analytics_data.netdata_config_stream_enabled ? analytics_data.netdata_config_stream_enabled : "",
902
- analytics_data.netdata_config_memory_mode ? analytics_data.netdata_config_memory_mode : "",
903
- analytics_data.netdata_config_exporting_enabled ? analytics_data.netdata_config_exporting_enabled : "",
904
- analytics_data.netdata_exporting_connectors ? analytics_data.netdata_exporting_connectors : "",
905
- analytics_data.netdata_allmetrics_prometheus_used ? analytics_data.netdata_allmetrics_prometheus_used : "",
906
- analytics_data.netdata_allmetrics_shell_used ? analytics_data.netdata_allmetrics_shell_used : "",
907
- analytics_data.netdata_allmetrics_json_used ? analytics_data.netdata_allmetrics_json_used : "",
908
- analytics_data.netdata_dashboard_used ? analytics_data.netdata_dashboard_used : "",
909
- analytics_data.netdata_collectors ? analytics_data.netdata_collectors : "",
910
- analytics_data.netdata_collectors_count ? analytics_data.netdata_collectors_count : "",
911
- analytics_data.netdata_buildinfo ? analytics_data.netdata_buildinfo : "",
912
- analytics_data.netdata_config_page_cache_size ? analytics_data.netdata_config_page_cache_size : "",
913
- analytics_data.netdata_config_multidb_disk_quota ? analytics_data.netdata_config_multidb_disk_quota : "",
914
- analytics_data.netdata_config_https_enabled ? analytics_data.netdata_config_https_enabled : "",
915
- analytics_data.netdata_config_web_enabled ? analytics_data.netdata_config_web_enabled : "",
916
- analytics_data.netdata_config_release_channel ? analytics_data.netdata_config_release_channel : "",
917
- analytics_data.netdata_mirrored_host_count ? analytics_data.netdata_mirrored_host_count : "",
918
- analytics_data.netdata_mirrored_hosts_reachable ? analytics_data.netdata_mirrored_hosts_reachable : "",
919
- analytics_data.netdata_mirrored_hosts_unreachable ? analytics_data.netdata_mirrored_hosts_unreachable : "",
920
- analytics_data.netdata_notification_methods ? analytics_data.netdata_notification_methods : "",
921
- analytics_data.netdata_alarms_normal ? analytics_data.netdata_alarms_normal : "",
922
- analytics_data.netdata_alarms_warning ? analytics_data.netdata_alarms_warning : "",
923
- analytics_data.netdata_alarms_critical ? analytics_data.netdata_alarms_critical : "",
924
- analytics_data.netdata_charts_count ? analytics_data.netdata_charts_count : "",
925
- analytics_data.netdata_metrics_count ? analytics_data.netdata_metrics_count : "",
926
- analytics_data.netdata_config_is_parent ? analytics_data.netdata_config_is_parent : "",
927
- analytics_data.netdata_config_hosts_available ? analytics_data.netdata_config_hosts_available : "",
928
- analytics_data.netdata_host_cloud_available ? analytics_data.netdata_host_cloud_available : "",
929
- analytics_data.netdata_host_aclk_available ? analytics_data.netdata_host_aclk_available : "",
930
- analytics_data.netdata_host_aclk_protocol ? analytics_data.netdata_host_aclk_protocol : "",
931
- analytics_data.netdata_host_aclk_implementation ? analytics_data.netdata_host_aclk_implementation : "",
932
- analytics_data.netdata_host_agent_claimed ? analytics_data.netdata_host_agent_claimed : "",
933
- analytics_data.netdata_host_cloud_enabled ? analytics_data.netdata_host_cloud_enabled : "",
934
- analytics_data.netdata_config_https_available ? analytics_data.netdata_config_https_available : "",
935
- analytics_data.netdata_install_type ? analytics_data.netdata_install_type : "",
936
- analytics_data.netdata_config_is_private_registry ? analytics_data.netdata_config_is_private_registry : "",
937
- analytics_data.netdata_config_use_private_registry ? analytics_data.netdata_config_use_private_registry : "",
938
- analytics_data.netdata_config_oom_score ? analytics_data.netdata_config_oom_score : "",
939
- analytics_data.netdata_prebuilt_distro ? analytics_data.netdata_prebuilt_distro : "",
940
- analytics_data.netdata_fail_reason ? analytics_data.netdata_fail_reason : ""
941
- );
942
-
943
- nd_log(NDLS_DAEMON, NDLP_DEBUG,
944
- "%s/anonymous-statistics.sh '%s' '%s' '%s'",
945
- netdata_configured_primary_plugins_dir, statistic->action,
946
- action_result ? action_result : "", action_data ? action_data : "");
947
-
948
- POPEN_INSTANCE *instance = spawn_popen_run(buffer_tostring(cmd));
949
- if (instance) {
950
- char buffer[4 + 1];
951
- char *s = fgets(buffer, 4, spawn_popen_stdout(instance));
952
- int exit_code = spawn_popen_wait(instance);
953
- if (exit_code)
954
-
955
- nd_log(NDLS_DAEMON, NDLP_NOTICE,
956
- "Statistics script returned error: %d",
957
- exit_code);
958
-
959
- if (s && strncmp(buffer, "200", 3) != 0)
960
- nd_log(NDLS_DAEMON, NDLP_NOTICE,
961
- "Statistics script returned http code: %s",
962
- buffer);
963
-
964
- }
965
- else
966
- nd_log(NDLS_DAEMON, NDLP_NOTICE,
967
- "Failed to run statistics script: %s/anonymous-statistics.sh",
968
- netdata_configured_primary_plugins_dir);
969
-}
970
-
874
void analytics_reset(void) {
875
analytics_data.data_length = 0;
876
analytics_set_data(&analytics_data.netdata_config_stream_enabled, "null");
src/daemon/main.c
-11
@@ -1119,17 +1119,6 @@ int netdata_main(int argc, char **argv) {
1119
else // collect data but do not send it (needed in /api/v1/info)
1120
delta_startup_time("anonymous analytics (disabled)");
1121
1122
- analytics_statistic_t start_statistic = {"START", "-", "-"};
1123
- analytics_statistic_send(&start_statistic);
1124
- if (daemon_status_file_has_last_crashed(NULL)) {
1125
- analytics_statistic_t crash_statistic = {"CRASH", "-", "-"};
1126
- analytics_statistic_send(&crash_statistic);
1127
- }
1128
- if (daemon_status_file_was_incomplete_shutdown()) {
1129
- analytics_statistic_t incomplete_shutdown_statistic = {"INCOMPLETE_SHUTDOWN", "-", "-"};
1130
- analytics_statistic_send(&incomplete_shutdown_statistic);
1131
- }
1132
-
1122
// check if ANALYTICS needs to start
1123
for (i = 0; static_threads[i].name != NULL; i++) {
1124
if (!strncmp(static_threads[i].name, "ANALYTICS", 9)) {
src/database/sqlite/sqlite_aclk.c
+1
-1
@@ -1025,7 +1025,7 @@ void aclk_synchronization_shutdown(void)
1025
if (!aclk_sync_config.thread)
1026
return;
1027
1028
- // Send shutdown command, not that the completion is initialized
1028
+ // Send shutdown command, note that the completion is initialized
1029
// on init and still valid
1030
aclk_mqtt_client_reset();
1031
src/exporting/exporting_engine.c
-3
@@ -196,9 +196,6 @@ void *exporting_main(void *ptr)
196
197
if (init_connectors(engine) != 0) {
198
netdata_log_error("EXPORTING: cannot initialize exporting connectors");
199
-
200
- analytics_statistic_t statistic = { "EXPORTING_START", "FAIL", "-" };
201
- analytics_statistic_send(&statistic);
199
goto cleanup;
200
}
201
src/exporting/init_connectors.c
-3
@@ -111,9 +111,6 @@ int init_connectors(struct engine *engine)
111
instance->exited = 1;
112
return 1;
113
}
114
-
115
- analytics_statistic_t statistic = { "EXPORTING_START", "OK", instance->config.type_name };
116
- analytics_statistic_send(&statistic);
114
}
115
116
return 0;