@devries-cameron20 / composio-1 / commits / 10b914fd4
Fork 0

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

docs(connected-accounts): drop residual internal references

Final sweep caught three more spots leaking internal detail: - `CreateConnectedAccountLinkOptionsSchema.aclConfigForShared` JSDoc said "the backend rejects ACL on a PRIVATE connection". Replaced with "raises ComposioAclOnlyForSharedError on a PRIVATE connection" — describes the SDK contract from the caller's perspective. - `UpdateConnectedAccountAclParamsSchema` JSDoc had a parallel "Backend rejects ACL writes on a PRIVATE connection" sentence. Reworded the same way. - Test comment in toolRouter.test.ts had a "Bugbot-flagged gap" annotation referencing internal review tooling. Replaced with a neutral description of what the tests verify. No behaviour changes — JSDoc / comment cleanup only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

venkat82 committed May 12, 2026 at 01:26 UTC 10b914fd43f663dd83407ff8fe7ce1f81cdff2e9
2 files changed +6 -7
ts/packages/core/src/types/connectedAccounts.types.ts
+4 -4
@@ -302,8 +302,8 @@ export const CreateConnectedAccountLinkOptionsSchema = z.object({
302 accountType: ConnectedAccountTypeSchema.optional(),
303 /**
304 * Per-user ACL for SHARED connections. Only valid when
305 - * `accountType === 'SHARED'` — the backend rejects ACL on a PRIVATE
306 - * connection with `ComposioAclOnlyForSharedError` (400).
305 + * `accountType === 'SHARED'`; raises `ComposioAclOnlyForSharedError`
306 + * on a PRIVATE connection.
307 *
308 * Omit the block (or pass `{}`) to keep the deny-by-default state: only the
309 * creator can use the connection. Grant access by setting
@@ -342,8 +342,8 @@ export const UpdateConnectedAccountParamsSchema = z.object({
342 * outer nesting at the boundary, so callers pass the three fields flat.
343 *
344 * PATCH-style semantics — omit a field to leave it unchanged; pass an
345 - * empty array to clear an allow/deny list. Backend rejects ACL writes on
346 - * a PRIVATE connection with `ComposioAclOnlyForSharedError` (400).
345 + * empty array to clear an allow/deny list. Raises
346 + * `ComposioAclOnlyForSharedError` on a PRIVATE connection.
347 *
348 * Each field is optional, but at least one must be provided — passing an
349 * empty object is rejected as a no-op.
ts/packages/core/test/models/toolRouter.test.ts
+2 -3
@@ -1849,9 +1849,8 @@ describe('ToolRouter', () => {
1849 expect(typeof connectionRequest.waitForConnection).toBe('function');
1850 });
1851
1852 - // Bugbot-flagged gap: authorize() was passing aclConfigForShared straight
1853 - // to the wire while link() validated through Zod. These tests pin the
1854 - // parity — same 1000-entry list cap, same 256-char user_id cap.
1852 + // authorize() validates aclConfigForShared at the SDK boundary, same
1853 + // caps as link() — 1000-entry list, 256-char user_id.
1854 it('forwards accountType + nested acl_config_for_shared on the wire', async () => {
1855 mockClient.toolRouter.session.link.mockResolvedValueOnce(mockLinkResponse);
1856