496
result = triggers.subscribe(timeout=20.0)
497
498
mock_builder_class.assert_called_once_with(client=mock_client)
499
- mock_builder.connect.assert_called_once_with(timeout=20.0)
499
+ mock_builder.connect.assert_called_once_with(
500
+ timeout=20.0, on_subscription_error=None
501
+ )
502
assert result == mock_subscription
503
504
def test_subscribe_with_default_timeout(self, triggers, mock_client):
513
514
result = triggers.subscribe()
515
514
- mock_builder.connect.assert_called_once_with(timeout=15.0)
516
+ mock_builder.connect.assert_called_once_with(
517
+ timeout=15.0, on_subscription_error=None
518
+ )
519
+ assert result == mock_subscription
520
+
521
+ def test_subscribe_passes_subscription_error_callback(self, triggers, mock_client):
522
+ """The optional on_subscription_error callback reaches the builder."""
523
+ with patch(
524
+ "composio.core.models.triggers._SubcriptionBuilder"
525
+ ) as mock_builder_class:
526
+ mock_builder = Mock()
527
+ mock_subscription = Mock()
528
+ mock_builder.connect.return_value = mock_subscription
529
+ mock_builder_class.return_value = mock_builder
530
+ on_subscription_error = Mock()
531
+
532
+ result = triggers.subscribe(
533
+ timeout=5.0, on_subscription_error=on_subscription_error
534
+ )
535
+
536
+ mock_builder.connect.assert_called_once_with(
537
+ timeout=5.0, on_subscription_error=on_subscription_error
538
+ )
539
assert result == mock_subscription
540
541
1819
pusher.disconnect.assert_not_called()
1820
1821
1822
+class TestSubscriptionErrorHandler:
1823
+ """Tests for TriggerSubscription._handle_subscription_error."""
1824
+
1825
+ @pytest.fixture
1826
+ def subscription(self):
1827
+ """Create a TriggerSubscription with a mock client."""
1828
+ return TriggerSubscription(client=Mock())
1829
+
1830
+ def test_invokes_callback_with_parsed_payload(self, subscription):
1831
+ """The callback receives the subscription error payload as a dict."""
1832
+ callback = Mock()
1833
+ subscription._on_subscription_error = callback
1834
+
1835
+ subscription._handle_subscription_error('{"type": "AuthError", "status": 401}')
1836
+
1837
+ callback.assert_called_once_with({"type": "AuthError", "status": 401})
1838
+
1839
+ def test_malformed_frame_reaches_callback_as_raw(self, subscription):
1840
+ """A non-JSON frame is logged, not raised, and passed as ``{'raw': ...}``."""
1841
+ callback = Mock()
1842
+ subscription._on_subscription_error = callback
1843
+
1844
+ subscription._handle_subscription_error("not valid json {")
1845
+
1846
+ callback.assert_called_once_with({"raw": "not valid json {"})
1847
+
1848
+ def test_callback_exception_is_contained(self, subscription):
1849
+ """A faulty handler is logged, never rethrown into pysher's thread."""
1850
+ subscription._on_subscription_error = Mock(side_effect=RuntimeError("boom"))
1851
+
1852
+ subscription._handle_subscription_error('{"error": "auth failed"}')
1853
+
1854
+ def test_no_callback_is_a_no_op(self, subscription):
1855
+ """Without a registered callback the frame is only logged."""
1856
+ subscription._handle_subscription_error('{"error": "auth failed"}')
1857
+
1858
+ def test_connection_handler_binds_subscription_error(self):
1859
+ """The builder binds ``pusher:subscription_error`` to the handler."""
1860
+ client = Mock()
1861
+ client.base_url = "https://api.example.com"
1862
+ builder = _SubcriptionBuilder(client=client)
1863
+ channel = Mock()
1864
+ pusher = Mock()
1865
+ pusher.subscribe.return_value = channel
1866
+
1867
+ handler = builder._get_connection_handler(
1868
+ project_id="p", pusher=pusher, subscription=builder.subscription
1869
+ )
1870
+ handler("connection-payload")
1871
+
1872
+ bound = {
1873
+ call.kwargs["event_name"]: call.kwargs["callback"]
1874
+ for call in channel.bind.call_args_list
1875
+ }
1876
+ assert (
1877
+ bound["pusher:subscription_error"]
1878
+ == builder.subscription._handle_subscription_error
1879
+ )
1880
+ assert bound["trigger_to_client"] == builder.subscription._handle_event
1881
+ assert (
1882
+ bound["chunked-trigger_to_client"]
1883
+ == builder.subscription._handle_chunked_events
1884
+ )
1885
+
1886
+
1887
class TestPusherChannelAuth:
1888
"""Tests for the hardened pysher channel-auth request."""
1889