@devries-cameron20 / composio-1 / commits / 74a58c85a
Fork 0

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

fix(release): reserve GitHub Releases for CLI binaries (#5067)

Private examples and E2E workspaces were creating Git tags and GitHub Releases during SDK publication. Disable private tagging while retaining private version updates, and disable GitHub Release creation in the SDK workflow. Public SDK tags and npm publication remain enabled; the CLI binary workflow owns GitHub Releases. Regression: an isolated fixture runs the real Changesets version/tag commands. Before the fix it creates private example/test tags; after the fix only the public SDK update is tagged, private versions still advance, and an existing private tag survives. The fixture also passes with global/system Git config disabled. Validation: pnpm test:release-workflow, focused Oxlint, Prettier, both agent-guidance validators, shell syntax, workflow syntax validation, and git diff --check passed. Full actionlint reports an existing SC2295 shellcheck finding in unchanged version-notification code; the base has the same finding. Independent review caught and resolved fixture Git-identity portability. Follow-up operation: remove the 414 historical test/example GitHub Releases after this fix lands on stable and beta branches. Preserve Git tags and existing SDK/CLI releases. Review the full diff before submitting.

Alberto Schiabel committed Oct 22, 2026 at 17:15 UTC 74a58c85a4fc840ca1d378138623fe21f47a7ebb
4 files changed +84 -5
.changeset/config.json
+1 -1
@@ -7,7 +7,7 @@
7 "access": "restricted",
8 "privatePackages": {
9 "version": true,
10 - "tag": true
10 + "tag": false
11 },
12 "baseBranch": "next",
13 "updateInternalDependencies": "patch",
.github/workflows/ts.release.yml
+3
@@ -64,6 +64,9 @@ jobs:
64 if: github.event_name != 'workflow_dispatch' # only run on master merges
65 with:
66 github-token: ${{ steps.app-token.outputs.token }}
67 + # SDKs publish to npm. The CLI binary workflow owns GitHub Releases.
68 + create-github-releases: false
69 + push-git-tags: true
70 publish-script: pnpm changeset:release
71 commit-message: 'Release: update version'
72 pr-title: 'Release: update version'
test/release-workflow.test.ts
+77
@@ -1110,6 +1110,83 @@ esac
1110 rmSync(fakeBin, { recursive: true, force: true });
1111 }
1112
1113 +// Private workspaces still receive version bumps, but must never get release tags.
1114 +{
1115 + const fixtureDir = mkdtempSync(join(tmpdir(), 'composio-private-release-'));
1116 + const packages = [
1117 + { directory: 'sdk', name: '@composio/core', private: false },
1118 + { directory: 'example', name: 'release-example', private: true },
1119 + { directory: 'test', name: '@e2e-tests/release', private: true },
1120 + ];
1121 + try {
1122 + mkdirSync(join(fixtureDir, '.changeset'), { recursive: true });
1123 + writeFileSync(
1124 + join(fixtureDir, 'package.json'),
1125 + JSON.stringify({ name: 'private-release-fixture', private: true, workspaces: ['packages/*'] })
1126 + );
1127 + writeFileSync(join(fixtureDir, 'pnpm-workspace.yaml'), "packages:\n - 'packages/*'\n");
1128 + writeFileSync(
1129 + join(fixtureDir, '.changeset/config.json'),
1130 + JSON.stringify({ ...changesetConfig, changelog: false, fixed: [], ignore: [] })
1131 + );
1132 + writeFileSync(
1133 + join(fixtureDir, '.changeset/release.md'),
1134 + ['---', ...packages.map(pkg => `"${pkg.name}": patch`), '---', '', 'Release fixture.'].join(
1135 + '\n'
1136 + )
1137 + );
1138 + for (const pkg of packages) {
1139 + const directory = join(fixtureDir, 'packages', pkg.directory);
1140 + mkdirSync(directory, { recursive: true });
1141 + writeFileSync(
1142 + join(directory, 'package.json'),
1143 + JSON.stringify({ name: pkg.name, version: '0.1.0', private: pkg.private })
1144 + );
1145 + }
1146 + const commands = [
1147 + [changesetBinPath, ['version']],
1148 + ['git', ['init', '--quiet', '--initial-branch=next']],
1149 + ['git', ['config', 'user.name', 'Release test']],
1150 + ['git', ['config', 'user.email', 'release-test@example.invalid']],
1151 + ['git', ['add', '.']],
1152 + ['git', ['commit', '-qm', 'Prepare fixture']],
1153 + ['git', ['tag', '@e2e-tests/release@0.1.0']],
1154 + [changesetBinPath, ['tag']],
1155 + ] as const;
1156 + for (const [command, args] of commands) {
1157 + const result = spawnSync(command, args, { cwd: fixtureDir, encoding: 'utf8' });
1158 + if (result.status !== 0) {
1159 + throw new Error(
1160 + `private release fixture failed: ${command} ${args.join(' ')}\n${result.stderr}`
1161 + );
1162 + }
1163 + }
1164 + for (const pkg of packages) {
1165 + const manifest = JSON.parse(
1166 + readFileSync(join(fixtureDir, 'packages', pkg.directory, 'package.json'), 'utf8')
1167 + );
1168 + if (manifest.version !== '0.1.1') {
1169 + throw new Error(`release must still version ${pkg.name}, got ${manifest.version}`);
1170 + }
1171 + }
1172 + const tags = spawnSync('git', ['tag', '--list'], { cwd: fixtureDir, encoding: 'utf8' });
1173 + if (
1174 + tags.status !== 0 ||
1175 + tags.stdout.trim() !== '@composio/core@0.1.1\n@e2e-tests/release@0.1.0'
1176 + ) {
1177 + throw new Error(
1178 + `release must tag only public SDK updates and preserve existing tags, got:\n${tags.stdout}`
1179 + );
1180 + }
1181 + } finally {
1182 + rmSync(fixtureDir, { recursive: true, force: true });
1183 + }
1184 +}
1185 +
1186 +if (!tsReleaseWorkflow.includes('create-github-releases: false')) {
1187 + throw new Error('SDK publication must not create GitHub Releases; the CLI workflow owns them');
1188 +}
1189 +
1190 // A core minor release must not force every provider package to 1.0.0 while the
1191 // provider peer range still accepts the new core version. This protects the
1192 // @composio/core 0.10.0 → 0.11.0 release train from accidentally promoting
ts/scripts/changeset-release.sh
+3 -4
@@ -2,10 +2,9 @@
2 set -euo pipefail
3
4 # changesets/action v2 reads Changesets v3's NDJSON events from
5 -# CHANGESETS_OUTPUT. The CLI binary workflow owns @composio/cli GitHub Releases
6 -# because those releases must include platform binary assets. Remove only that
7 -# package's git-tag event so changesets/action publishes and releases every
8 -# other package without creating an empty @composio/cli GitHub Release.
5 +# CHANGESETS_OUTPUT. Keep @composio/cli tags owned by the CLI binary workflow.
6 +# Public SDK package tags still accompany npm publication; the SDK workflow
7 +# disables GitHub Release creation, and Changesets does not tag private packages.
8
9 filtered_output_file=$(mktemp)
10 trap 'rm -f "$filtered_output_file"' EXIT