@devries-cameron20 / composio-1 / commits / 7d36de8c0
Fork 0

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

fix(python-sdk): isolate default provider per Composio instance (#4370)

Construct a fresh OpenAIProvider per SDK instance instead of sharing a module-level singleton whose execute_tool binding was overwritten by the last-constructed instance, silently routing tool execution through the wrong client/API key. Regression test in tests/test_sdk.py. Fixes #4369 Co-authored-by: Adesh Deshmukh <adeshkd123@gmail.com> Claude-Session: https://claude.ai/code/session_015YPz5SzeScR9TkgoRi2p1F EOF -R ComposioHQ/composio

Adesh Deshmukh committed Sep 8, 2026 at 17:03 UTC 7d36de8c0ae9aba5b87aae156ecd568e99f2feef
2 files changed +30 -5
python/composio/sdk.py
+3 -5
@@ -28,8 +28,6 @@ from composio.core.types import ToolkitVersionParam
28 from composio.utils.logging import WithLogger
29 from composio.utils.toolkit_version import get_toolkit_versions
30
31 -_DEFAULT_PROVIDER = OpenAIProvider()
32 -
31
32 class SDKConfig(te.TypedDict):
33 environment: te.NotRequired[APIEnvironment]
@@ -130,11 +128,11 @@ class Composio(t.Generic[TTool, TToolCollection], WithLogger):
128 if not api_key:
129 raise exceptions.ApiKeyNotProvidedError()
130
133 - # Use default provider if none provided
134 - # Cast to BaseProvider[TTool, TToolCollection] for type consistency
131 + # Each instance gets its own provider so that the execute_tool_fn binding
132 + # performed by Tools.__init__ cannot leak across SDK instances (issue #4369).
133 actual_provider: BaseProvider[TTool, TToolCollection] = t.cast(
134 BaseProvider[TTool, TToolCollection],
137 - provider if provider is not None else _DEFAULT_PROVIDER,
135 + provider if provider is not None else OpenAIProvider(),
136 )
137
138 # Process toolkit versions with environment variable support
python/tests/test_sdk.py
+27
@@ -6,6 +6,7 @@ from unittest.mock import patch
6 import pytest
7
8 from composio import Composio, exceptions
9 +from composio.core.provider._openai import OpenAIProvider
10 from composio.core.types import ToolkitVersionParam
11
12
@@ -110,6 +111,32 @@ class TestComposioSDK:
111 assert sdk.provider is not None
112 assert hasattr(sdk.provider, "name")
113
114 + def test_default_provider_is_isolated_per_instance(self):
115 + """Regression test for #4369.
116 +
117 + The default provider used to be a module-level singleton. Because every
118 + ``Tools`` instance rebinds ``provider.execute_tool`` to itself, the last
119 + constructed ``Composio()`` silently took over tool execution for every
120 + other instance, routing calls through the wrong API key.
121 + """
122 + sdk_a = Composio(api_key="key-a")
123 + sdk_b = Composio(api_key="key-b")
124 +
125 + assert isinstance(sdk_a.provider, OpenAIProvider)
126 + assert isinstance(sdk_b.provider, OpenAIProvider)
127 + assert sdk_a.provider is not sdk_b.provider
128 +
129 + # execute_tool is a functools.partial over Tools.execute; each provider
130 + # must stay bound to the Tools of the instance that created it.
131 + assert sdk_a.provider.execute_tool.func.__self__ is sdk_a.tools
132 + assert sdk_b.provider.execute_tool.func.__self__ is sdk_b.tools
133 +
134 + def test_explicit_provider_is_used_unchanged(self):
135 + """An explicitly passed provider instance is used as-is."""
136 + provider = OpenAIProvider()
137 + sdk = Composio(provider=provider, api_key="key-a")
138 + assert sdk.provider is provider
139 +
140 def test_toolkit_versions_processing(self):
141 """Test toolkit versions parameter processing."""
142 with patch.dict(os.environ, {"COMPOSIO_API_KEY": "test-key"}):