@devries-cameron20 / composio-1 / commits / 9afe5a7f8
Fork 0

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

test(cli): deduplicate harness env setup and the SIGTERM download scenario

jkomyno committed Aug 3, 2026 at 20:28 UTC 9afe5a7f813906f2087fd6c41b4bf5021fbdf5c5
1 file changed +53 -52
test/install-sh-release-resolution.test.sh
+53 -52
@@ -293,6 +293,30 @@ EOF
293 : >"$composio_log"
294 }
295
296 + # Env assignments shared by run_installer and run_variant. Emitted into
297 + # common_env_args; each runner appends its own entry-point-specific overrides.
298 + common_env() {
299 + local home=$1
300 + local install_dir=$2
301 + local bin_dir=$3
302 + common_env_args=(
303 + HOME="$home"
304 + COMPOSIO_INSTALL_DIR="$install_dir"
305 + COMPOSIO_BIN_DIR="$bin_dir"
306 + COMPOSIO_INSTALL_PLUGINS="${CASE_PLUGINS:-0}"
307 + COMPOSIO_GITHUB_URL="${CASE_GITHUB_URL:-$github_url}"
308 + COMPOSIO_GITHUB_API_BASE_URL="${CASE_API_BASE:-$api_base}"
309 + COMPOSIO_GITHUB_OWNER=FakeOwner
310 + COMPOSIO_GITHUB_REPO=fake-repo
311 + TEST_CHECKSUM_MODE="${CASE_CHECKSUM_MODE:-missing}"
312 + TEST_SHELL_CAPABILITY="${CASE_SHELL_CAPABILITY:-supported}"
313 + TEST_INSTALL_EXIT="${CASE_INSTALL_EXIT:-0}"
314 + TEST_CURL_DELAY_URL="${CASE_CURL_DELAY_URL:-}"
315 + TEST_CURL_DELAY_SECONDS="${CASE_CURL_DELAY_SECONDS:-1}"
316 + TEST_CURL_PARENT_PID_FILE="$case_root/curl-parent.pid"
317 + )
318 + }
319 +
320 run_installer() {
321 local home=$1
322 local install_dir=$2
@@ -303,33 +327,21 @@ EOF
327 if [[ ${CASE_UNSET_SHELL:-0} == 1 ]]; then
328 installer_command=("$interpreter" -c 'unset SHELL; script=$1; shift; . "$script"' unset-shell "$repo_root/install.sh")
329 fi
330 + common_env "$home" "$install_dir" "$bin_dir"
331 env \
332 PATH="${CASE_PATH_PREFIX:-}$fake_bin:$PATH" \
308 - HOME="$home" \
333 SHELL=/bin/bash \
310 - COMPOSIO_INSTALL_DIR="$install_dir" \
311 - COMPOSIO_BIN_DIR="$bin_dir" \
334 + "${common_env_args[@]}" \
335 COMPOSIO_INSTALL_VERSION="${CASE_INSTALL_VERSION:-}" \
336 COMPOSIO_INSTALL_SHELL="${CASE_INSTALL_SHELL:-}" \
314 - COMPOSIO_INSTALL_PLUGINS="${CASE_PLUGINS:-0}" \
337 COMPOSIO_QUIET="${CASE_QUIET:-0}" \
338 COMPOSIO_DEBUG="${CASE_DEBUG:-0}" \
339 COMPOSIO_INSTALL_HELP="${CASE_HELP:-1}" \
340 COMPOSIO_INSTALL_ALLOW_HTTP_HOST="${CASE_ALLOW_HTTP_HOST:-}" \
319 - COMPOSIO_GITHUB_URL="${CASE_GITHUB_URL:-$github_url}" \
320 - COMPOSIO_GITHUB_API_BASE_URL="${CASE_API_BASE:-$api_base}" \
321 - COMPOSIO_GITHUB_OWNER=FakeOwner \
322 - COMPOSIO_GITHUB_REPO=fake-repo \
323 - TEST_CHECKSUM_MODE="${CASE_CHECKSUM_MODE:-missing}" \
341 TEST_API_ASSET_URL="${CASE_API_ASSET_URL:-}" \
342 TEST_REDIRECT_DOWNGRADE="${CASE_REDIRECT_DOWNGRADE:-0}" \
326 - TEST_SHELL_CAPABILITY="${CASE_SHELL_CAPABILITY:-supported}" \
327 - TEST_INSTALL_EXIT="${CASE_INSTALL_EXIT:-0}" \
343 TEST_SETUP_EXIT="${CASE_SETUP_EXIT:-0}" \
344 TEST_VERSION_EXIT="${CASE_VERSION_EXIT:-0}" \
330 - TEST_CURL_DELAY_URL="${CASE_CURL_DELAY_URL:-}" \
331 - TEST_CURL_DELAY_SECONDS="${CASE_CURL_DELAY_SECONDS:-1}" \
332 - TEST_CURL_PARENT_PID_FILE="$case_root/curl-parent.pid" \
345 "${installer_command[@]}" "$@"
346 }
347
@@ -340,25 +352,13 @@ EOF
352 local bin_dir=$4
353 shift 4
354 mkdir -p "$home" "$install_dir" "$bin_dir"
355 + common_env "$home" "$install_dir" "$bin_dir"
356 env \
357 PATH="$fake_bin:$PATH" \
345 - HOME="$home" \
358 SHELL="/bin/$shell_name" \
347 - COMPOSIO_INSTALL_DIR="$install_dir" \
348 - COMPOSIO_BIN_DIR="$bin_dir" \
359 + "${common_env_args[@]}" \
360 COMPOSIO_INSTALL_SCRIPT_URL="$script_url" \
350 - COMPOSIO_INSTALL_PLUGINS=0 \
351 - COMPOSIO_GITHUB_URL="$github_url" \
352 - COMPOSIO_GITHUB_API_BASE_URL="$api_base" \
353 - COMPOSIO_GITHUB_OWNER=FakeOwner \
354 - COMPOSIO_GITHUB_REPO=fake-repo \
361 TEST_BASE_MODE="${CASE_BASE_MODE:-ok}" \
356 - TEST_CHECKSUM_MODE=missing \
357 - TEST_SHELL_CAPABILITY="${CASE_SHELL_CAPABILITY:-supported}" \
358 - TEST_INSTALL_EXIT="${CASE_INSTALL_EXIT:-0}" \
359 - TEST_CURL_DELAY_URL="${CASE_CURL_DELAY_URL:-}" \
360 - TEST_CURL_DELAY_SECONDS="${CASE_CURL_DELAY_SECONDS:-1}" \
361 - TEST_CURL_PARENT_PID_FILE="$case_root/curl-parent.pid" \
362 "$interpreter" "$repo_root/install/$shell_name.sh" "$@"
363 }
364
@@ -479,35 +479,36 @@ EOF
479 run_installer "$case_root/unset-shell-home" "$case_root/unset-shell-install" "$case_root/unset-shell-bin" "$stable_tag" >/dev/null 2>&1 ||
480 fail "$interpreter_name unset SHELL must not fail after installation"
481
482 + # Runs the given command in the background, SIGTERMs it once the delayed
483 + # download is reached, and asserts the process exits with 128+15.
484 + assert_sigterm_143() {
485 + local label=$1
486 + local output_file=$2
487 + shift 2
488 + "$@" >"$output_file" 2>&1 &
489 + local signal_job=$!
490 + wait_for_file "$case_root/curl-parent.pid" "$interpreter_name $label did not reach delayed download"
491 + local signal_pid
492 + signal_pid=$(<"$case_root/curl-parent.pid")
493 + kill -TERM "$signal_pid"
494 + local signal_status=0
495 + if wait "$signal_job"; then
496 + fail "$interpreter_name $label must terminate after SIGTERM"
497 + else
498 + signal_status=$?
499 + fi
500 + [[ $signal_status -eq 143 ]] || fail "$interpreter_name $label SIGTERM status (got $signal_status)"
501 + }
502 +
503 reset_case
504 CASE_CURL_DELAY_URL="$github_url/FakeOwner/fake-repo/releases/download/$stable_tag/$archive_name"
484 - signal_output="$case_root/signal-installer.log"
485 - run_installer "$case_root/signal-home" "$case_root/signal-install" "$case_root/signal-bin" "$stable_tag" >"$signal_output" 2>&1 &
486 - signal_job=$!
487 - wait_for_file "$case_root/curl-parent.pid" "$interpreter_name installer did not reach delayed download"
488 - signal_pid=$(<"$case_root/curl-parent.pid")
489 - kill -TERM "$signal_pid"
490 - if wait "$signal_job"; then
491 - fail "$interpreter_name installer must terminate after SIGTERM"
492 - else
493 - signal_status=$?
494 - fi
495 - [[ $signal_status -eq 143 ]] || fail "$interpreter_name installer SIGTERM status (got $signal_status)"
505 + assert_sigterm_143 'installer' "$case_root/signal-installer.log" \
506 + run_installer "$case_root/signal-home" "$case_root/signal-install" "$case_root/signal-bin" "$stable_tag"
507
508 reset_case
509 CASE_CURL_DELAY_URL=$script_url
499 - variant_signal_output="$case_root/signal-variant.log"
500 - run_variant zsh "$case_root/signal-variant-home" "$case_root/signal-variant-install" "$case_root/signal-variant-bin" "$stable_tag" >"$variant_signal_output" 2>&1 &
501 - variant_signal_job=$!
502 - wait_for_file "$case_root/curl-parent.pid" "$interpreter_name shell variant did not reach delayed download"
503 - variant_signal_pid=$(<"$case_root/curl-parent.pid")
504 - kill -TERM "$variant_signal_pid"
505 - if wait "$variant_signal_job"; then
506 - fail "$interpreter_name shell variant must terminate after SIGTERM"
507 - else
508 - variant_signal_status=$?
509 - fi
510 - [[ $variant_signal_status -eq 143 ]] || fail "$interpreter_name shell variant SIGTERM status (got $variant_signal_status)"
510 + assert_sigterm_143 'shell variant' "$case_root/signal-variant.log" \
511 + run_variant zsh "$case_root/signal-variant-home" "$case_root/signal-variant-install" "$case_root/signal-variant-bin" "$stable_tag"
512
513 reset_case
514 CASE_GITHUB_URL='http://127.0.0.1:8929'