30
writes.map(write => (write.body as { body: string }).body);
31
32
describe('release approval rule', () => {
33
- const excluded = ['author', 'requester'];
33
const review = { user: 'reviewer', state: 'APPROVED', commitId: head, permission: 'write' };
34
35
test.each([
40
true,
41
],
42
['the requester', [{ ...review, user: 'requester' }], false],
43
+ ['an admin requester', [{ ...review, user: 'requester', permission: 'admin' }], true],
44
+ [
45
+ 'a requester with maintain permission',
46
+ [{ ...review, user: 'requester', permission: 'maintain' }],
47
+ false,
48
+ ],
49
+ [
50
+ 'an admin requester approving an older commit',
51
+ [{ ...review, user: 'requester', permission: 'admin', commitId: base }],
52
+ false,
53
+ ],
54
+ [
55
+ 'an admin requester whose approval was dismissed',
56
+ [{ ...review, user: 'requester', permission: 'admin', state: 'DISMISSED' }],
57
+ false,
58
+ ],
59
+ [
60
+ 'an admin requester while another writer requests changes',
61
+ [
62
+ { ...review, user: 'requester', permission: 'admin' },
63
+ { ...review, user: 'maintainer', state: 'CHANGES_REQUESTED' },
64
+ ],
65
+ false,
66
+ ],
67
['the author', [{ ...review, user: 'author' }], false],
68
+ ['an admin author', [{ ...review, user: 'author', permission: 'admin' }], false],
69
['an approval of an older commit', [{ ...review, commitId: base }], false],
70
['a reader', [{ ...review, permission: 'read' }], false],
71
['an approval later overridden', [review, { ...review, state: 'CHANGES_REQUESTED' }], false],
75
false,
76
],
77
])('%s → %p', (_name, reviews, expected) => {
54
- expect(eligibleApproval(reviews, excluded, head)).toBe(expected);
78
+ expect(eligibleApproval(reviews, 'author', 'requester', head)).toBe(expected);
79
});
80
});
81
82
describe('source tag', () => {
83
+ test('an admin requester can approve the exact bot-authored head', async () => {
84
+ const { fetcher, writes } = fakeController({
85
+ reviewer: 'requester',
86
+ reviewerPermission: 'admin',
87
+ });
88
+ expect(await tag(fetcher)).toEqual(tagged);
89
+ expect(writes).toEqual([tagWrite]);
90
+ });
91
+
92
test.each(['merge', 'squash'] as const)(
93
'a merged, approved release tags the reviewed head (%s merge)',
94
async mergeKind => {
163
164
test.each<[string, ControllerOptions, string]>([
165
['the requester approves', { reviewer: 'requester' }, 'lacks an approval'],
166
+ [
167
+ 'the admin requester approves an older head',
168
+ { reviewer: 'requester', reviewerPermission: 'admin', oldReview: true },
169
+ 'lacks an approval',
170
+ ],
171
+ [
172
+ 'the admin requester approves but the candidate build failed',
173
+ { reviewer: 'requester', reviewerPermission: 'admin', failedCandidate: true },
174
+ 'SDK candidate (typescript)',
175
+ ],
176
['the approval is for an older head', { oldReview: true }, 'lacks an approval'],
177
['a human pushed the head', { headAuthor: 'writer' }, 'release App commit'],
178
[