@devries-cameron20 / composio Mirror · read-only / commits / 0639997cc
Fork 0

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

Mirrored from https://github.com/Camo67/composio.git

Synced Nov 21, 22:15 UTC

docs(connected-accounts): collapse the duplicated REVOKED-scope invariant

The same OAuth2-only / S2S_OAUTH2-next scope was documented in two adjacent comment blocks: above `Oauth2RevokedConnectionDataSchema` and above `S2SOauth2ConnectionDataSchema`. Keep the canonical one on the S2S_OAUTH2 schema (where it's load-bearing — the arm there is the preemptive one) and reduce the OAuth2 comment to a one-line cross-reference. Surfaced by code-simplicity review of PR #3344 (P3#2).

jkomyno committed May 7, 2026 at 10:54 UTC 0639997cc5b35220ecd6bea61abbd5475a81c44e
1 file changed +3 -8
ts/packages/core/src/types/connectedAccountAuthStates.types.ts
+3 -8
@@ -146,14 +146,9 @@ export const Oauth2InactiveConnectionDataSchema = Oauth2InitiatingConnectionData
146 }).catchall(z.unknown());
147
148 // Mirrors `Oauth2RevokedConnectionDataSchema` on the Apollo side
149 -// (`apps/apollo/src/lib/connected_accounts/schemes/connectionDataScheme.ts`):
150 -// shape matches the INITIATING schema with a status literal, plus an
151 -// optional `revoked_at` timestamp.
152 -//
153 -// Invariant (2026-05, Apollo PR #9550): REVOKED is emitted only for OAUTH2
154 -// today. S2S_OAUTH2 revocation is on Apollo's near-term roadmap — a matching
155 -// REVOKED arm exists in `S2SOauth2ConnectionDataSchema` below for when that
156 -// lands. Other auth schemes (api_key, basic, etc.) are not in scope.
149 +// (`apps/apollo/src/lib/connected_accounts/schemes/connectionDataScheme.ts`).
150 +// See the invariant comment above `S2SOauth2ConnectionDataSchema` below for
151 +// the OAuth2-only / S2S_OAUTH2-next scope.
152 export const Oauth2RevokedConnectionDataSchema = Oauth2InitiatingConnectionDataSchema.extend({
153 status: z.literal(ConnectionStatuses.REVOKED),
154 revoked_at: z.string().optional(),