Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.
Mirrored from https://github.com/Camo67/composio.git
Synced Nov 21, 19:45 UTC
fix(py): apply skip_default to agentic provider signatures (langchain, langgraph, autogen) (#3730)
## Summary Agentic providers honor `schema_config={"skip_defaults": True}` for `args_schema` (defaults stripped, fields become required) but were **not** applying the same `skip_default` to the function `__signature__`, so the wrapped tool's signature and `args_schema` disagreed about which defaulted params were optional. The sibling `llamaindex` provider already passed it to both. **Supersedes #3727.** This is the polished version, now that the ag2 migration (#3729) landed and `composio-autogen` imports again — so the autogen case uses a real import instead of the earlier source-load stub, and the parity tests run in CI. ## Changes - **langchain / langgraph** (original commit by @anxkhn): pass `skip_default=self.skip_default` to `get_signature_format_from_schema_params`. - **autogen**: same one-line alignment. autogen builds **only** `__signature__` (no `args_schema`), so it never had the *mismatch* — but its signature still ignored `skip_defaults`. Aligned for consistency; verified on the signature alone. - **tests**: `TestAgenticSkipDefaultsParity` guards each provider with `pytest.importorskip`; adds real-import autogen regression tests (no stub). - **CI + nox**: install `providers/autogen` in the unit-test job (`py.test.yml`) and the nox `tst` session so the autogen parity tests actually run, plus a **hard `import composio_autogen` smoke check** in CI. ## Why the CI import guard (not just the tests) The `importorskip`-guarded unit tests **skip** when a provider can't be imported — which is the correct behavior for optional providers, but means they'd *silently skip* if autogen broke on a fresh install (exactly the failure that #3729 just fixed). The extra `python -c "import composio_autogen"` in the import step is a **hard** check that fails loudly, so a future dependency breakage can't slip through as a green build. `providers/langchain` + `providers/autogen` co-install cleanly (verified: 59 packages, ag2 0.14.0, no conflict). langgraph continues to skip in CI — its code path is identical to langchain's, which runs. ## Type of change - [x] Bug fix ## How Has This Been Tested? - Base venv (langchain only): langchain parity **passes**, langgraph + autogen **skip** (no error). - CI-mirror (langchain + autogen, editable): **4 passed, 2 skipped (langgraph)** — autogen tests actually run and pass. - Regression proof, each provider: reverting only the provider line fails the skip-defaults case with `assert 5 is Parameter.empty`; restoring passes. Verified for langchain **and** autogen. - `ruff check`, `ruff format --check`, `mypy`, and full `tests/test_provider.py` (29 passed, 4 skipped) → clean. `py.test.yml` parses. ## Checklist - [x] I ran linters/tests locally and they passed - [x] I added tests: langchain/langgraph parity + regression, and autogen parity that runs in CI - [ ] Changeset: not applicable — Python-only change. ## Credits Original fix by @anxkhn (#3713 → #3727), preserved as the first commit and co-authored on the follow-up. --------- Co-authored-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>