@devries-cameron20 / composio Mirror · read-only / commits / 58a070500
Fork 0

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

Mirrored from https://github.com/Camo67/composio.git

Synced Nov 21, 22:15 UTC

refactor(cli): use ConnectedAccountListParams['statuses'] for the cast

Replace the conditional-type incantation `Parameters<typeof client.connectedAccounts.list>[0] extends infer P ? P extends { statuses?: infer S } ? S : never : never` at two call sites with a direct cast to `ConnectedAccountListParams['statuses']`, which `@composio/client` exports for exactly this purpose. ConnectedAccounts.ts:114 was already using the shorter form. Two issues with the previous form: (a) the comment claimed it "widens" the type, but `as` cannot add values, so the framing was misleading; (b) if Stainless ever renames or moves the `statuses` field, the conditional silently resolves to `never` and swallows the cast — the direct member access fails loudly at the typecheck instead. Trim the duplicated multi-line comments to one line per call site. Addresses PR #3344 review comment P2#7.

jkomyno committed May 7, 2026 at 10:20 UTC 58a0705005fc543c522059949b3c5f126d62afc1
2 files changed +8 -22
ts/packages/cli/src/commands/connected-accounts/commands/connected-accounts.list.cmd.ts
+4 -10
@@ -1,5 +1,6 @@
1 import { Command, Options } from '@effect/cli';
2 import { Effect, Option, Schema } from 'effect';
3 +import type { ConnectedAccountListParams } from '@composio/client/resources/connected-accounts';
4 import {
5 ComposioClientSingleton,
6 ConnectedAccountListResponse,
@@ -78,17 +79,10 @@ export const connectedAccountsCmd$List = Command.make(
79 client.connectedAccounts.list({
80 toolkit_slugs: toolkitSlugs,
81 user_ids: Option.isSome(userId) ? [userId.value] : undefined,
81 - // Cast bypasses the stale Stainless `statuses` union (still
82 - // missing 'REVOKED') so the CLI flag stays in sync with the
83 - // Apollo enum until @composio/client is regenerated.
82 + // Bypass the stale Stainless union (still missing 'REVOKED')
83 + // until @composio/client is regenerated.
84 statuses: Option.isSome(status)
85 - ? ([status.value] as Parameters<
86 - typeof client.connectedAccounts.list
87 - >[0] extends infer P
88 - ? P extends { statuses?: infer S }
89 - ? S
90 - : never
91 - : never)
85 + ? ([status.value] as ConnectedAccountListParams['statuses'])
86 : undefined,
87 limit: clampLimit(limit),
88 })
ts/packages/cli/src/services/composio-clients.ts
+4 -12
@@ -14,6 +14,7 @@ import {
14 } from 'effect';
15 import { Composio as _RawComposioClient, APIPromise } from '@composio/client';
16 import type { AuthConfigCreateParams } from '@composio/client/resources/auth-configs';
17 +import type { ConnectedAccountListParams } from '@composio/client/resources/connected-accounts';
18 import { Toolkit, Toolkits, ToolkitDetailed, type ToolkitSearchResult } from 'src/models/toolkits';
19 import { AuthConfigItem, AuthConfigItems } from 'src/models/auth-configs';
20 import { ConnectedAccountItem, ConnectedAccountItems } from 'src/models/connected-accounts';
@@ -1775,18 +1776,9 @@ function buildConnectedAccountsNamespace(
1776 client.connectedAccounts.list({
1777 toolkit_slugs: params.toolkit_slugs,
1778 user_ids: params.user_ids,
1778 - // Cast widens to whatever the Stainless-generated client
1779 - // currently accepts, plus 'REVOKED'. The cast bypasses the
1780 - // stale Stainless types so callers passing 'REVOKED' (a valid
1781 - // Apollo status) are forwarded as-is until @composio/client is
1782 - // regenerated.
1783 - statuses: params.statuses as Parameters<
1784 - typeof client.connectedAccounts.list
1785 - >[0] extends infer P
1786 - ? P extends { statuses?: infer S }
1787 - ? S
1788 - : never
1789 - : never,
1779 + // Bypass the stale Stainless union (still missing 'REVOKED')
1780 + // until @composio/client is regenerated.
1781 + statuses: params.statuses as ConnectedAccountListParams['statuses'],
1782 limit: params.limit,
1783 }),
1784 ConnectedAccountListResponse