Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.
Mirrored from https://github.com/Camo67/composio.git
Synced Nov 21, 06:00 UTC
fix(docs): expire KB review windows at their deadline, not the evening before (#5291)
This PR: - fixes the premature expiry behind https://github.com/ComposioHQ/composio/issues/5286: `verifyKb` rounded the time left before `reviewAfter` to whole days and treated 0 as expired, so from noon UTC on 2026-11-09 all 61 guides due `2026-11-10` were reported as "expired 0 day(s) ago" - decides expiry by comparing instants (`reviewAfter <= now`), the same rule `buildKbCatalog` already uses, so both gates flip at the same moment - floors the elapsed days only for the report text: "0 day(s) ago" on the deadline day, "1 day(s) ago" the next - leaves the verification-age and review-cliff warnings, and every guide date in the manifest, unchanged ## Still needed - The 61 guides reach their deadline at 2026-11-10T00:00Z. From then on the report is correct to flag them, and each one needs real editorial review (re-verify and set a new `reviewAfter`) or demotion to `needs-review`. This PR does not bump or demote anything. - https://github.com/ComposioHQ/composio/issues/5280 (support knowledge refresh failing) also has a separate GitHub App access error (404 while resolving the installation). This PR only removes the premature-expiry errors, so #5280 stays open, and no hosted App settings were changed. ## Verification - New boundary tests in `tests/static/kb-verify.test.ts`: the eve-of-deadline cases (12:25Z, 15:05Z, and 23:59:59.999Z on 2026-11-09) failed on `next` and pass now; the deadline instant and the next day report 0 and 1 days - `bun test tests/static/kb-verify.test.ts`: 27 passed; `bun run types:check` and oxlint pass - `bun run test` (docs static suite): 827 passed, 5 failed, all in `content-freshness.test.ts`, which does not import the KB verifier or any changed file (it builds temporary Git repositories), so they are unrelated to this change