@devries-cameron20 / composio Mirror · read-only / commits / c1900aac9
Fork 0

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

Mirrored from https://github.com/Camo67/composio.git

Synced Nov 21, 06:00 UTC

fix(release): skip reviews from deleted accounts in the tag gate

jkomyno committed Nov 5, 2026 at 18:20 UTC c1900aac9e555227d14a9cbd4546b4c98b9c9017
3 files changed +17 -10
scripts/sdk-release/approval.ts
+9 -10
@@ -43,7 +43,7 @@ export function eligibleApproval(
43 }
44
45 const PullReview = Schema.Struct({
46 - user: Schema.Struct({ login: Schema.String }),
46 + user: Schema.NullOr(Schema.Struct({ login: Schema.String })),
47 state: Schema.String,
48 commit_id: Sha,
49 });
@@ -68,10 +68,15 @@ const HeadCommit = Schema.Struct({
68 /** Review decisions with each reviewer's repository permission, looked up once per login. */
69 const reviewsWithPermissions = (number: number) =>
70 Effect.gen(function* () {
71 + // A deleted account's review has `user: null`; it can't be a writer, so it is skipped.
72 const decisions = (yield* Stream.runCollect(
73 paginateArray(`${REPOSITORY_PATH}/pulls/${number}/reviews`, PullReview)
73 - )).filter(review => REVIEW_STATES.has(review.state));
74 - const logins = [...new Set(decisions.map(review => review.user.login))];
74 + )).flatMap(({ user, state, commit_id }) =>
75 + user !== null && REVIEW_STATES.has(state)
76 + ? [{ user: user.login, state, commitId: commit_id }]
77 + : []
78 + );
79 + const logins = [...new Set(decisions.map(review => review.user))];
80 const permissions = new Map(
81 yield* Effect.forEach(
82 logins,
@@ -88,13 +93,7 @@ const reviewsWithPermissions = (number: number) =>
93 )
94 );
95 return decisions.map(
91 - review =>
92 - ({
93 - user: review.user.login,
94 - state: review.state,
95 - commitId: review.commit_id,
96 - permission: permissions.get(review.user.login) ?? '',
97 - }) satisfies Review
96 + review => ({ ...review, permission: permissions.get(review.user) ?? '' }) satisfies Review
97 );
98 });
99
test/sdk-release-approval.test.ts
+6
@@ -77,6 +77,12 @@ describe('source tag', () => {
77 expect(writes).toEqual([tagWrite]);
78 });
79
80 + test("a deleted account's review is skipped and the approved head is still tagged", async () => {
81 + const { fetcher, writes } = fakeController({ deletedReviewer: true });
82 + expect(await tag(fetcher)).toBe('sdk-release/8');
83 + expect(writes).toEqual([tagWrite]);
84 + });
85 +
86 test('a release PR closed without merging creates no tag', async () => {
87 const { fetcher, writes } = fakeController({ closedUnmerged: true });
88 await expect(tag(fetcher)).rejects.toThrow('Release PR has not merged');
test/sdk-release-controller-fixture.ts
+2
@@ -50,6 +50,7 @@ export const releaseFiles = [
50 ];
51
52 export interface ControllerOptions {
53 + readonly deletedReviewer?: boolean;
54 readonly oldReview?: boolean;
55 readonly reviewer?: string;
56 readonly mergeKind?: 'squash' | 'merge';
@@ -123,6 +124,7 @@ export function fakeController(options: ControllerOptions = {}) {
124 if (path === '/pulls/9') return response(pull());
125 if (path.startsWith('/pulls/9/reviews'))
126 return response([
127 + ...(options.deletedReviewer ? [{ user: null, state: 'APPROVED', commit_id: head }] : []),
128 {
129 user: { login: options.reviewer ?? 'reviewer' },
130 state: 'APPROVED',