88
exit 1
89
`;
90
91
+/**
92
+ * An upgrade the process is not allowed to perform: the install directory is
93
+ * read-only and the CLI runs as an ordinary user (root would ignore the mode).
94
+ */
95
+const readOnlyInstallCommand = `
96
+set -u
97
+install_dir=/opt/composio-readonly
98
+source_dir=/tmp/composio-upgrade-source
99
+mkdir -p "$install_dir" "$source_dir"
100
+cp -r /usr/local/bin/. "$install_dir/"
101
+cp /usr/local/bin/composio "$source_dir/composio"
102
+${sourceBundleSetup}
103
+chmod -R a+rX "$source_dir"
104
+chmod -R a-w "$install_dir"
105
+
106
+before=$(stat -c '%i %s' "$install_dir/composio")
107
+upgrade_status=0
108
+HOME=/tmp/unprivileged-home DEBUG_OVERRIDE_UPGRADE_TARGET="$source_dir/composio" \
109
+ setpriv --reuid=1000 --regid=1000 --clear-groups "$install_dir/composio" upgrade || upgrade_status=$?
110
+after=$(stat -c '%i %s' "$install_dir/composio")
111
+version_output=$("$install_dir/composio" version)
112
+version_status=$?
113
+leftovers=$(find "$install_dir" -name '.composio-atomic-replace-*' | wc -l)
114
+printf 'upgrade_status=%s\nbefore=%s\nafter=%s\nversion_status=%s\nversion=%s\nleftovers=%s\n' \
115
+ "$upgrade_status" "$before" "$after" "$version_status" "$version_output" "$leftovers"
116
+`;
117
+
118
const outputField = (result: E2ETestResult, name: string): string => {
119
const match = result.stdout.match(new RegExp(`^${name}=(.*)$`, 'm'));
120
expect(match).not.toBeNull();
140
defineTests: ({ runCmd }) => {
141
let installedResult: E2ETestResult;
142
let copiedResult: E2ETestResult;
143
+ let readOnlyResult: E2ETestResult;
144
145
beforeAll(async () => {
146
installedResult = await runCmd(
149
copiedResult = await runCmd(
150
upgradeCommand({ executablePath: '/tmp/composio-copy/composio', copyExecutable: true })
151
);
152
+ readOnlyResult = await runCmd(readOnlyInstallCommand);
153
}, TIMEOUTS.FIXTURE);
154
155
describe('composio upgrade', () => {
161
expectAtomicUpgrade(copiedResult);
162
});
163
});
164
+
165
+ describe('composio upgrade without write permission on the install directory', () => {
166
+ it('fails and says which file it could not replace', () => {
167
+ expect(outputField(readOnlyResult, 'upgrade_status')).toBe('1');
168
+ expect(readOnlyResult.stderr).toContain('permission denied');
169
+ expect(readOnlyResult.stderr).toContain('/opt/composio-readonly/');
170
+ });
171
+
172
+ it('leaves the installed executable untouched and runnable', () => {
173
+ expect(outputField(readOnlyResult, 'after')).toBe(outputField(readOnlyResult, 'before'));
174
+ expect(outputField(readOnlyResult, 'version_status')).toBe('0');
175
+ expect(outputField(readOnlyResult, 'version')).toMatch(/\d+\.\d+\.\d+/);
176
+ });
177
+
178
+ it('leaves no temporary files behind', () => {
179
+ expect(outputField(readOnlyResult, 'leftovers')).toBe('0');
180
+ });
181
+ });
182
},
183
});