Alice — an open-source AI trading bot covering equities, crypto, commodities, forex, and macro
Refactor price handling in paper trading engine
Cameron “Camo” De Vries committed
Nov 6, 2026 at 03:21 UTC
bf3d27d9644e0425854a91020e96eb014f76e746
1 file changed
+18
-7
src/open_alice/engine/paper.py
+18
-7
@@ -2,6 +2,7 @@
2
3
from __future__ import annotations
4
5
+import math
6
from dataclasses import dataclass, field
7
from datetime import datetime
8
@@ -98,20 +99,30 @@ def run_paper(
99
row = signals.iloc[i]
100
prev = signals.iloc[i - 1]
101
102
+ price = float(row["Close"])
103
+ if not math.isfinite(price) or price <= 0:
104
+ continue
105
+
106
if row["Signal"] == 1 and prev["Signal"] != 1:
107
risk_amount = portfolio.equity * risk_per_trade
103
- stop_distance = row["Close"] * 0.05
108
+ stop_distance = price * 0.05
109
if stop_distance > 0:
110
shares = int(risk_amount / stop_distance)
111
if shares > 0:
107
- portfolio.buy(symbol, float(row["Close"]), shares)
112
+ portfolio.buy(symbol, price, shares)
113
114
elif row["Signal"] == -1 and prev["Signal"] != -1:
115
for sym in list(portfolio.positions.keys()):
111
- portfolio.sell(sym, float(row["Close"]))
112
-
113
- final_price = float(signals["Close"].iloc[-1])
114
- for sym in list(portfolio.positions.keys()):
115
- portfolio.sell(sym, final_price)
116
+ portfolio.sell(sym, price)
117
+
118
+ valid_closes = [
119
+ float(p)
120
+ for p in signals["Close"]
121
+ if math.isfinite(float(p)) and float(p) > 0
122
+ ]
123
+ if valid_closes:
124
+ final_price = valid_closes[-1]
125
+ for sym in list(portfolio.positions.keys()):
126
+ portfolio.sell(sym, final_price)
127
128
return portfolio