@devries-cameron20 / open-alice / commits / fd5a7a6
Fork 0

Alice — an open-source AI trading bot covering equities, crypto, commodities, forex, and macro

Fix mypy errors: add Strategy protocol, fix type annotations in paper.py and data.py

Camo67 committed Oct 12, 2026 at 12:03 UTC fd5a7a6b20badd15306fed9a8f0a61dd39299502
5 files changed +29 -10
src/open_alice/cli.py
+2 -2
@@ -6,7 +6,7 @@ import argparse
6
7 from open_alice.data import add_returns, fetch_ohlcv
8 from open_alice.engine import run_backtest, run_paper
9 -from open_alice.strategies import BollingerStrategy, MacdStrategy, RsiStrategy, SmaCrossover
9 +from open_alice.strategies import BollingerStrategy, MacdStrategy, RsiStrategy, SmaCrossover, Strategy
10
11 STRATEGIES = {
12 "sma_crossover": SmaCrossover,
@@ -48,7 +48,7 @@ def main() -> None:
48 _run_paper(args)
49
50
51 -def _build_strategy(name: str, args: argparse.Namespace) -> object:
51 +def _build_strategy(name: str, args: argparse.Namespace) -> Strategy:
52 if name == "sma_crossover":
53 return SmaCrossover(fast=args.fast, slow=args.slow)
54 return STRATEGIES[name]()
src/open_alice/data.py
+6 -5
@@ -22,15 +22,16 @@ def fetch_ohlcv(
22 DataFrame with columns: Open, High, Low, Close, Volume.
23 """
24 ticker = yf.Ticker(symbol)
25 - df = ticker.history(period=period, interval=interval, auto_adjust=True)
26 - if df.empty:
25 + raw = ticker.history(period=period, interval=interval, auto_adjust=True)
26 + if raw.empty:
27 raise ValueError(f"No data returned for symbol: {symbol}")
28 + df = pd.DataFrame(raw)
29 df.index = pd.DatetimeIndex(df.index).tz_localize(None)
30 return df
31
32
33 def add_returns(df: pd.DataFrame) -> pd.DataFrame:
34 """Add a simple daily returns column."""
34 - df = df.copy()
35 - df["Return"] = df["Close"].pct_change()
36 - return df
35 + result = df.copy()
36 + result["Return"] = result["Close"].pct_change()
37 + return result
src/open_alice/engine/paper.py
+4 -2
@@ -7,6 +7,8 @@ from datetime import datetime
7
8 import pandas as pd
9
10 +from open_alice.strategies.base import Strategy
11 +
12
13 @dataclass
14 class PaperPosition:
@@ -20,7 +22,7 @@ class PaperPosition:
22 class PaperPortfolio:
23 cash: float
24 positions: dict[str, PaperPosition] = field(default_factory=dict)
23 - trades: list[dict] = field(default_factory=list)
25 + trades: list[dict[str, object]] = field(default_factory=list)
26
27 @property
28 def equity(self) -> float:
@@ -62,7 +64,7 @@ class PaperPortfolio:
64
65 def run_paper(
66 df: pd.DataFrame,
65 - strategy: object,
67 + strategy: Strategy,
68 symbol: str,
69 initial_capital: float = 100_000.0,
70 risk_per_trade: float = 0.02,
src/open_alice/strategies/__init__.py
+2 -1
@@ -1,8 +1,9 @@
1 """Trading strategies."""
2
3 +from open_alice.strategies.base import Strategy
4 from open_alice.strategies.bollinger import BollingerStrategy
5 from open_alice.strategies.macd import MacdStrategy
6 from open_alice.strategies.rsi import RsiStrategy
7 from open_alice.strategies.sma_crossover import SmaCrossover
8
8 -__all__ = ["SmaCrossover", "RsiStrategy", "MacdStrategy", "BollingerStrategy"]
9 +__all__ = ["Strategy", "SmaCrossover", "RsiStrategy", "MacdStrategy", "BollingerStrategy"]
src/open_alice/strategies/base.py new
+15
@@ -0,0 +1,15 @@
1 +"""Base strategy protocol."""
2 +
3 +from __future__ import annotations
4 +
5 +from typing import Protocol
6 +
7 +import pandas as pd
8 +
9 +
10 +class Strategy(Protocol):
11 + """Protocol that all trading strategies must implement."""
12 +
13 + def generate_signals(self, df: pd.DataFrame) -> pd.DataFrame:
14 + """Generate trading signals from OHLCV data."""
15 + ...