@devries-cameron20 / t3code-1 / commits / 044ba3ad67
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(server): preview pages loaded through a service worker identify as Chrome, not HeadlessChrome (#38445)

Sean Wilson committed Nov 18, 2026 at 16:14 UTC 044ba3ad67d0355fe1b624eae883e198b593def5
4 files changed +119 -8
apps/server/src/preview/PreviewBrowser.ts
+1 -1
@@ -25,7 +25,7 @@ import { openZipArchive } from "../zipArchive.ts";
25 // https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json
26 // Never pin below 156.0.8078.70: the shell has no CRLSet and older SPKI blocklists trust
27 // compromised eMudhra intermediates (crrev.com/c/8627687).
28 -const VERSION = "157.0.8103.78";
28 +export const VERSION = "157.0.8103.78";
29 const ARCHIVES = {
30 linux64: {
31 bytes: 127_965_683,
apps/server/src/preview/ServerBrowser.ts
+2 -1
@@ -603,6 +603,7 @@ const make = Effect.gen(function* () {
603 profilesDir: NodePath.join(config.stateDir, "server-browser", "profiles"),
604 idleBrowserMs: 5 * 60_000,
605 executable: () => runPromise(previewBrowser.executable),
606 + chrome: { version: PreviewBrowser.VERSION, platform: host.platform },
607 // An agent scope keeps Chrome out of the server's memory protection and OOM score.
608 launcher: async (executable) => {
609 const launch = await runPromise(
@@ -1134,7 +1135,7 @@ const make = Effect.gen(function* () {
1135 const cdp = await context.newCDPSession(page);
1136 await installPdfDocumentNavigation(cdp);
1137 // The desktop's page is already a normal browser. A popup's first request
1137 - // went out before it became a tab; everything after presents as Chrome.
1138 + // precedes this override, so its Sec-CH-UA brands still name HeadlessChrome.
1139 if (!desktop) await presentAsChrome(cdp, host);
1140 if (!desktop) await recordCopies(cdp);
1141 page.setDefaultTimeout(NAVIGATION_TIMEOUT_MS);
apps/server/src/preview/ServerBrowserContexts.test.ts
+88 -1
@@ -1,14 +1,19 @@
1 // @effect-diagnostics nodeBuiltinImport:off - Hands a real file on disk to a real desktop browser.
2 import * as NodeEvents from "node:events";
3 import * as NodeFS from "node:fs";
4 +import * as NodeHttp from "node:http";
5 +import type * as NodeNet from "node:net";
6 import * as NodeOS from "node:os";
7 import * as NodePath from "node:path";
8
9 import { INCOGNITO_BROWSER_PROFILE_ID } from "@t3tools/contracts";
10 +import * as HostProcess from "@t3tools/shared/HostProcess";
11 +import { it as effectIt } from "@effect/vitest";
12 +import * as Effect from "effect/Effect";
13 import { chromium, type Browser, type BrowserContext, type BrowserType } from "playwright-core";
14 import { beforeEach, describe, expect, it, vi } from "vite-plus/test";
15
11 -import { ServerBrowserContexts } from "./ServerBrowserContexts.ts";
16 +import { presentAsChrome, ServerBrowserContexts } from "./ServerBrowserContexts.ts";
17
18 const launches = vi.hoisted(() => ({
19 launch: vi.fn<BrowserType["launch"]>(),
@@ -16,6 +21,7 @@ const launches = vi.hoisted(() => ({
21 mkdir: vi.fn().mockResolvedValue(undefined),
22 rm: vi.fn().mockResolvedValue(undefined),
23 }));
24 +const launchChromium = chromium.launch.bind(chromium);
25 const launchPersistentChromium = chromium.launchPersistentContext.bind(chromium);
26 vi.spyOn(chromium, "launch").mockImplementation(launches.launch);
27 vi.spyOn(chromium, "launchPersistentContext").mockImplementation(launches.persistent);
@@ -61,6 +67,7 @@ const options = () => ({
67 profilesDir: "/test/profiles",
68 executable: vi.fn(async () => "/test/chromium"),
69 env: {},
70 + chrome: { version: "157.0.8103.78", platform: "linux" as NodeJS.Platform },
71 });
72
73 const withLauncher = () => {
@@ -393,4 +400,84 @@ describe("ServerBrowserContexts", () => {
400 NodeFS.rmSync(directory, { recursive: true, force: true });
401 }
402 });
403 +
404 + const sendsOneChromeIdentity = async (host: {
405 + readonly platform: NodeJS.Platform;
406 + readonly arch: string;
407 + }) => {
408 + // The pool's own launch options, on the browser Playwright installs for tests.
409 + launches.launch.mockImplementation((launch = {}) => {
410 + const { executablePath: _installed, ...bundled } = launch;
411 + return launchChromium(bundled);
412 + });
413 + const server = NodeHttp.createServer((request, response) => {
414 + const send = (type: string, body: string) =>
415 + response.writeHead(200, { "content-type": type }).end(body);
416 + if (request.url === "/worker.js") {
417 + return send(
418 + "text/javascript",
419 + `addEventListener("activate", (event) => event.waitUntil(clients.claim()));
420 + addEventListener("fetch", (event) => event.respondWith(fetch(event.request)));`,
421 + );
422 + }
423 + if (request.url === "/identity") {
424 + return send(
425 + "application/json",
426 + JSON.stringify({
427 + userAgent: request.headers["user-agent"],
428 + brands: request.headers["sec-ch-ua"],
429 + }),
430 + );
431 + }
432 + return send("text/html", "<!doctype html>");
433 + });
434 + await new Promise<void>((resolve) => server.listen(0, "127.0.0.1", resolve));
435 + try {
436 + // What this browser sends on this host without any override, as the oracle.
437 + const probe = await launchChromium();
438 + const version = probe.version();
439 + const major = version.split(".")[0];
440 + const headless = await (await probe.newPage()).evaluate(() => navigator.userAgent);
441 + await probe.close();
442 + const pool = new ServerBrowserContexts({
443 + ...options(),
444 + env: { ...process.env, T3CODE_SERVER_BROWSER_SANDBOX: "0" },
445 + chrome: { version, platform: host.platform },
446 + });
447 + try {
448 + const context = await pool.contextFor(INCOGNITO_BROWSER_PROFILE_ID);
449 + const page = await context.newPage();
450 + await presentAsChrome(await context.newCDPSession(page), host);
451 + await page.goto(`http://127.0.0.1:${(server.address() as NodeNet.AddressInfo).port}/`);
452 + const [fromPage, throughWorker] = (await page.evaluate(`(async () => {
453 + const identity = async () => (await fetch("/identity")).json();
454 + const fromPage = await identity();
455 + const controlled = new Promise((resolve) =>
456 + navigator.serviceWorker.addEventListener("controllerchange", resolve, { once: true }),
457 + );
458 + await navigator.serviceWorker.register("/worker.js");
459 + await controlled;
460 + return [fromPage, await identity()];
461 + })()`)) as ReadonlyArray<{ readonly userAgent: string; readonly brands: string }>;
462 + expect(headless).toContain(`HeadlessChrome/${version} `);
463 + expect(fromPage?.userAgent).toBe(
464 + headless.replace(`HeadlessChrome/${version}`, `Chrome/${major}.0.0.0`),
465 + );
466 + expect(fromPage?.brands).toContain('"Google Chrome"');
467 + expect(throughWorker?.userAgent).toBe(fromPage?.userAgent);
468 + } finally {
469 + await pool.close();
470 + }
471 + } finally {
472 + server.closeAllConnections();
473 + await new Promise<void>((resolve) => server.close(() => resolve()));
474 + }
475 + };
476 +
477 + effectIt.live("sends one Chrome identity from a page and from its service worker", () =>
478 + Effect.gen(function* () {
479 + const host = { platform: yield* HostProcess.Platform, arch: yield* HostProcess.Architecture };
480 + yield* Effect.promise(() => sendsOneChromeIdentity(host));
481 + }),
482 + );
483 });
apps/server/src/preview/ServerBrowserContexts.ts
+28 -5
@@ -63,6 +63,8 @@ interface Options {
63 ) => Promise<{ readonly path: string; readonly release: () => Promise<void> } | undefined>;
64 readonly diagnose?: (executable: string, cause: unknown) => Promise<unknown>;
65 readonly env?: NodeJS.ProcessEnv;
66 + /** Names Chrome in the browser's own user agent, which is all a service worker ever sends. */
67 + readonly chrome: { readonly version: string; readonly platform: NodeJS.Platform };
68 /** Closes the shared browser once it has held no context for this long. */
69 readonly idleBrowserMs?: number;
70 readonly onContextClose?: (context: BrowserContext) => void;
@@ -74,12 +76,30 @@ const UA_PLATFORMS: Partial<Record<NodeJS.Platform, string>> = {
76 win32: "Windows",
77 };
78
79 +// Chrome froze its user agent apart from the major version.
80 +const UA_SYSTEMS: Partial<Record<NodeJS.Platform, string>> = {
81 + darwin: "Macintosh; Intel Mac OS X 10_15_7",
82 + linux: "X11; Linux x86_64",
83 + win32: "Windows NT 10.0; Win64; x64",
84 +};
85 +
86 +const chromeToken = (major: string) => `Chrome/${major}.0.0.0`;
87 +
88 +const chromeUserAgent = (chrome: Options["chrome"]) => {
89 + const major = /^\d+/.exec(chrome.version)?.[0];
90 + const system = UA_SYSTEMS[chrome.platform];
91 + return major && system
92 + ? `Mozilla/5.0 (${system}) AppleWebKit/537.36 (KHTML, like Gecko) ${chromeToken(major)} Safari/537.36`
93 + : null;
94 +};
95 +
96 /** Change user agent and Sec-CH-UA together; sites block mismatches. */
97 const chromeIdentity = (
79 - headlessUserAgent: string,
98 + browser: { readonly product: string; readonly userAgent: string },
99 host: { readonly platform: NodeJS.Platform; readonly arch: string; readonly release: string },
100 ) => {
82 - const version = /HeadlessChrome\/((\d+)[\d.]*)/.exec(headlessUserAgent);
101 + // A launch that already named Chrome in the user agent still reports the headless product.
102 + const version = /^(?:Headless)?Chrome\/((\d+)[\d.]*)/.exec(browser.product);
103 const fullVersion = version?.[1];
104 const major = version?.[2];
105 if (!version || !fullVersion || !major) return null;
@@ -89,7 +109,7 @@ const chromeIdentity = (
109 { brand: "Not A(Brand", version: names("99") },
110 ];
111 return {
92 - userAgent: headlessUserAgent.replace(version[0], `Chrome/${major}.0.0.0`),
112 + userAgent: browser.userAgent.replace(/HeadlessChrome\/[\d.]+/, chromeToken(major)),
113 userAgentMetadata: {
114 brands: brands((value) => value),
115 fullVersionList: brands((value) => (value === major ? fullVersion : `${value}.0.0.0`)),
@@ -108,8 +128,8 @@ export const presentAsChrome = async (
128 cdp: CDPSession,
129 host: { readonly platform: NodeJS.Platform; readonly arch: string },
130 ) => {
111 - const { userAgent } = await cdp.send("Browser.getVersion");
112 - const identity = chromeIdentity(userAgent, { ...host, release: NodeOS.release() });
131 + const browser = await cdp.send("Browser.getVersion");
132 + const identity = chromeIdentity(browser, { ...host, release: NodeOS.release() });
133 if (identity) await cdp.send("Emulation.setUserAgentOverride", identity);
134 };
135
@@ -129,6 +149,8 @@ export class ServerBrowserContexts {
149 private async launchOptions() {
150 const executable = await this.options.executable();
151 const env = this.options.env ?? process.env;
152 + // A page's override never reaches its workers, so the browser itself must name Chrome.
153 + const userAgent = chromeUserAgent(this.options.chrome);
154 return {
155 executable,
156 env,
@@ -136,6 +158,7 @@ export class ServerBrowserContexts {
158 "--disable-gpu",
159 "--force-device-scale-factor=2",
160 "--disable-blink-features=AutomationControlled",
161 + ...(userAgent ? [`--user-agent=${userAgent}`] : []),
162 ],
163 ignoreDefaultArgs: ["--enable-automation"],
164 headless: true,