@devries-cameron20 / t3code-1 / commits / 058eea9246
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(pr): hide unsupported GitCafe review reactions (#36171)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

Simon Maggini committed Nov 14, 2026 at 08:11 UTC 058eea9246ffbf79fdc26f9988cd48c50f81d0ea
6 files changed +71 -12
apps/mobile/src/features/pull-requests/PullRequestReactions.tsx
+2 -2
@@ -145,7 +145,7 @@ export function PullRequestCommentFooter(props: {
145 >;
146 readonly permissions: Pick<
147 ReturnType<typeof usePullRequestPermissions>,
148 - "canEditComment" | "canReact"
148 + "canEditComment" | "canReactComment"
149 >;
150 readonly onChanged: () => void;
151 readonly onEdit?: () => void;
@@ -155,7 +155,7 @@ export function PullRequestCommentFooter(props: {
155 const reactions = comment.reactions ?? [];
156 const editableKind = comment.kind === "review" ? null : comment.kind;
157 const canEdit = editableKind !== null && props.permissions.canEditComment(comment);
158 - const { canReact } = props.permissions;
158 + const canReact = props.permissions.canReactComment(comment);
159 if (reactions.length === 0 && !canReact && !canEdit) return null;
160 return (
161 <View className="flex-row flex-wrap items-center gap-1.5">
apps/mobile/src/features/pull-requests/usePullRequestPermissions.ts
+3
@@ -4,6 +4,7 @@ import {
4 canEditPullRequestComment,
5 canEditPullRequestMaintainerEdits,
6 } from "@t3tools/client-runtime/pull-request-editing";
7 +import { canReactPullRequestComment } from "@t3tools/client-runtime/pull-request-reactions";
8 import type { PullRequestComment, PullRequestDetail } from "@t3tools/contracts";
9 import { usePullRequestConnected } from "./usePullRequestConnected";
10 import { composerPullRequests } from "../../state/pull-requests";
@@ -54,6 +55,8 @@ export function usePullRequestPermissions(params: PullRequestParams, pr: PullReq
55 connected && canUpdate && pr !== null && canEditPullRequestMaintainerEdits(pr),
56 canEditComment: (comment: Pick<PullRequestComment, "author" | "canEdit" | "kind">) =>
57 connected && canUpdateComment && pr !== null && canEditPullRequestComment(pr, comment),
58 + canReactComment: (comment: Pick<PullRequestComment, "kind">) =>
59 + connected && canSetReaction && pr !== null && canReactPullRequestComment(pr, comment),
60 canReact: connected && canSetReaction && pr?.capabilities.reactions === true,
61 canComment:
62 connected && canComment && pr?.capabilities.comment === true && pr.viewerPermissions.comment,
apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx
+2 -1
@@ -97,6 +97,7 @@ import {
97 pullRequestCompletionScope,
98 } from "./PullRequestMarkdownTextarea";
99 import { PullRequestReactionBar } from "./PullRequestReactions";
100 +import { canReactPullRequestComment } from "@t3tools/client-runtime/pull-request-reactions";
101 import { PullRequestResolveThreadButton } from "./PullRequestResolveThreadButton";
102 import { PullRequestConversationGhost } from "./PullRequestGhosts";
103 import { sectionCollapseAnchorScrollTop } from "./pullRequestSummaryScroll.logic";
@@ -695,7 +696,7 @@ export function PullRequestSummaryTab({
696 <PullRequestReactionBar
697 className="ml-auto justify-end"
698 reactions={comment.reactions ?? []}
698 - canReact={detail.capabilities.reactions === true}
699 + canReact={canReactPullRequestComment(detail, comment)}
700 subjectId={comment.id}
701 environmentId={environmentId}
702 reference={reference}
apps/web/src/components/pullRequest/PullRequestTimelineTab.tsx
+10 -6
@@ -56,6 +56,7 @@ import { PullRequestMarkdown } from "./PullRequestMarkdown";
56 import { PullRequestMoreReplies } from "./PullRequestMoreReplies";
57 import { PullRequestMarkdownEditor } from "./PullRequestMarkdownEditor";
58 import { PullRequestReactionBar } from "./PullRequestReactions";
59 +import { canReactPullRequestComment } from "@t3tools/client-runtime/pull-request-reactions";
60 import { PullRequestResolveThreadButton } from "./PullRequestResolveThreadButton";
61 import {
62 PullRequestActorAvatar,
@@ -75,7 +76,7 @@ import { LegendList, type LegendListRef } from "@legendapp/list/react";
76
77 interface ReactionSurface {
78 revealAnchor?: string | null;
78 - readonly canReact: boolean;
79 + readonly canReact: (event: PullRequestTimelineEvent) => boolean;
80 /** Absent where there is no composer beside the panel to add a remark to. */
81 readonly onAddToChat?: ((comment: PullRequestComment) => void) | undefined;
82 readonly environmentId: EnvironmentId;
@@ -245,6 +246,7 @@ function ConversationCard({
246 /** A reply goes with its conversation, from the card that heads it. */
247 reply?: boolean;
248 }) {
249 + const canReact = reactions.canReact(event);
250 const [editing, setEditing] = useState(false);
251 const [saving, setSaving] = useState(false);
252 const updateComment = useAtomCommand(pullRequestEnvironment.updateComment, {
@@ -304,11 +306,11 @@ function ConversationCard({
306 {event.body && event.comment && !reply ? (
307 <AddToChatButton comment={event.comment} reactions={reactions} />
308 ) : null}
307 - {reactions.canReact || event.reactions.length > 0 ? (
309 + {canReact || event.reactions.length > 0 ? (
310 <PullRequestReactionBar
311 className="ml-auto justify-end"
312 reactions={event.reactions}
311 - canReact={reactions.canReact}
313 + canReact={canReact}
314 subjectId={event.id}
315 environmentId={reactions.environmentId}
316 reference={reactions.reference}
@@ -656,6 +658,7 @@ function ReviewVerdictEvent({
658 onOpen: (url: string) => void;
659 reactions: ReactionSurface;
660 }) {
661 + const canReact = reactions.canReact(event);
662 return (
663 <div className="group relative mb-5 pl-12 [contain-intrinsic-block-size:48px] [content-visibility:auto]">
664 <ActorTimelineMarker
@@ -703,11 +706,11 @@ function ReviewVerdictEvent({
706 {event.body && event.comment ? (
707 <AddToChatButton comment={event.comment} reactions={reactions} />
708 ) : null}
706 - {reactions.canReact || event.reactions.length > 0 ? (
709 + {canReact || event.reactions.length > 0 ? (
710 <PullRequestReactionBar
711 className="ml-auto justify-end"
712 reactions={event.reactions}
710 - canReact={reactions.canReact}
713 + canReact={canReact}
714 subjectId={event.id}
715 environmentId={reactions.environmentId}
716 reference={reactions.reference}
@@ -779,7 +782,8 @@ export function PullRequestTimelineTab({
782 const newestCommitAt = newestPullRequestCommitAt(detail.commits);
783 const reactions: ReactionSurface = {
784 revealAnchor: anchor,
782 - canReact: detail.capabilities.reactions === true,
785 + canReact: (event) =>
786 + event.comment !== undefined && canReactPullRequestComment(detail, event.comment),
787 onAddToChat: onAddToChat && ((comment) => onAddToChat({ kind: "comment", comment })),
788 environmentId,
789 threadRef,
packages/client-runtime/src/pullRequestReactions.test.ts
+38 -2
@@ -1,7 +1,15 @@
1 -import type { PullRequestReaction, PullRequestReactionContent } from "@t3tools/contracts";
1 +import {
2 + SourceControlProviderKind,
3 + type PullRequestDetail,
4 + type PullRequestReaction,
5 + type PullRequestReactionContent,
6 +} from "@t3tools/contracts";
7 import { describe, expect, it } from "vite-plus/test";
8
4 -import { applyPendingPullRequestReactions } from "./pullRequestReactions.ts";
9 +import {
10 + applyPendingPullRequestReactions,
11 + canReactPullRequestComment,
12 +} from "./pullRequestReactions.ts";
13
14 function reaction(overrides: Partial<PullRequestReaction> = {}): PullRequestReaction {
15 return {
@@ -13,6 +21,34 @@ function reaction(overrides: Partial<PullRequestReaction> = {}): PullRequestReac
21 };
22 }
23
24 +describe("comment reaction permissions", () => {
25 + it("excludes only GitCafe review summaries from comment reactions", () => {
26 + const detail = {
27 + provider: SourceControlProviderKind.make("gitcafe"),
28 + capabilities: {
29 + diff: true,
30 + comment: true,
31 + actions: [],
32 + mergeMethods: [],
33 + search: true,
34 + reactions: true,
35 + review: { inlineComment: true, reply: true, resolve: true, verdicts: [] },
36 + reviewers: { request: true, listCandidates: true },
37 + },
38 + } satisfies Pick<PullRequestDetail, "provider" | "capabilities">;
39 +
40 + expect(canReactPullRequestComment(detail, { kind: "issue-comment" })).toBe(true);
41 + expect(canReactPullRequestComment(detail, { kind: "review-comment" })).toBe(true);
42 + expect(
43 + canReactPullRequestComment(
44 + { ...detail, provider: SourceControlProviderKind.make("github") },
45 + { kind: "review" },
46 + ),
47 + ).toBe(true);
48 + expect(canReactPullRequestComment(detail, { kind: "review" })).toBe(false);
49 + });
50 +});
51 +
52 describe("pending reactions", () => {
53 const pending = (
54 entries: ReadonlyArray<readonly [PullRequestReactionContent, boolean]>,
packages/client-runtime/src/pullRequestReactions.ts
+16 -1
@@ -1,4 +1,19 @@
1 -import type { PullRequestReaction, PullRequestReactionContent } from "@t3tools/contracts";
1 +import type {
2 + PullRequestComment,
3 + PullRequestDetail,
4 + PullRequestReaction,
5 + PullRequestReactionContent,
6 +} from "@t3tools/contracts";
7 +
8 +export function canReactPullRequestComment(
9 + detail: Pick<PullRequestDetail, "provider" | "capabilities">,
10 + comment: Pick<PullRequestComment, "kind">,
11 +): boolean {
12 + return (
13 + detail.capabilities.reactions === true &&
14 + !(detail.provider === "gitcafe" && comment.kind === "review")
15 + );
16 +}
17
18 export const PULL_REQUEST_REACTION_ORDER: ReadonlyArray<PullRequestReactionContent> = [
19 "thumbs-up",