The best way to control Claude Code, Codex and more from any computer or phone
fix(shared): CSV and TSV attachments keep their table under generic file types (#30601)
tiliakoos committed
Nov 5, 2026 at 23:32 UTC
09647d188dcd817b7137a0932e2dca2e791f2bb4
2 files changed
+8
-2
packages/shared/src/delimitedPreview.test.ts
+5
-1
@@ -1,7 +1,11 @@
1
import { describe, expect, it } from "vite-plus/test";
2
-import { parseDelimitedPreview } from "./delimitedPreview.ts";
2
+import { filePreviewDelimiter, parseDelimitedPreview } from "./delimitedPreview.ts";
3
4
describe("delimited file previews", () => {
5
+ it("falls back to the file name under generic MIME types", () => {
6
+ expect(filePreviewDelimiter({ name: "a.csv", mimeType: "binary/octet-stream" })).toBe(",");
7
+ expect(filePreviewDelimiter({ name: "a.tsv", mimeType: "application/unknown" })).toBe("\t");
8
+ });
9
it("preserves quoted separators, escaped quotes, blank cells and line breaks", () => {
10
expect(
11
parseDelimitedPreview('\ufeffname,notes,empty\r\n"A, B","say ""hi""\nagain",\r\n', ","),
packages/shared/src/delimitedPreview.ts
+3
-1
@@ -1,8 +1,10 @@
1
+import { GENERIC_MIME_TYPES } from "./image.ts";
2
+
3
export function filePreviewDelimiter(file: { name: string; mimeType?: string }): "," | "\t" | null {
4
const mime = file.mimeType?.split(";", 1)[0]?.trim().toLowerCase();
5
if (mime === "text/csv") return ",";
6
if (mime === "text/tab-separated-values") return "\t";
5
- if (mime && mime !== "text/plain" && mime !== "application/octet-stream") return null;
7
+ if (mime && mime !== "text/plain" && !GENERIC_MIME_TYPES.has(mime)) return null;
8
if (/\.csv$/i.test(file.name)) return ",";
9
if (/\.tsv$/i.test(file.name)) return "\t";
10
return null;