The best way to control Claude Code, Codex and more from any computer or phone
fix(mobile): cancelled PR checks count as failing in the checks summary (#29809)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Alex Southwell committed
Nov 15, 2026 at 03:05 UTC
0d585f77107a58539d03e52e9ecefec74ad409db
3 files changed
+10
-3
apps/mobile/src/features/pull-requests/PullRequestStatusRows.tsx
+2
-2
@@ -27,6 +27,7 @@ import {
27
} from "./pullRequestActions";
28
import {
29
checkStatus,
30
+ isFailingCheck,
31
pullRequestBranchSummary,
32
pullRequestChecksSummary,
33
pullRequestReviewSummary,
@@ -132,8 +133,7 @@ export function PullRequestChecksRow(props: RowProps) {
133
exiting={PR_ROW_EXIT}
134
className="pl-8"
135
>
135
- {props.pr.state === "open" &&
136
- props.pr.checks.some((check) => check.status === "failure") ? (
136
+ {props.pr.state === "open" && props.pr.checks.some(isFailingCheck) ? (
137
<PullRequestAgentRow {...props} task="feedback" title="Fix failing checks" />
138
) : null}
139
{action.available("approve-workflows") ? (
apps/mobile/src/features/pull-requests/pullRequestStatus.test.ts
+3
@@ -97,5 +97,8 @@ describe("mobile overview check status", () => {
97
expect(
98
pullRequestChecksSummary({ checks: [check("success"), check("pending"), check("failure")] }),
99
).toMatchObject({ title: "1 check failing", count: "1 of 3" });
100
+ expect(
101
+ pullRequestChecksSummary({ checks: [check("success"), check("cancelled")] }),
102
+ ).toMatchObject({ title: "1 check failing", tint: "accent-danger-foreground" });
103
});
104
});
apps/mobile/src/features/pull-requests/pullRequestStatus.ts
+5
-1
@@ -88,8 +88,12 @@ export function checkStatus(check: PullRequestCheck) {
88
}
89
}
90
91
+export function isFailingCheck(check: PullRequestCheck) {
92
+ return check.status === "failure" || check.status === "cancelled";
93
+}
94
+
95
export function pullRequestChecksSummary(pr: Pick<PullRequestDetail, "checks">) {
92
- const failed = pr.checks.filter((check) => check.status === "failure").length;
96
+ const failed = pr.checks.filter(isFailingCheck).length;
97
const required = pr.checks.filter((check) => check.status === "action-required").length;
98
const pending = pr.checks.filter((check) => check.status === "pending").length;
99
const passed = pr.checks.filter((check) => check.status === "success").length;