The best way to control Claude Code, Codex and more from any computer or phone
chore(lint): enforce allOfMapToForEach (#25085)
Julius Marminge committed
Oct 25, 2026 at 18:18 UTC
16573c48f900eba453c6ab27298a843da8563bf3
5 files changed
+18
-19
apps/server/src/secrets/SecretRequests.test.ts
+3
-4
@@ -172,10 +172,9 @@ it.effect("two concurrent uses of one ref hand the value out once", () =>
172
answer: { type: "save", secret: "ghp_secret" },
173
});
174
const ref = Option.getOrThrow(yield* service.savedRef({ threadId, turnItemId }));
175
- const results = yield* Effect.all(
176
- [service.consume({ ref, projectId }), service.consume({ ref, projectId })].map(
177
- Effect.result,
178
- ),
175
+ const results = yield* Effect.forEach(
176
+ [service.consume({ ref, projectId }), service.consume({ ref, projectId })],
177
+ Effect.result,
178
{ concurrency: "unbounded" },
179
);
180
assert.deepEqual(results.map((result) => result._tag).toSorted(), ["Failure", "Success"]);
apps/server/src/serverSettings.test.ts
+3
-3
@@ -410,8 +410,9 @@ it.layer(NodeServices.layer)("server settings", (it) => {
410
Effect.gen(function* () {
411
const serverSettings = yield* ServerSettingsModule.ServerSettingsService;
412
const instanceId = ProviderInstanceId.make("acpRegistry_shared");
413
- const results = yield* Effect.all(
414
- ["First", "Second"].map((displayName) =>
413
+ const results = yield* Effect.forEach(
414
+ ["First", "Second"],
415
+ (displayName) =>
416
serverSettings
417
.updateProviderInstance({
418
operation: "create",
@@ -423,7 +424,6 @@ it.layer(NodeServices.layer)("server settings", (it) => {
424
},
425
})
426
.pipe(Effect.result),
426
- ),
427
{ concurrency: "unbounded" },
428
);
429
packages/effect-acp/src/client.test.ts
+8
-10
@@ -1068,16 +1068,14 @@ it.layer(NodeServices.layer)("effect-acp client", (it) => {
1068
yield* Queue.offer(
1069
input,
1070
concatBytes(
1071
- yield* Effect.all(
1072
- ["permission-a", "permission-b"].map((id) =>
1073
- encodeJsonl(PermissionRequest, {
1074
- jsonrpc: "2.0",
1075
- id,
1076
- method: "session/request_permission",
1077
- params: payload,
1078
- headers: [],
1079
- }),
1080
- ),
1071
+ yield* Effect.forEach(["permission-a", "permission-b"], (id) =>
1072
+ encodeJsonl(PermissionRequest, {
1073
+ jsonrpc: "2.0",
1074
+ id,
1075
+ method: "session/request_permission",
1076
+ params: payload,
1077
+ headers: [],
1078
+ }),
1079
),
1080
),
1081
);
packages/provider-acp/src/server/clientTerminals.test.ts
+3
-2
@@ -361,13 +361,14 @@ describe("AcpClientTerminals", () => {
361
sessionId: "foreign-session",
362
terminalId: created.terminalId,
363
};
364
- const results = yield* Effect.all(
364
+ const results = yield* Effect.forEach(
365
[
366
terminals.output(foreignRequest),
367
terminals.waitForExit(foreignRequest),
368
terminals.kill(foreignRequest),
369
terminals.release(foreignRequest),
370
- ].map((effect) => effect.pipe(Effect.result)),
370
+ ],
371
+ (effect) => effect.pipe(Effect.result),
372
{ concurrency: "unbounded" },
373
);
374
tsconfig.base.json
+1
@@ -24,6 +24,7 @@
24
"namespaceImportPackages": ["@effect/platform-node", "effect"],
25
"effectFn": ["span", "inferred-span", "suggested-span"],
26
"diagnosticSeverity": {
27
+ "allOfMapToForEach": "error",
28
"catchToOrElseSucceed": "error",
29
"unnecessaryFailYieldableError": "error",
30
"preferSucceedSomeOrNone": "error",