@devries-cameron20 / t3code-1 / commits / 1b22228e52
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(server): scheduled tasks no longer jump to the top when toggled (#22899)

Co-authored-by: Victor Vogel <satsdev@only21mil.xyz> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Theo Browne committed Oct 21, 2026 at 15:08 UTC 1b22228e52382a18c3b0721ad5154c74996b35ad
2 files changed +54 -1
apps/server/src/scheduledTasks/ScheduledTaskService.schedule.test.ts
+51
@@ -116,3 +116,54 @@ it.effect("preserves a due run when a save only pads the scheduled hour", () =>
116 }).pipe(Effect.provide(ScheduledTaskService.layer.pipe(Layer.provide(layerDependencies))));
117 }).pipe(Effect.provide(SqlitePersistence.layerMemory)),
118 );
119 +
120 +it.effect("keeps the task list order when a toggle or edit rewrites updated_at", () =>
121 + Effect.gen(function* () {
122 + yield* TestClock.setTime(Date.parse("2026-07-01T09:00:00.000Z"));
123 + const layerDependencies = Layer.mergeAll(
124 + NodeCrypto.layer,
125 + Scheduler.layer,
126 + Layer.mock(ThreadLaunchService.ThreadLaunchService)({}),
127 + Layer.mock(ManagedProjectFolders.ManagedProjectFolders)({
128 + namedProjectsRoot: "/projects",
129 + isScratchProject: () => Effect.succeed(false),
130 + }),
131 + Layer.mock(ThreadManagementService.ThreadManagementService)({}),
132 + Layer.mock(SecretRequests.SecretRequests)({}),
133 + );
134 + yield* Effect.gen(function* () {
135 + const service = yield* ScheduledTaskService.ScheduledTaskService;
136 + const input = (id: string) => ({
137 + id,
138 + title: id,
139 + prompt: "Review the open pull requests.",
140 + enabled: true,
141 + schedule: { type: "interval", everyMs: 60_000 },
142 + projectId: "project-stable-order",
143 + workspaceStrategy: { type: "root" },
144 + modelSelection: { instanceId: "codex", model: "gpt-5.4" },
145 + runtimeMode: "full-access",
146 + interactionMode: "default",
147 + });
148 + const listedIds = service
149 + .list()
150 + .pipe(Effect.map(({ tasks }) => tasks.map((task) => String(task.id))));
151 +
152 + const older = yield* service.upsert(yield* decodeUpsertInput(input("scheduled-task:older")));
153 + yield* TestClock.adjust("1 second");
154 + yield* service.upsert(yield* decodeUpsertInput(input("scheduled-task:newer")));
155 + const order = ["scheduled-task:newer", "scheduled-task:older"];
156 + expect(yield* listedIds).toEqual(order);
157 +
158 + yield* TestClock.adjust("1 second");
159 + const toggled = yield* service.setEnabled({ id: older.task.id, enabled: false });
160 + expect(toggled.task.updatedAt > older.task.updatedAt).toBe(true);
161 + expect(yield* listedIds).toEqual(order);
162 +
163 + yield* TestClock.adjust("1 second");
164 + const edit = { ...input(older.task.id), requireExisting: true, title: "Edited" };
165 + yield* service.upsert(yield* decodeUpsertInput({ ...edit, enabled: false }));
166 + expect(yield* listedIds).toEqual(order);
167 + }).pipe(Effect.provide(ScheduledTaskService.layer.pipe(Layer.provide(layerDependencies))));
168 + }).pipe(Effect.provide(SqlitePersistence.layerMemory)),
169 +);
apps/server/src/scheduledTasks/ScheduledTaskService.ts
+3 -1
@@ -456,7 +456,9 @@ export const layer = Layer.effect(
456 webhook_token,
457 webhook_secret
458 FROM scheduled_tasks
459 - ORDER BY updated_at DESC, task_id ASC
459 + -- Not updated_at: toggles, runs and edits rewrite it, and clients render
460 + -- this order as-is, so rows would move under the pointer.
461 + ORDER BY created_at DESC, task_id ASC
462 `;
463
464 const listRows = Effect.fn("ScheduledTaskService.listRows")(function* () {