The best way to control Claude Code, Codex and more from any computer or phone
fix(server): running a paused one-time task by hand no longer deletes it (#38463)
Julius Marminge committed
Nov 17, 2026 at 22:57 UTC
281d3e1cbe9e6dd6ed2d11b23caaccf3069509bb
2 files changed
+69
-1
apps/server/src/scheduledTasks/ScheduledTaskService.test.ts
+66
@@ -580,6 +580,72 @@ it.effect("a one-time task is removed once its turn completes", () =>
580
}).pipe(Effect.provide(SqlitePersistence.layerMemory)),
581
);
582
583
+it.effect("a paused one-time task run by hand before its time is kept", () =>
584
+ Effect.gen(function* () {
585
+ yield* TestClock.setTime(Date.parse("2026-11-01T07:00:00.000Z"));
586
+ const projectId = ProjectId.make("project:test");
587
+ const ended = yield* Deferred.make<void>();
588
+ const outcomeRead = yield* Deferred.make<void>();
589
+ const sent = yield* Ref.make("");
590
+ const run = { id: "run:1", status: "completed", rootNodeId: "node:root" };
591
+ const layer = ScheduledTaskService.layer.pipe(
592
+ Layer.provide(
593
+ Layer.mergeAll(
594
+ ManagedPolicy.layerTest(),
595
+ Layer.mock(ThreadLaunchService.ThreadLaunchService)({}),
596
+ Layer.mock(ThreadManagementService.ThreadManagementService)({
597
+ sendToThread: (input) => Ref.set(sent, input.messageId).pipe(Effect.as({} as never)),
598
+ getThreadShell: () => Effect.succeed(threadShell(projectId)),
599
+ getProjectThreadRecords: () =>
600
+ Effect.map(
601
+ Ref.get(sent),
602
+ (userMessageId) => ({ runs: [{ ...run, userMessageId }] }) as never,
603
+ ),
604
+ waitForThread: (input) =>
605
+ Deferred.await(ended).pipe(
606
+ Effect.tap(() => Deferred.succeed(outcomeRead, undefined)),
607
+ Effect.as({ threadId: input.threadId, run, timedOut: false } as never),
608
+ ),
609
+ }),
610
+ Layer.mock(SecretRequests.SecretRequests)({}),
611
+ Layer.mock(ManagedProjectFolders.ManagedProjectFolders)({
612
+ namedProjectsRoot: "/projects",
613
+ isScratchProject: () => Effect.succeed(false),
614
+ }),
615
+ NodeCrypto.layer,
616
+ Scheduler.layer,
617
+ ),
618
+ ),
619
+ );
620
+ yield* Effect.gen(function* () {
621
+ const service = yield* ScheduledTaskService.ScheduledTaskService;
622
+ const { task } = yield* service.upsert({
623
+ id: ScheduledTaskId.make("task:paused-once"),
624
+ title: "Release notes",
625
+ prompt: "Draft the release notes",
626
+ enabled: true,
627
+ schedule: { type: "once", runAt: "2026-11-01T08:00:00.000Z" },
628
+ projectId,
629
+ threadId: ThreadId.make("thread:once"),
630
+ workspaceStrategy: { type: "root" },
631
+ modelSelection: { instanceId: ProviderInstanceId.make("codex"), model: "gpt-5.4" },
632
+ runtimeMode: "full-access",
633
+ interactionMode: "default",
634
+ });
635
+ yield* service.setEnabled({ id: task.id, enabled: false });
636
+ yield* service.runNow({ id: task.id });
637
+ yield* Deferred.succeed(ended, undefined);
638
+ yield* Deferred.await(outcomeRead);
639
+ yield* TestClock.adjust("1 second");
640
+ const [kept] = (yield* service.list()).tasks;
641
+ assert.equal(kept?.id, task.id);
642
+ assert.equal(kept?.runCount, 1);
643
+ const resumed = yield* service.setEnabled({ id: task.id, enabled: true });
644
+ assert.equal(resumed.task.nextRunAt, "2026-11-01T08:00:00.000Z");
645
+ }).pipe(Effect.provide(layer));
646
+ }).pipe(Effect.provide(SqlitePersistence.layerMemory)),
647
+);
648
+
649
it.effect("a bound run follows its thread when promotion moves it mid-send", () =>
650
Effect.gen(function* () {
651
const scratch = ProjectId.make("project:scratch");
apps/server/src/scheduledTasks/ScheduledTaskService.ts
+3
-1
@@ -885,7 +885,8 @@ export const layer = Layer.effect(
885
886
// A dispatch is recorded once the message is accepted; the provider can still
887
// reject the turn after that, so follow the run and record its failure. A one-time
888
- // task whose turn completed is spent, so it is removed; its thread stays.
888
+ // task whose turn completed at or after its runAt is spent, so it is removed; its
889
+ // thread stays. A paused task always has a NULL next_run_at, so that alone proves nothing.
890
const recordRunOutcome = Effect.fn("ScheduledTaskService.recordRunOutcome")(function* (
891
taskId: ScheduledTaskId,
892
startedAtIso: string,
@@ -910,6 +911,7 @@ export const layer = Layer.effect(
911
WHERE task_id = ${taskId} AND last_run_at = ${startedAtIso}
912
AND last_run_status = 'succeeded' AND next_run_at IS NULL
913
AND json_extract(schedule_json, '$.type') = 'once'
914
+ AND julianday(last_run_at) >= julianday(json_extract(schedule_json, '$.runAt'))
915
RETURNING task_id
916
`;
917
if (removed.length > 0) yield* notifyChanged;