@devries-cameron20 / t3code-1 / commits / 2e39f1d7de
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(web): settings descriptions use the full row and stay two lines (#31826)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

oliver committed Nov 5, 2026 at 21:46 UTC 2e39f1d7dec44c98a4cabdaf99d3d99209f770c0
10 files changed +126 -15
apps/mobile/src/features/settings/ThreadSettingsSections.tsx
+3 -4
@@ -268,7 +268,7 @@ function BetaSettingsSection() {
268 </SettingsSection>
269 <Text className="px-2 text-sm text-foreground-muted">
270 Let agents on a machine work on your other machines, and theirs on it. Turn it on for each
271 - machine. While it is off, nothing new starts over a link; tasks already running finish.
271 + machine. While off, nothing new starts over a link; running tasks finish.
272 </Text>
273 </View>
274 );
@@ -306,9 +306,8 @@ function ToolCallVisibilitySection() {
306 ))}
307 </SettingsSection>
308 <Text className="px-2 text-sm text-foreground-muted">
309 - Hide the commands, edits, and searches agents run, so a thread reads like a conversation.
310 - Hide successful keeps calls that fail. Zen also hides the agent&apos;s in-between messages
311 - and shows only final answers. Approvals, questions, and errors always show.
309 + Hide the commands, edits, and searches agents run. Hide successful keeps failures. Zen shows
310 + only final answers. Approvals, questions, and errors always show.
311 </Text>
312 </View>
313 );
apps/mobile/src/features/settings/components/DatabaseStorageNotice.tsx
+1 -1
@@ -31,7 +31,7 @@ export function DatabaseStorageNotice({
31 return (
32 <SettingsSection
33 title="Reclaim database space"
34 - footer="Old history is cleaned up automatically, but these databases still hold the freed space. Run the command on each machine to return it to disk; it pauses and restarts the background service. Quit the desktop app first if it hosts the environment."
34 + footer="These databases still hold space freed by history cleanup. Run the command on each machine to reclaim it. It restarts the background service. Quit the desktop app first if it hosts the environment."
35 >
36 {visible.map(({ environmentId, status }) => (
37 <SettingsActionRow
apps/web/src/components/settings/DatabaseStorageNotice.tsx
+1 -1
@@ -35,7 +35,7 @@ export function DatabaseStorageNotice({
35 <SettingsSection id="storage-database" title="Database">
36 <SettingsRow
37 title="Reclaim freed database space"
38 - description="Old history is cleaned up automatically, but these databases still hold the freed space. Run the command on each machine to return it to disk; it pauses and restarts the background service. Quit the desktop app first if it hosts the environment."
38 + description="These databases still hold space freed by history cleanup. Run the command on each machine to reclaim it. It restarts the background service. Quit the desktop app first if it hosts the environment."
39 />
40 {visible.map(({ environmentId, status }) => (
41 <SettingsRow
apps/web/src/components/settings/LabsSettingsPanel.tsx
+5 -5
@@ -91,7 +91,7 @@ function ToolCallVisibilityRow() {
91 return (
92 <SettingsRow
93 {...searchableSetting("tool-call-visibility")}
94 - description="Hide the commands, edits, and searches agents run, so a thread reads like a conversation. Hide successful keeps calls that fail. Zen also hides the agent's in-between messages and shows only final answers. Approvals, questions, and errors always show."
94 + description="Hide the commands, edits, and searches agents run. Hide successful keeps failures. Zen shows only final answers. Approvals, questions, and errors always show."
95 control={
96 <div className="w-full sm:w-40">
97 <Select
@@ -125,7 +125,7 @@ function GuestLinksRowWithSignIn() {
125 return (
126 <SettingsRow
127 {...searchableSetting("guest-links")}
128 - description="Share a thread with a guest who watches it live in their browser and sends messages you approve. Sign in to T3 Connect to use guest links."
128 + description="Share a thread with a guest who watches it live in a browser and sends messages you approve. Sign in to T3 Connect to use guest links."
129 control={
130 <Button size="sm" variant="outline" onClick={openAuthPrompt}>
131 Sign in
@@ -156,12 +156,12 @@ function GuestLinksRow() {
156 managed={settings.guestSharingEnabled ? undefined : connectDenial}
157 description={
158 <>
159 - Share a thread with a guest who watches it live in their browser and sends messages you
159 + Share a thread with a guest who watches it live in a browser and sends messages you
160 approve. Needs T3 Connect: sign in and link this machine in{" "}
161 <Link to="/settings/access" className="underline underline-offset-2">
162 Sharing & access
163 </Link>
164 - . While it is off, every guest link stops working.
164 + . Turning it off stops every guest link.
165 </>
166 }
167 control={
@@ -191,7 +191,7 @@ function LinkedEnvironmentsRow() {
191 <Link to="/settings/connections" className="underline underline-offset-2">
192 Connections
193 </Link>
194 - . While it is off, nothing new starts over a link; tasks already running finish.
194 + . While off, nothing new starts over a link; running tasks finish.
195 </>
196 }
197 control={
apps/web/src/components/settings/VoiceSettingsPanel.tsx
+1 -1
@@ -1283,7 +1283,7 @@ export function VoiceSettingsPanel() {
1283 <SettingsSection id={searchableSetting("speech-post-processing").id} title="Cleanup">
1284 <SettingsRow
1285 title="Clean up transcripts with a provider"
1286 - description="Sends each transcript, plus the draft text around your cursor, to the text generation provider on the draft’s environment to fix punctuation, numbers, and spoken corrections. Your audio is never sent. Off by default."
1286 + description="Sends each transcript and the draft text around your cursor to the draft environment’s text generation provider to fix punctuation, numbers, and spoken corrections. Your audio is never sent."
1287 control={
1288 <Switch
1289 aria-label="Clean up transcripts with a provider"
apps/web/src/components/settings/settingsLayout.tsx
+3 -3
@@ -500,7 +500,7 @@ export function SettingsRow({
500 className,
501 )}
502 >
503 - <div className="flex flex-col gap-3 @min-[32rem]/settings-row:grid @min-[32rem]/settings-row:grid-cols-[minmax(0,1fr)_minmax(10rem,auto)] @min-[32rem]/settings-row:items-center @min-[32rem]/settings-row:gap-8">
503 + <div className="flex flex-col gap-3 @min-[32rem]/settings-row:grid @min-[32rem]/settings-row:grid-cols-[minmax(0,1fr)_auto] @min-[32rem]/settings-row:items-center @min-[32rem]/settings-row:gap-8">
504 <div className="min-w-0 flex-1 space-y-1">
505 <div className="flex min-h-5 items-center gap-1.5">
506 <h3 className="text-sm font-medium text-foreground">{title}</h3>
@@ -522,7 +522,7 @@ export function SettingsRow({
522 </span>
523 </div>
524 {description ? (
525 - <p className="max-w-2xl text-balance text-xs leading-normal text-muted-foreground">
525 + <p className="max-w-2xl text-pretty text-xs leading-normal text-muted-foreground">
526 {description}
527 </p>
528 ) : null}
@@ -531,7 +531,7 @@ export function SettingsRow({
531 ) : null}
532 </div>
533 {renderedControl ? (
534 - <div className="flex w-full min-w-0 shrink-0 items-center gap-2 @min-[32rem]/settings-row:w-auto @min-[32rem]/settings-row:justify-end">
534 + <div className="flex w-full min-w-0 shrink-0 items-center gap-2 @min-[32rem]/settings-row:w-auto @min-[32rem]/settings-row:justify-end @min-[32rem]/settings-row:[&_[data-slot=select-trigger]]:min-w-40">
535 {renderedControl}
536 </div>
537 ) : null}
oxlint-plugin-t3code/index.ts
+2
@@ -1,5 +1,6 @@
1 import { definePlugin } from "@oxlint/plugins";
2
3 +import maxSettingsDescriptionLength from "./rules/max-settings-description-length.ts";
4 import namespaceNodeImports from "./rules/namespace-node-imports.ts";
5 import noDomTestEnvironment from "./rules/no-dom-test-environment.ts";
6 import noEmDashCopy from "./rules/no-em-dash-copy.ts";
@@ -38,6 +39,7 @@ export default definePlugin({
39 name: "t3code",
40 },
41 rules: {
42 + "max-settings-description-length": maxSettingsDescriptionLength,
43 "namespace-node-imports": namespaceNodeImports,
44 "no-dom-test-environment": noDomTestEnvironment,
45 "no-em-dash-copy": noEmDashCopy,
oxlint-plugin-t3code/rules/max-settings-description-length.test.ts new
+43
@@ -0,0 +1,43 @@
1 +import { describe } from "@effect/vitest";
2 +
3 +import { createOxlintRuleHarness } from "../test/utils.ts";
4 +
5 +const rule = createOxlintRuleHarness("t3code/max-settings-description-length", {
6 + filename: "apps/web/src/components/settings/Example.tsx",
7 +});
8 +
9 +const long = "Agents ".repeat(30);
10 +
11 +describe("t3code/max-settings-description-length", () => {
12 + rule.valid(
13 + "allows a short description",
14 + `const row = <SettingsRow title="Theme" description="Choose how T3 Code looks." />;`,
15 + );
16 +
17 + rule.valid(
18 + "does not count dynamic text",
19 + `const row = <SettingsRow title="Task" description={\`${long.slice(0, 150)}\${prompt}\`} />;`,
20 + );
21 +
22 + rule.invalid(
23 + "reports a long string description",
24 + `const row = <SettingsRow title="Theme" description="${long}" />;`,
25 + );
26 +
27 + rule.invalid(
28 + "counts link text inside a JSX description",
29 + `
30 + const row = (
31 + <SettingsRow
32 + title="Guests"
33 + description={
34 + <>
35 + ${long.slice(0, 150)}{" "}
36 + <Link to="/docs">${long.slice(0, 60)}</Link>
37 + </>
38 + }
39 + />
40 + );
41 + `,
42 + );
43 +});
oxlint-plugin-t3code/rules/max-settings-description-length.ts new
+63
@@ -0,0 +1,63 @@
1 +import { defineRule, type ESTree } from "@oxlint/plugins";
2 +
3 +const MAX_LENGTH = 200;
4 +
5 +const MESSAGE = (length: number) =>
6 + `SettingsRow description is ${length} characters; keep it at ${MAX_LENGTH} or fewer so it stays two lines next to a control. Shorten the copy: keep each fact a user needs and drop restatements.`;
7 +
8 +type Node = ESTree.Node | ESTree.JSXElement["children"][number] | null | undefined;
9 +
10 +const staticText = (node: Node): string => {
11 + if (!node) return "";
12 + switch (node.type) {
13 + case "Literal":
14 + return typeof node.value === "string" ? node.value : "";
15 + case "TemplateLiteral":
16 + return node.quasis.map((quasi) => quasi.value.cooked ?? "").join("");
17 + case "JSXText":
18 + return node.value
19 + .split(/\r\n|\n|\r/u)
20 + .map((line, index, lines) => {
21 + const start = index > 0 ? line.trimStart() : line;
22 + return index < lines.length - 1 ? start.trimEnd() : start;
23 + })
24 + .filter(Boolean)
25 + .join(" ");
26 + case "JSXExpressionContainer":
27 + return node.expression.type === "JSXEmptyExpression" ? "" : staticText(node.expression);
28 + case "JSXElement":
29 + case "JSXFragment":
30 + return node.children.map(staticText).join("");
31 + case "ConditionalExpression": {
32 + const consequent = staticText(node.consequent);
33 + const alternate = staticText(node.alternate);
34 + return consequent.length >= alternate.length ? consequent : alternate;
35 + }
36 + default:
37 + return "";
38 + }
39 +};
40 +
41 +export default defineRule({
42 + meta: {
43 + type: "suggestion",
44 + docs: {
45 + description: `Limit SettingsRow descriptions to ${MAX_LENGTH} characters of static text. The column is at most 672px, about 110 characters per line next to a dropdown, so ${MAX_LENGTH} stays two lines.`,
46 + },
47 + },
48 + create(context) {
49 + return {
50 + JSXOpeningElement(node) {
51 + if (node.name.type !== "JSXIdentifier" || node.name.name !== "SettingsRow") return;
52 + for (const attribute of node.attributes) {
53 + if (attribute.type !== "JSXAttribute") continue;
54 + if (attribute.name.type !== "JSXIdentifier" || attribute.name.name !== "description") {
55 + continue;
56 + }
57 + const length = staticText(attribute.value).replace(/\s+/gu, " ").trim().length;
58 + if (length > MAX_LENGTH) context.report({ node: attribute, message: MESSAGE(length) });
59 + }
60 + },
61 + };
62 + },
63 +});
vite.config.ts
+4
@@ -519,6 +519,10 @@ export default defineConfig({
519 files: ["apps/web/src/**"],
520 rules: { "t3code/no-outset-state-indicators": "error" },
521 },
522 + {
523 + files: ["apps/web/src/**"],
524 + rules: { "t3code/max-settings-description-length": "error" },
525 + },
526 {
527 files: ["apps/*/src/**", "packages/*/src/**"],
528 excludeFiles: [