The best way to control Claude Code, Codex and more from any computer or phone
fix(desktop): startup log prune keeps files that rotation never names (#35378)
Julius Marminge committed
Nov 12, 2026 at 08:58 UTC
371963ce0b4cfe8bac3911efd57ae3af90750b41
2 files changed
+25
-2
apps/desktop/src/app/DesktopObservability.test.ts
+21
@@ -281,6 +281,27 @@ describe("DesktopObservability", () => {
281
),
282
);
283
284
+ it.effect("startup prunes only canonical rotation suffixes", () =>
285
+ Effect.gen(function* () {
286
+ const fileSystem = yield* FileSystem.FileSystem;
287
+ const directory = yield* fileSystem.makeTempDirectoryScoped({
288
+ prefix: "t3-desktop-rotating-prune-test-",
289
+ });
290
+ const filePath = `${directory}/server-child.log`;
291
+ const retained = ["1", "3", "04", "4.0", "4e0", "0x4", "+4", "notes"];
292
+ for (const suffix of [...retained, "4", "50"]) {
293
+ yield* fileSystem.writeFileString(`${filePath}.${suffix}`, suffix);
294
+ }
295
+
296
+ yield* DesktopObservability.makeRotatingLogFileWriter({ filePath, maxFiles: 3 });
297
+
298
+ assert.deepEqual(
299
+ (yield* fileSystem.readDirectory(directory)).sort(),
300
+ retained.map((suffix) => `server-child.log.${suffix}`).sort(),
301
+ );
302
+ }).pipe(Effect.scoped, Effect.provide(NodeServices.layer)),
303
+ );
304
+
305
it.effect("stops every export when the OpenTelemetry SDK is disabled", () => {
306
const requests: Array<ExportedRequest> = [];
307
return Effect.gen(function* () {
apps/desktop/src/app/DesktopObservability.ts
+4
-2
@@ -263,8 +263,10 @@ export const makeRotatingLogFileWriter = Effect.fn("makeRotatingLogFileWriter")(
263
const entries = yield* fileSystem.readDirectory(directory).pipe(Effect.orElseSucceed(() => []));
264
for (const entry of entries) {
265
if (!entry.startsWith(`${baseName}.`)) continue;
266
- const suffix = Number(entry.slice(baseName.length + 1));
267
- if (!Number.isInteger(suffix) || suffix <= maxFiles) continue;
266
+ const suffixText = entry.slice(baseName.length + 1);
267
+ const suffix = Number(suffixText);
268
+ if (!Number.isInteger(suffix) || String(suffix) !== suffixText || suffix <= maxFiles)
269
+ continue;
270
yield* fileSystem.remove(path.join(directory, entry), { force: true }).pipe(Effect.ignore);
271
}
272
});