@devries-cameron20 / t3code-1 / commits / 48cdefed5a
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(web): size markdown media whose width and height carry a px unit (#32108)

Julius Marminge committed Nov 13, 2026 at 14:05 UTC 48cdefed5ae38a76cd10affc112a2c96e882df04
2 files changed +30 -2
apps/web/src/components/ChatMarkdown.browser.test.tsx
+24
@@ -249,6 +249,30 @@ it("loads the <picture> source for the current theme through the image route", a
249 .toHaveAttribute("src", `${pixel}#/work/dark.png`);
250 });
251
252 +it("sizes a raw HTML image by width and height written with px units", async () => {
253 + setup();
254 + const largeImage = `data:image/svg+xml,${encodeURIComponent(
255 + '<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"/>',
256 + )}`;
257 + await using screen = await render(
258 + <HostImageUrlContext value={() => largeImage}>
259 + <ChatMarkdown
260 + cwd={undefined}
261 + parseRawHtml
262 + text={
263 + '### PR Review in progress <img src="/work/spinner.gif" alt="spinner" width="14px" height="7px" />'
264 + }
265 + />
266 + </HostImageUrlContext>,
267 + );
268 + const image = screen.getByAltText("spinner");
269 + await expect.element(image).toHaveAttribute("src", largeImage);
270 + const element = image.element() as HTMLImageElement;
271 + await element.decode();
272 + const { width, height } = element.getBoundingClientRect();
273 + expect({ width, height }).toEqual({ width: 14, height: 7 });
274 +});
275 +
276 it("reuses the parse of a streaming reply's finished blocks when it remounts", async () => {
277 setup();
278 const message = (
apps/web/src/components/chat/ChatMarkdownMedia.tsx
+6 -2
@@ -52,6 +52,10 @@ function markdownDestination(src: string): string {
52 return `<${escaped}>`;
53 }
54
55 +function parseImageDimension(value: string | number | undefined): number {
56 + return Number(typeof value === "string" ? value.trim().replace(/px$/i, "") : value);
57 +}
58 +
59 /**
60 * `maxHeightRem` folds a height cap into the width bound: `max-height` alone
61 * would not feed back through `aspect-ratio` once `width` is definite, so a
@@ -62,8 +66,8 @@ export function authoredImageSizeStyle(
66 height: string | number | undefined,
67 maxHeightRem = 30,
68 ): CSSProperties | undefined {
65 - const parsedWidth = Number(width);
66 - const parsedHeight = Number(height);
69 + const parsedWidth = parseImageDimension(width);
70 + const parsedHeight = parseImageDimension(height);
71 const hasWidth = Number.isFinite(parsedWidth) && parsedWidth > 0;
72 const hasHeight = Number.isFinite(parsedHeight) && parsedHeight > 0;
73 if (hasWidth && hasHeight) {