The best way to control Claude Code, Codex and more from any computer or phone
fix(provider-acp): redact API keys with underscores in ACP stderr logs (#24015)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>
Victor Vogel committed
Oct 29, 2026 at 12:40 UTC
49d014245777bbf47756635886ddf0846d2330d3
2 files changed
+14
-1
packages/provider-acp/src/server/stderr.test.ts
+13
@@ -50,4 +50,17 @@ describe("AcpStderr", () => {
50
expect(excerpt).not.toContain("dXNlcjpwYXNz");
51
expect(excerpt).not.toContain("ant-api-key-value");
52
});
53
+
54
+ it("redacts the whole key when its body contains underscores", () => {
55
+ const excerpt = sanitizeAcpStderrExcerpt(
56
+ [
57
+ "anthropic=sk-ant-api03-AbCdEf_GhIjKlMnOpQr-StUvWx_yz0123456789-AA",
58
+ "openai=sk-proj-AbCdEfGhIj_KlMnOpQrStUv-WxYz_0123456789",
59
+ ].join("\n"),
60
+ "/Users/ada",
61
+ {},
62
+ );
63
+
64
+ expect(excerpt).toBe("anthropic=[redacted]\nopenai=[redacted]");
65
+ });
66
});
packages/provider-acp/src/server/stderr.ts
+1
-1
@@ -6,7 +6,7 @@ const BEARER_TOKEN_PATTERN = /\bBearer\s+[A-Za-z0-9._\-+=/]+/gi;
6
const BASIC_AUTH_PATTERN = /\bAuthorization:\s*Basic\s+\S+/gi;
7
const API_KEY_HEADER_PATTERN = /\bx-api-key:\s*\S+/gi;
8
const SECRET_TOKEN_PATTERN =
9
- /\b(?:sk-[A-Za-z0-9][A-Za-z0-9-]{7,}|ghp_[A-Za-z0-9]+|xox[a-zA-Z]-[A-Za-z0-9-]+)\b/g;
9
+ /\b(?:sk-[A-Za-z0-9][A-Za-z0-9_-]{7,}|ghp_[A-Za-z0-9]+|xox[a-zA-Z]-[A-Za-z0-9-]+)\b/g;
10
11
export function appendAcpStderrTail(current: string, chunk: string): string {
12
const next = `${current}${chunk}`;