@devries-cameron20 / t3code-1 / commits / 5b265f8eb7
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(desktop): pnpm global commands find their bin directory (#38801)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

regexboi committed Nov 18, 2026 at 21:51 UTC 5b265f8eb7db05df055b2e882d4c10d332076d6b
3 files changed +10
apps/desktop/src/shell/DesktopShellEnvironment.test.ts
+6
@@ -231,12 +231,14 @@ describe("DesktopShellEnvironment", () => {
231 __MISE_DIFF: "old-mise",
232 SSH_AUTH_SOCK: "/old-session.sock",
233 JAVA_HOME: "/old/java",
234 + PNPM_HOME: "/old/pnpm",
235 SSL_CERT_FILE: "/old/cert.pem",
236 }),
237 });
238 const cachePath = `${stateDir}/shell-environment-cache.json`;
239 const cached = yield* fs.readFileString(cachePath).pipe(Effect.flatMap(decodeCache));
240 assert.equal(cached.environment.PATH, "/old/bin:/usr/bin");
241 + assert.equal(cached.environment.PNPM_HOME, "/old/pnpm");
242 assert.notProperty(cached.environment, "SSH_AUTH_SOCK");
243 const started = yield* Deferred.make<void>();
244 const release = yield* Deferred.make<void>();
@@ -285,6 +287,7 @@ describe("DesktopShellEnvironment", () => {
287 assert.equal(env.PATH, "/fresh/bin:/launcher/bin");
288 assert.equal(env.__MISE_DIFF, "fresh-mise");
289 assert.isUndefined(env.JAVA_HOME);
290 + assert.isUndefined(env.PNPM_HOME);
291 assert.isUndefined(env.SSL_CERT_FILE);
292 const fresh = yield* Stream.runHead(service.updates);
293 assert.isTrue(Option.isSome(fresh));
@@ -298,6 +301,7 @@ describe("DesktopShellEnvironment", () => {
301 const refreshed = yield* fs.readFileString(cachePath).pipe(Effect.flatMap(decodeCache));
302 assert.equal(refreshed.environment.PATH, "/fresh/bin:/launcher/bin");
303 assert.notProperty(refreshed.environment, "JAVA_HOME");
304 + assert.notProperty(refreshed.environment, "PNPM_HOME");
305 assert.notProperty(refreshed.environment, "SSL_CERT_FILE");
306 }).pipe(Effect.provide(NodeServices.layer)),
307 );
@@ -352,6 +356,7 @@ describe("DesktopShellEnvironment", () => {
356 PATH: "/cached/bin",
357 __MISE_DIFF: "cached-mise",
358 JAVA_HOME: "/cached/java",
359 + PNPM_HOME: "/cached/pnpm",
360 NODE_EXTRA_CA_CERTS: "/cached/ca.pem",
361 SSL_CERT_FILE: "/cached/cert.pem",
362 SSL_CERT_DIR: "/cached/certs",
@@ -392,6 +397,7 @@ describe("DesktopShellEnvironment", () => {
397 assert.equal(env.PATH, "/cached/bin:/usr/bin");
398 assert.equal(env.__MISE_DIFF, "cached-mise");
399 assert.equal(env.JAVA_HOME, "/launcher/java");
400 + assert.equal(env.PNPM_HOME, "/cached/pnpm");
401 assert.equal(env.NODE_EXTRA_CA_CERTS, "/launcher/ca.pem");
402 assert.equal(env.SSL_CERT_FILE, "");
403 assert.equal(env.SSL_CERT_DIR, "/cached/certs");
apps/desktop/src/shell/DesktopShellEnvironment.ts
+3
@@ -127,6 +127,7 @@ const LOGIN_SHELL_ENV_NAMES = [
127 "T3CODE_RELEASE_BASE_URL",
128 "__MISE_DIFF",
129 "JAVA_HOME",
130 + "PNPM_HOME",
131 ] as const;
132 const WINDOWS_PROFILE_ENV_NAMES = ["PATH", "FNM_DIR", "FNM_MULTISHELL_PATH"] as const;
133 const LOCALE_ENV_NAMES = ["LANG", "LC_ALL", "LC_CTYPE"] as const;
@@ -549,6 +550,7 @@ const installPosixEnvironment = Effect.fn("desktop.shellEnvironment.installPosix
550 "SSL_CERT_DIR",
551 "NODE_EXTRA_CA_CERTS",
552 "JAVA_HOME",
553 + "PNPM_HOME",
554 "T3CODE_TELEMETRY_ENABLED",
555 "T3CODE_GITHUB_APP_CLIENT_ID",
556 "T3CODE_RELEASE_BASE_URL",
@@ -652,6 +654,7 @@ const CACHED_ENV_NAMES = [
654 "HOMEBREW_CELLAR",
655 "HOMEBREW_REPOSITORY",
656 "JAVA_HOME",
657 + "PNPM_HOME",
658 "SSL_CERT_FILE",
659 "SSL_CERT_DIR",
660 "NODE_EXTRA_CA_CERTS",
packages/contracts/src/resourceTelemetry.ts
+1
@@ -324,6 +324,7 @@ export const ShellEnvironmentPatch = Schema.Struct({
324 T3CODE_RELEASE_BASE_URL: Schema.optionalKey(Schema.NullOr(Schema.String)),
325 __MISE_DIFF: Schema.optionalKey(Schema.NullOr(Schema.String)),
326 JAVA_HOME: Schema.optionalKey(Schema.NullOr(Schema.String)),
327 + PNPM_HOME: Schema.optionalKey(Schema.NullOr(Schema.String)),
328 FNM_DIR: Schema.optionalKey(Schema.NullOr(Schema.String)),
329 FNM_MULTISHELL_PATH: Schema.optionalKey(Schema.NullOr(Schema.String)),
330 });