@devries-cameron20 / t3code-1 / commits / 629242b8d3
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

fix(server): long scheduled-task titles no longer end in a broken character (#28831)

Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>

Victor committed Nov 14, 2026 at 07:44 UTC 629242b8d3ab6f1c626c5098bf932345d7926285
2 files changed +49 -12
apps/server/src/mcp/OrchestratorMcpService.test.ts
+44 -9
@@ -3375,7 +3375,7 @@ describe("OrchestratorMcpService provider resolution", () => {
3375 git: Partial<GitVcsDriver.GitVcsDriver["Service"]>,
3376 saved: Ref.Ref<ReadonlyArray<ScheduledTask["workspaceStrategy"]>>,
3377 task: ScheduledTask = existing,
3378 - modes?: Ref.Ref<ReadonlyArray<ScheduledTaskUpsertInput["threadMode"]>>,
3378 + inputs?: Ref.Ref<ReadonlyArray<ScheduledTaskUpsertInput>>,
3379 ) =>
3380 OrchestratorMcpService.layer.pipe(
3381 Layer.provide(Layer.mock(ThreadLaunchService.ThreadLaunchService)({})),
@@ -3407,9 +3407,9 @@ describe("OrchestratorMcpService provider resolution", () => {
3407 upsert: (input) =>
3408 Ref.update(saved, (strategies) => [...strategies, input.workspaceStrategy]).pipe(
3409 Effect.andThen(
3410 - modes === undefined
3410 + inputs === undefined
3411 ? Effect.void
3412 - : Ref.update(modes, (all) => [...all, input.threadMode]),
3412 + : Ref.update(inputs, (all) => [...all, input]),
3413 ),
3414 Effect.as({ task }),
3415 ),
@@ -3438,16 +3438,48 @@ describe("OrchestratorMcpService provider resolution", () => {
3438 }),
3439 );
3440
3441 + it.effect.each([
3442 + {
3443 + name: "drops an emoji the limit splits",
3444 + prompt: `${"a".repeat(79)}😀 rest`,
3445 + title: "a".repeat(79),
3446 + },
3447 + {
3448 + name: "keeps an emoji that ends at the limit",
3449 + prompt: `${"a".repeat(78)}😀 rest`,
3450 + title: `${"a".repeat(78)}😀`,
3451 + },
3452 + ])("a prompt-derived title $name", ({ prompt, title }) =>
3453 + Effect.gen(function* () {
3454 + const inputs = yield* Ref.make<ReadonlyArray<ScheduledTaskUpsertInput>>([]);
3455 + const mcp = yield* OrchestratorMcpService.OrchestratorMcpService.pipe(
3456 + Effect.provide(
3457 + service(
3458 + masterRepository,
3459 + yield* Ref.make<ReadonlyArray<ScheduledTask["workspaceStrategy"]>>([]),
3460 + existing,
3461 + inputs,
3462 + ),
3463 + ),
3464 + );
3465 + yield* mcp.scheduleTask(client, { projectId, prompt, schedule });
3466 + assert.deepEqual(
3467 + (yield* Ref.get(inputs)).map((input) => input.title),
3468 + [title],
3469 + );
3470 + }),
3471 + );
3472 +
3473 it.effect("keeps one thread when fresh sessions are turned off before the first run", () =>
3474 Effect.gen(function* () {
3443 - const modes = yield* Ref.make<ReadonlyArray<ScheduledTaskUpsertInput["threadMode"]>>([]);
3475 + const inputs = yield* Ref.make<ReadonlyArray<ScheduledTaskUpsertInput>>([]);
3476 const mcp = yield* OrchestratorMcpService.OrchestratorMcpService.pipe(
3477 Effect.provide(
3478 service(
3479 masterRepository,
3480 yield* Ref.make<ReadonlyArray<ScheduledTask["workspaceStrategy"]>>([]),
3481 { ...existing, threadMode: "fresh_session" },
3450 - modes,
3482 + inputs,
3483 ),
3484 ),
3485 );
@@ -3459,7 +3491,10 @@ describe("OrchestratorMcpService provider resolution", () => {
3491 scheduledTaskId: existing.id,
3492 bindToCurrentThread: false,
3493 });
3462 - assert.deepEqual(yield* Ref.get(modes), ["continue", "new_thread"]);
3494 + assert.deepEqual(
3495 + (yield* Ref.get(inputs)).map((input) => input.threadMode),
3496 + ["continue", "new_thread"],
3497 + );
3498 }),
3499 );
3500
@@ -3467,7 +3502,7 @@ describe("OrchestratorMcpService provider resolution", () => {
3502 "refuses unbinding into fresh sessions in one call, which would keep the thread",
3503 () =>
3504 Effect.gen(function* () {
3470 - const modes = yield* Ref.make<ReadonlyArray<ScheduledTaskUpsertInput["threadMode"]>>([]);
3505 + const inputs = yield* Ref.make<ReadonlyArray<ScheduledTaskUpsertInput>>([]);
3506 const mcp = yield* OrchestratorMcpService.OrchestratorMcpService.pipe(
3507 Effect.provide(
3508 service(
@@ -3478,7 +3513,7 @@ describe("OrchestratorMcpService provider resolution", () => {
3513 threadId: ThreadId.make("thread:scheduled-base"),
3514 threadMode: "continue",
3515 },
3481 - modes,
3516 + inputs,
3517 ),
3518 ),
3519 );
@@ -3490,7 +3525,7 @@ describe("OrchestratorMcpService provider resolution", () => {
3525 })
3526 .pipe(Effect.flip);
3527 assert.include(refused.message, "first unbind it");
3493 - assert.deepEqual(yield* Ref.get(modes), []);
3528 + assert.deepEqual(yield* Ref.get(inputs), []);
3529 }),
3530 );
3531
apps/server/src/mcp/OrchestratorMcpService.ts
+5 -3
@@ -2161,9 +2161,11 @@ const make = Effect.gen(function* () {
2161 }
2162 const modelSelection =
2163 parent?.thread.modelSelection ?? (yield* projectDefaultModelSelection(project));
2164 - const derivedTitle = input.prompt.split("\n")[0]?.trim() ?? "";
2165 - const title =
2166 - input.title ?? (derivedTitle.length > 0 ? derivedTitle.slice(0, 80) : "Scheduled task");
2164 + // Never end on a lone high surrogate, which renders as a broken character.
2165 + const derivedTitle = (input.prompt.split("\n")[0]?.trim() ?? "")
2166 + .slice(0, 80)
2167 + .replace(/[\uD800-\uDBFF]$/, "");
2168 + const title = input.title ?? (derivedTitle.length > 0 ? derivedTitle : "Scheduled task");
2169 const upsertInput: ScheduledTaskUpsertInput = {
2170 title,
2171 prompt: input.prompt,